Moodle

Log links incorrect for "assignment update grades" and "assignment view submission"

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.9
  • Fix Version/s: STABLE backlog
  • Component/s: Assignment
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

The id given inside the link is wrong. This is recorded in the log incorrectly. Also, I've noticed that the users IP does not record properly in the log. I've seen some that say 127.0.0.1 and many others that are just wrong.

Issue Links

This issue is duplicated by:
MDL-5267 Online assignments log the wrong action URL Trivial Open
This issue has a non-specific relationship to:
MDL-13894 Apache access log ip address and moodle stored ip addresses do not match. Major Closed
This issue has been marked as being related by:
MDL-14123 Full IPv6 support Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Keeping the IP thing apart (it's resported in other bugs).

About logs, can you take a look to the corresponding add_to_log() calls in assignment module and fix them when necessary?

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - Keeping the IP thing apart (it's resported in other bugs). About logs, can you take a look to the corresponding add_to_log() calls in assignment module and fix them when necessary? TIA and ciao
Hide
Permalink
Daniel Neis added a comment -

Hello,

i have attached a patch that corrects this behaviour.
The module was passing the this->assingment->id instead of this->cm->id .

Hope you like.

Show
Daniel Neis added a comment - Hello, i have attached a patch that corrects this behaviour. The module was passing the this->assingment->id instead of this->cm->id . Hope you like.
Hide
Permalink
Charles Fulton added a comment -

Confirmed that this is still present in 1.9.10+; the submitted patch still applies cleanly and resolves the issue.

Show
Charles Fulton added a comment - Confirmed that this is still present in 1.9.10+; the submitted patch still applies cleanly and resolves the issue.
Hide
Permalink
Thomas Haines added a comment -

I have encountered this problem and successfully deployed the patch. Please incorporate this into trunk.

Show
Thomas Haines added a comment - I have encountered this problem and successfully deployed the patch. Please incorporate this into trunk.
Hide
Permalink
Erwin Meza added a comment - - edited

Also note: the parameter 'user' should be 'userid'.

So the patch should look like this..

 'submissions.php?id='.$this->cm->id.'&userid='.$submission->userid. '&mode=single&offset='

the additional . '&mode=single&offset=' directs the url exactly to the submission, not the activity.

Show
Erwin Meza added a comment - - edited Also note: the parameter 'user' should be 'userid'. So the patch should look like this.. 
 'submissions.php?id='.$this->cm->id.'&userid='.$submission->userid. '&mode=single&offset='
the additional . '&mode=single&offset=' directs the url exactly to the submission, not the activity.

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.