[#MDL-14123] Full IPv6 support

Issue Details (XML | Word | Printable)

Key:	MDL-14123
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Dave Habben
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Full IPv6 support

Created: 01/Apr/08 04:22 AM Updated: 10/Jan/09 06:44 AM

Return to search

Component/s:

Course, Lib

Affects Version/s:

1.9

Fix Version/s:

2.0

Environment:

Red Hat Enterprise 5.1, with a public IPv6 address from http://www.sixxs.net

Issue Links:

Relates

This issue has a non-specific relationship to:

MDL-14121 Log links incorrect for "assignment update grades" and "assignment view submission"

~~MDL-13894~~ Apache access log ip address and moodle stored ip addresses do not match.

This issue has been marked as being related by:

MDL-17754 Session improvements and related rewrites

Database:	MySQL
Participants:	Dave Habben, Eloy Lafuente (stronk7), Petr Skoda and Tim Hunt
Security Level:	None
Resolved date:	10/Jan/09
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

When accessing the web server using an IPv6 address, the "Live Logs" feature no longer displays a correct address. Instead it displays the text "Click here ...".

With IPv4 the live logs display:
Time IP Address Full name Action Information
Mon March 31 2008, 01:09 PM 192.168.1.1 John Doe course view CIS252: Advanced Routing
the IP Address link also includes a link to:
http://moodle.svcc.edu/iplookup/index.php?ip=192.168.1.1&user=2

With IPv6 the live logs display:
Time IP Address Full name Action Information
Mon March 31 2008, 02:12 PM Click here ... John Doe course view CIS252: Advanced Routing
the IP Address link does not contain the IPv6 address and only includes:
http://moodle.svcc.edu/iplookup/index.php?ip=&user=2

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 01/Apr/08 09:23 AM

Hi Dave, thanks for your report.

I guess this is caused by the log->ip column in DB accepting only 15cc (IPv4). Can you try manually increasing the column size in your server? What would be a correct length?

I would propose to:

Under Moodle 1.9, check for length before inserting, because can be breaking other DBs no so "relaxed" as MySQL. If length excess, change it to something identifiable and prevent iplookup link completely for those records.

Under Moodle 2.0, change column specs to something able to store IPv6 addresses and check if iplookup works with IPv6. Depending on that, enable the link or no.

This should be fixed consistently in all reports showing IPs, not only live logs.

Assigning to Mathieu...TIA!

Ciao

Eloy Lafuente (stronk7) made changes - 01/Apr/08 09:23 AM

Field	Original Value	New Value
Fix Version/s		1.9.1 [ 10240 ]
Assignee	Donal McMullan [ donal@catalyst.net.nz ]	Mathieu Petit-Clair [ scyrma ]
Component/s		Course [ 10057 ]
Component/s		Lib [ 10096 ]
Component/s	Networking [ 10162 ]

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 01/Apr/08 09:28 AM

Linking with some more log-related problems...

Eloy Lafuente (stronk7) made changes - 01/Apr/08 09:28 AM

Link

This issue has a non-specific relationship to MDL-14121 [ MDL-14121 ]

Eloy Lafuente (stronk7) made changes - 01/Apr/08 09:28 AM

Link

This issue has a non-specific relationship to ~~MDL-13894~~ [ ~~MDL-13894~~ ]

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 01/Apr/08 09:34 AM

Also, note that the cleanremoteaddr() function seems to clean invalid (private) IPs and incorrect IPs (I guess IPv6 are handled as incorrect).

Ciao

Mathieu Petit-Clair made changes - 05/May/08 02:46 PM

Fix Version/s	1.9.1 [ 10240 ]
Fix Version/s		2.0 [ 10122 ]

Mathieu Petit-Clair made changes - 05/May/08 02:54 PM

Fix Version/s

1.9.1 [ 10240 ]

Martin Dougiamas made changes - 15/May/08 03:02 PM

Fix Version/s	1.9.1 [ 10240 ]
Fix Version/s		1.9.2 [ 10280 ]

Petr Skoda made changes - 05/Jul/08 07:49 PM

Fix Version/s	1.9.2 [ 10280 ]
Fix Version/s		1.9.3 [ 10290 ]
Fix Version/s	2.0 [ 10122 ]

Martin Dougiamas made changes - 15/Oct/08 03:00 PM

Fix Version/s	1.9.3 [ 10290 ]
Fix Version/s		1.9.4 [ 10300 ]

Petr Skoda made changes - 06/Jan/09 10:18 PM

Link

This issue has been marked as being related by MDL-17754 [ MDL-17754 ]

Petr Skoda made changes - 06/Jan/09 10:18 PM

Assignee

Mathieu Petit-Clair [ scyrma ]

Petr ?koda [ skodak ]

[ Permalink | « Hide ]

Petr Skoda added a comment - 06/Jan/09 10:19 PM

changing name of bug to Full IPv6 support - this will require database changes, I am afraid it is not possible to fully fix in 1.9.x - sorry.

Petr Skoda made changes - 06/Jan/09 10:19 PM

Summary	Live logs do not display IPv6 addresses	Full IPv6 support
Fix Version/s		2.0 [ 10122 ]
Fix Version/s	1.9.4 [ 10300 ]

[ Permalink | « Hide ]

Petr Skoda added a comment - 06/Jan/09 10:36 PM

hmm, there are several ways how to write ipv6:
ABCD:EF01:2345:6789:ABCD:EF01:2345:6789 - 39chars
FFFF:FFFF:FFFF:FFFF:FFFF:FFFF:129.144.152.138 - 45chars
and compressed forms

I think it should be better to use 45 chars. going to change all install.xml's now....

[ Permalink | « Hide ]

Dave Habben added a comment - 06/Jan/09 11:47 PM

With the 45 char comment, I think you may be referring to http://www.ietf.org/rfc/rfc3513.txt section 2.2.3
There are not as many fields with the bits all set to one as you have listed above.

Uncompressed this is what it would look like:
0000:0000:0000:0000:0000:FFFF:129.144.152.138
once leading zeros are compressed this could be smaller for storage in the database:
::FFFF:129.144.152.138
or
0:0:0:0:0:FFFF:129.144.152.138
if you'd prefer.

[ Permalink | « Hide ]

Petr Skoda added a comment - 07/Jan/09 12:50 AM

ah, right -will wait a bit and discuss it with more ppl, thanks

Petr Skoda committed 6 files to 'Moodle CVS' - 07/Jan/09 03:14 AM

~~MDL-14123~~ Full IPv6 support - updating all db fields to theoretical 45 char limit

MODIFY	lib/db/install.xml	Rev. 1.183	(+12 -10 lines)
MODIFY	mod/chat/db/upgrade.php	Rev. 1.9	(+14 -1 lines)
MODIFY	mod/chat/version.php	Rev. 1.32	(+2 -2 lines)
MODIFY	mod/chat/db/install.xml	Rev. 1.5	(+1 -1 lines)
MODIFY	version.php	Rev. 1.948	(+1 -1 lines)
MODIFY	lib/db/upgrade.php	Rev. 1.260	(+93 -31 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 07/Jan/09 07:18 AM

~~MDL-14123~~ Full IPv6 support - reimplemented cleanremoteaddr(), it now accepts local ips too

MODIFY

lib/moodlelib.php

Rev. 1.1145

(+77 -44 lines)

[ Permalink | « Hide ]

Tim Hunt added a comment - 07/Jan/09 11:19 AM

Petr, I know you have not finished, so you may know this already, but there is the quiz.subnet field, which takes a list of IP addresses, or address ranges, and the address_in_subnet method in moodlelib.php (which has extensive unit tests).

[ Permalink | « Hide ]

Petr Skoda added a comment - 07/Jan/09 05:20 PM

working on subnets right now :-D

Petr Skoda committed 2 files to 'Moodle CVS' - 09/Jan/09 07:16 PM

~~MDL-14123~~ cleanremoteaddr improvements and added unit tests

MODIFY	lib/simpletest/testmoodlelib.php		Rev. 1.16		(+21 -2 lines)
MODIFY	lib/moodlelib.php		Rev. 1.1148		(+22 -3 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 10/Jan/09 06:16 AM

~~MDL-14123~~ Full IPv6 support - reimplemented address_in_subnet() + added more unittests

MODIFY	lib/simpletest/testmoodlelib.php		Rev. 1.17		(+87 -32 lines)
MODIFY	lib/moodlelib.php		Rev. 1.1149		(+195 -28 lines)

Petr Skoda committed 3 files to 'Moodle CVS' - 10/Jan/09 06:41 AM

~~MDL-14123~~ Full IPv6 support - replaced mnet ip_in_range() by standard ipv6 compatible address_in_subnet(); replaced $_SERVER['REMOTE_ADDR'] with standard getremoteaddr()

MODIFY	mnet/lib.php	Rev. 1.32	(+1 -22 lines)
MODIFY	mnet/remote_client.php	Rev. 1.8	(+2 -6 lines)
MODIFY	admin/mnet/trustedhosts.php	Rev. 1.10	(+2 -6 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 10/Jan/09 06:44 AM

ipv6 support should be implemented now, please reopen in case I overlooked something or it does not work as expected

thanks everybody!

Petr Skoda made changes - 10/Jan/09 06:44 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.