[#MDL-14123] Full IPv6 support

Issue Details (XML | Word | Printable)

Key:	MDL-14123
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Dave Habben
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Full IPv6 support

Created: 01/Apr/08 04:22 AM Updated: 10/Jan/09 06:44 AM

Return to search

Component/s:

Course, Lib

Affects Version/s:

1.9

Fix Version/s:

2.0

Environment:

Red Hat Enterprise 5.1, with a public IPv6 address from http://www.sixxs.net

Issue Links:

Relates

This issue has a non-specific relationship to:

MDL-14121 Log links incorrect for "assignment update grades" and "assignment view submission"

~~MDL-13894~~ Apache access log ip address and moodle stored ip addresses do not match.

This issue has been marked as being related by:

MDL-17754 Session improvements and related rewrites

Database:	MySQL
Participants:	Dave Habben, Eloy Lafuente (stronk7), Petr Skoda and Tim Hunt
Security Level:	None
Resolved date:	10/Jan/09
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

When accessing the web server using an IPv6 address, the "Live Logs" feature no longer displays a correct address. Instead it displays the text "Click here ...".

With IPv4 the live logs display:
Time IP Address Full name Action Information
Mon March 31 2008, 01:09 PM 192.168.1.1 John Doe course view CIS252: Advanced Routing
the IP Address link also includes a link to:
http://moodle.svcc.edu/iplookup/index.php?ip=192.168.1.1&user=2

With IPv6 the live logs display:
Time IP Address Full name Action Information
Mon March 31 2008, 02:12 PM Click here ... John Doe course view CIS252: Advanced Routing
the IP Address link does not contain the IPv6 address and only includes:
http://moodle.svcc.edu/iplookup/index.php?ip=&user=2

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 6 files to 'Moodle CVS' - 07/Jan/09 03:14 AM

~~MDL-14123~~ Full IPv6 support - updating all db fields to theoretical 45 char limit

MODIFY	mod/chat/db/upgrade.php	Rev. 1.9	(+14 -1 lines)
MODIFY	mod/chat/db/install.xml	Rev. 1.5	(+1 -1 lines)
MODIFY	lib/db/upgrade.php	Rev. 1.260	(+93 -31 lines)
MODIFY	version.php	Rev. 1.948	(+1 -1 lines)
MODIFY	lib/db/install.xml	Rev. 1.183	(+12 -10 lines)
MODIFY	mod/chat/version.php	Rev. 1.32	(+2 -2 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 07/Jan/09 07:18 AM

~~MDL-14123~~ Full IPv6 support - reimplemented cleanremoteaddr(), it now accepts local ips too

MODIFY

lib/moodlelib.php

Rev. 1.1145

(+77 -44 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 09/Jan/09 07:16 PM

~~MDL-14123~~ cleanremoteaddr improvements and added unit tests

MODIFY	lib/moodlelib.php		Rev. 1.1148		(+22 -3 lines)
MODIFY	lib/simpletest/testmoodlelib.php		Rev. 1.16		(+21 -2 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 10/Jan/09 06:16 AM

~~MDL-14123~~ Full IPv6 support - reimplemented address_in_subnet() + added more unittests

MODIFY	lib/simpletest/testmoodlelib.php		Rev. 1.17		(+87 -32 lines)
MODIFY	lib/moodlelib.php		Rev. 1.1149		(+195 -28 lines)

Petr Skoda committed 3 files to 'Moodle CVS' - 10/Jan/09 06:41 AM

~~MDL-14123~~ Full IPv6 support - replaced mnet ip_in_range() by standard ipv6 compatible address_in_subnet(); replaced $_SERVER['REMOTE_ADDR'] with standard getremoteaddr()

MODIFY	mnet/remote_client.php	Rev. 1.8	(+2 -6 lines)
MODIFY	admin/mnet/trustedhosts.php	Rev. 1.10	(+2 -6 lines)
MODIFY	mnet/lib.php	Rev. 1.32	(+1 -22 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.