Issue Details (XML | Word | Printable)

Key: MDL-14128
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Dongsheng Cai
Reporter: Dongsheng Cai
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14085

Move all current uses of error(get_string('xxxx')) to a proper use of print_error() 1.9 and HEAD

Created: 01/Apr/08 11:55 AM   Updated: 20/Apr/08 06:42 AM
Return to search
Component/s: General
Affects Version/s: 1.9
Fix Version/s: 1.9.1

Participants: Dongsheng Cai, Eloy Lafuente (stronk7), Martin Dougiamas and Petr Skoda
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 15/Apr/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 07/Apr/08 08:43 AM
Hi Cai, two comments about the tracker:

1) We use to put only one release for each branch both in the "affects versions" and "fix versions". So I guess the correct ones for this should be:

affects versions: 1.9, 2.0 (HEAD)
fix versions: 1.9.1, 2.0 (HEAD)

But, generally, for something fixed in a branch (1.9) we don't use to include HEAD (2.0). It's supposed that we always merge changes there, so finally I'd leave this as:

affects versions: 1.9
fix versions: 1.9.1

And will use the 2.0 for things coming exclusively in 2.0.

Just an explanation. Ciao

P.S.: Of course, once you have resolved one bug you should mark it as resolved (fixed) to allow it to be reviewed on weekly reviews.


Dongsheng Cai added a comment - 07/Apr/08 11:30 AM
Thanks Eloy

Petr Skoda added a comment - 07/Apr/08 07:57 PM - edited
regressions - please fix before end of Teasday review:
1/
  • error(get_string("invalidpubkey", 'mnet') . $errmsg ,'peers.php?step=update&hostid='.$mnet_peer->id);
    + //error(get_string("invalidpubkey", 'mnet') . $errmsg ,'peers.php?step=update&hostid='.$mnet_peer->id);
    + print_error("invalidpubkey", 'mnet', 'peers.php?step=update&hostid='.$mnet_peer->id, $errmsg);

2/

  • error(get_string('noguestpost', 'forum').
  • ' You are not allowed to make modifications to this RSS feed at this time.',
  • $referrer);

+ //print_error(get_string('noguestpost', 'forum').
+ // ' You are not allowed to make modifications to this RSS feed at this time.',
+ // $referrer);
+ print_error('noguestpost', 'forum', $referrer, 'You are not allowed to make modifications to this RSS feed at this time.');

}

3/

  • error(get_string('noguestpost', 'forum').
  • ' You are not allowed to make modifications to this RSS feed at this time.',
  • $referrer);

+ //print_error(get_string('noguestpost', 'forum').
+ // ' You are not allowed to make modifications to this RSS feed at this time.',
+ // $referrer);
+ print_error('noguestpost', 'forum', $referrer, 'You are not allowed to make modifications to this RSS feed at this time.');

4/

  • error(get_string('missingfield', 'error', $name). " ".
  • get_string('erroronline', 'error', $linenum) .". ".
  • get_string('processingstops', 'error'),
  • 'uploaduser.php?sesskey='.$USER->sesskey);

+ //error(get_string('missingfield', 'error', $name). " ".
+ // get_string('erroronline', 'error', $linenum) .". ".
+ // get_string('processingstops', 'error'),
+ // 'uploaduser.php?sesskey='.$USER->sesskey);
+ print_error('missingfield', 'error', 'uploaduser.php?sesskey='.$USER->sesskey, $name);


Martin Dougiamas added a comment - 08/Apr/08 11:16 AM - edited
1) Ah, I see the append now (looked like a comma). OK, yes revert

2 and 3) Needs a whole new string yes (in lang/en_utf8/forum.php)

4) yeah this is wierd, should be reverted


Dongsheng Cai added a comment - 15/Apr/08 10:20 AM

Eloy Lafuente (stronk7) added a comment - 16/Apr/08 07:00 AM
Revert confirmed. Closing.