Issue Details (XML | Word | Printable)

Key: MDL-14133
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Tim Hunt
Reporter: David Scotson
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

navigation breadcrumb trail uses .first class for every item, not just the first

Created: 01/Apr/08 06:34 PM   Updated: 09/Jun/09 01:53 PM
Return to search
Component/s: Themes
Affects Version/s: 1.9
Fix Version/s: 1.9.5

Database: Any
Participants: David Scotson, Martin Dougiamas, Sam Hemelryk and Tim Hunt
Security Level: None
QA Assignee: Sam Hemelryk
Resolved date: 03/Feb/09
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
The code in weblib.php, the print_navigation function around lines 3504 - 3522 for old code and the build_navigation function line 3676 - attaches the class of "first" to all of the list items in the breadcrumb trail. I'm guessing that it's a mistake as it doesn't really make any sense.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
tjhunt committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 03/Feb/09 06:32 PM
theme / navbar: MDL-14133 every link in the nav bar was getting class="first"!
MODIFY lib/weblib.php   Rev. 1.970.2.130    (+4 -4 lines)
tjhunt committed 1 file to 'Moodle CVS' - 03/Feb/09 06:32 PM
theme / navbar: MDL-14133 every link in the nav bar was getting class="first"!
MODIFY lib/weblib.php   Rev. 1.1209    (+4 -4 lines)
Sam Hemelryk committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 09/Jun/09 02:29 PM
breadcrumb MDL-14133 One function missed during fix, got it this time
MODIFY lib/weblib.php   Rev. 1.970.2.139    (+7 -3 lines)
Sam Hemelryk committed 1 file to 'Moodle CVS' - 09/Jun/09 02:31 PM
breadcrumb MDL-14133 One function missed during fix, got it this time
MODIFY lib/weblib.php   Rev. 1.1261    (+5 -1 lines)