Issue Details (XML | Word | Printable)

Key: MDL-14152
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Koen Roggemans
Reporter: Petr Skoda
Votes: 0
Watchers: 10
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

detect and fix all syntax $a-> and other problems in all language packs and make sure it never happens again

Created: 03/Apr/08 02:32 AM   Updated: 14/Oct/09 03:30 AM
Return to search
Component/s: Languages
Affects Version/s: 1.9
Fix Version/s: 1.9.1

File Attachments: 1. File lang_fix.php (5 kB)

Issue Links:
Cloners
 

Participants: Eloy Lafuente (stronk7), Koen Roggemans, Martin Dougiamas and Petr Skoda
Security Level: None
QA Assignee: Koen Roggemans
Resolved date: 06/May/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE

Sub-Tasks  All   Open   
 Sub-Task Progress: 
No sub-tasks match this view.

 Description  « Hide
some translators insert spaces after $a-> something
some translators translate $a->
some translators make syntax errors

1/ make script that detects these problems
2/ fix everything in cvs
3/ fix lang edit UI to prevent these problems


These problems often lead to famous blank screens if php 5.2 used because it throws fatal exception because object can not be cast to string anymore.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda added a comment - 03/Apr/08 06:52 AM - edited
packs not fixed:
ta, ta_lk, mi_wwow, to

maintainers will have to do that

we should disable these on moodle.org and inform ppl


Petr Skoda added a comment - 03/Apr/08 06:53 AM
adding some more watchers

Petr Skoda added a comment - 03/Apr/08 08:02 AM - edited
sending new version with trailing/leading whitespace detection - fixed some of the lang files but several are really weird, needs more work tomorrow...

Eloy Lafuente (stronk7) added a comment - 03/Apr/08 10:08 AM
Adding one patch in order to check UTF-8 correctness of strings.

Ciao

P.S.: I think we should provide this info:

  • In the lang editor, perhaps preventing changes
  • In a wiki page, updated weekly or so, for manual editors.

Petr Skoda added a comment - 03/Apr/08 02:56 PM - edited
sending latest cvs/lang patch - whitespace fixed too

Petr Skoda added a comment - 03/Apr/08 03:21 PM
sending latest script with integrated encoding verification by Eloy, thanks

Petr Skoda added a comment - 03/Apr/08 04:33 PM
Assigning to Koen,

we need to notify maintainers of following lang packs: ta, ta_lk, mi_wwow, to
and inform them that there are problems in those language packs, the attached script should help them to identify the problems.

Also we should disable those languages on moodle.org until they are fixed, I guess we need a new policy that broken langs will be disabled on moodle.org until they get fixed to prevent problems like broken cron, blank screens, broken file serving

Please notify me when they know it - we do not want any political/personal problems on moodle.org


Koen Roggemans added a comment - 04/Apr/08 07:06 AM
notified translators

Koen Roggemans added a comment - 23/Apr/08 05:02 AM
ta: fixed
ta_lk: fixed
to: no response at all
mi_wwow: pending

Koen Roggemans added a comment - 23/Apr/08 05:24 AM
to: email address of translator doesn't exist - user unknown. That explains why they don't respond. I'll do it myself

Koen Roggemans added a comment - 05/May/08 06:11 PM
Found a good guy to fix tongan ...
I keep on emailing translators with problems - each time I check, there is something. Looking forward to a succesfull end of the google summer of code

Petr Skoda added a comment - 06/May/08 09:53 PM
all fixed

Eloy Lafuente (stronk7) added a comment - 07/May/08 07:17 AM
Petr, Koen. Could some of you become QA for this bug, verify everything is fine and finally close it? You are really in touch with all the things to check. TIA!

Koen Roggemans added a comment - 07/May/08 03:29 PM
Petr, thanks for fixing. I'll stop Troy, who's working on a fix for Tongan

Eloy, this we can close the bug, but this is an ongoing thing. Almost every time I update my /lang folder, there are problems. I choose the slow approach by notifying the translators about the errors, explaining what is wrong and how to avoid it.

At this very moment, everything is clean again, so I'll close the bug. I'll keep on looking at it. Need to do that anyway for all new files that are send by email to me.


Koen Roggemans added a comment - 07/May/08 03:31 PM
This needs ongoing following up, which I will do each time I check in new language files

Martin Dougiamas added a comment - 07/May/08 03:45 PM
Can we set up some sort of daily check using the new script which could email a report to Koen when bugs are found?

Eloy Lafuente (stronk7) added a comment - 08/May/08 01:53 AM
Yup, just send me the script and I'll install it wherever you want (download, cvs...) together with the deleted strings one I've running in my servers.

If you can add a MDLSITE bug for this... that would be peeerfect! Ciao