Issue Details (XML | Word | Printable)

Key: MDL-14152
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Koen Roggemans
Reporter: Petr Skoda
Votes: 0
Watchers: 10
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

detect and fix all syntax $a-> and other problems in all language packs and make sure it never happens again

Created: 03/Apr/08 02:32 AM   Updated: 14/Oct/09 03:30 AM
Return to search
Component/s: Languages
Affects Version/s: 1.9
Fix Version/s: 1.9.1

File Attachments: 1. File lang_fix.php (5 kB)
Issue Links:
Cloners
 

Participants: Eloy Lafuente (stronk7), Koen Roggemans, Martin Dougiamas and Petr Skoda
Security Level: None
QA Assignee: Koen Roggemans
Resolved date: 06/May/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE

Sub-Tasks:   All   Open   
 Sub-Task Progress: 
No sub-tasks match this view.

 Description  « Hide
some translators insert spaces after $a-> something
some translators translate $a->
some translators make syntax errors

1/ make script that detects these problems
2/ fix everything in cvs
3/ fix lang edit UI to prevent these problems


These problems often lead to famous blank screens if php 5.2 used because it throws fatal exception because object can not be cast to string anymore.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda made changes - 03/Apr/08 06:50 AM
Field Original Value New Value
Attachment langx.patch [ 13518 ]
Petr Skoda made changes - 03/Apr/08 06:50 AM
Attachment lang_fix.php [ 13519 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 03/Apr/08 06:52 AM - edited
packs not fixed:
ta, ta_lk, mi_wwow, to

maintainers will have to do that

we should disable these on moodle.org and inform ppl


[ Permalink | « Hide ]
Petr Skoda added a comment - 03/Apr/08 06:53 AM
adding some more watchers

Petr Skoda made changes - 03/Apr/08 06:56 AM
Description some translators insert spaces after $a-> something
some translators translate $a->
some translators make syntax errors

1/ make script that detects these problems
2/ fix everything in cvs
3/ fix lang edit UI to prevent these problems 		some translators insert spaces after $a-> something
some translators translate $a->
some translators make syntax errors

1/ make script that detects these problems
2/ fix everything in cvs
3/ fix lang edit UI to prevent these problems


These problems often lead to famous blank screens if php 5.2 used because it throws fatal exception because object can not be cast to string anymore.
Petr Skoda made changes - 03/Apr/08 08:00 AM
Attachment lang_fix.php [ 13519 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 03/Apr/08 08:02 AM - edited
sending new version with trailing/leading whitespace detection - fixed some of the lang files but several are really weird, needs more work tomorrow...

Petr Skoda made changes - 03/Apr/08 08:02 AM
Attachment lang_fix.php [ 13521 ]
[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 03/Apr/08 10:08 AM
Adding one patch in order to check UTF-8 correctness of strings.

Ciao

P.S.: I think we should provide this info:

  • In the lang editor, perhaps preventing changes
  • In a wiki page, updated weekly or so, for manual editors.

Eloy Lafuente (stronk7) made changes - 03/Apr/08 10:08 AM
Attachment lang_fix_utf8.patch [ 13522 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 03/Apr/08 02:56 PM - edited
sending latest cvs/lang patch - whitespace fixed too

Petr Skoda made changes - 03/Apr/08 02:56 PM
Attachment langx2.patch [ 13523 ]
Petr Skoda made changes - 03/Apr/08 02:56 PM
Attachment langx.patch [ 13518 ]
Petr Skoda committed 256 files to 'Lang CVS' - 03/Apr/08 03:19 PM
MDL-14152 fixed many syntax, logic, whitespace and encoding problems in majority of lang packs, it needs review by maintainers ;-)
MODIFY pl_utf8/moodle.php   Rev. 1.6    (+3 -3 lines)
MODIFY ga_utf8/multilang.php   Rev. 1.2    (+2 -3 lines)
MODIFY si_utf8/forum.php   Rev. 1.8    (+2 -2 lines)
MODIFY vi_utf8/multilang.php   Rev. 1.2    (+2 -3 lines)
MODIFY hu_utf8/lesson.php   Rev. 1.9    (+2 -2 lines)
MODIFY lo_utf8/moodle.php   Rev. 1.2    (+6 -6 lines)
MODIFY es_utf8/question.php   Rev. 1.5    (+2 -2 lines)
MODIFY sk_utf8/moodle.php   Rev. 1.23    (+2 -2 lines)
MODIFY hy_utf8/journal.php   Rev. 1.2    (+2 -2 lines)
MODIFY da_utf8/quiz.php   Rev. 1.14    (+1 -1 lines)
MODIFY mn_utf8/simpletest.php   Rev. 1.3    (+2 -3 lines)
MODIFY tl_utf8/lesson.php   Rev. 1.12    (+1 -1 lines)
MODIFY pl_utf8/assignment.php   Rev. 1.9    (+2 -2 lines)
MODIFY mn_utf8/quiz_analysis.php   Rev. 1.4    (+2 -3 lines)
MODIFY es_utf8/lesson.php   Rev. 1.9    (+3 -3 lines)
MODIFY no_utf8/error.php   Rev. 1.4    (+1 -1 lines)
MODIFY so_utf8/assignment.php   Rev. 1.2    (+4 -4 lines)
MODIFY it_utf8/question.php   Rev. 1.4    (+2 -2 lines)
MODIFY lt_utf8/quiz_responses.php   Rev. 1.2    (+1 -1 lines)
MODIFY th_utf8/lesson.php   Rev. 1.4    (+2 -2 lines)
MODIFY da_utf8/lesson.php   Rev. 1.16    (+1 -1 lines)
MODIFY zh_cn_utf8/enrol_authorize.php   Rev. 1.8    (+2 -2 lines)
MODIFY cs_utf8/quiz.php   Rev. 1.12    (+0 -1 lines)
MODIFY sr_lt_utf8/notes.php   Rev. 1.4    (+2 -2 lines)
MODIFY es_utf8/quiz.php   Rev. 1.24    (+1 -1 lines)
MODIFY it_utf8/lesson.php   Rev. 1.11    (+1 -1 lines)
MODIFY mn_utf8/xmldb.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/appointment.php   Rev. 1.3    (+2 -3 lines)
MODIFY ka_utf8/journal.php   Rev. 1.2    (+3 -3 lines)
MODIFY mn_utf8/grades.php   Rev. 1.3    (+2 -3 lines)
MODIFY nl_utf8/role.php   Rev. 1.29    (+3 -3 lines)
MODIFY mk_utf8/enrol_authorize.php   Rev. 1.2    (+2 -2 lines)
MODIFY zh_tw_utf8/moodle.php   Rev. 1.6    (+2 -2 lines)
MODIFY sk_utf8/qtype_multianswer.php   Rev. 1.2    (+1 -1 lines)
MODIFY uk_utf8/quiz.php   Rev. 1.2    (+1 -2 lines)
MODIFY zh_cn_utf8/lesson.php   Rev. 1.10    (+1 -1 lines)
MODIFY hi_utf8/moodle.php   Rev. 1.4    (+1 -1 lines)
MODIFY mn_utf8/block_search_forums.php   Rev. 1.3    (+2 -3 lines)
MODIFY ca_utf8/error.php   Rev. 1.20    (+1 -1 lines)
MODIFY mk_utf8/tex.php   Rev. 1.2    (+2 -3 lines)
MODIFY hi_utf8/multilang.php   Rev. 1.2    (+2 -3 lines)
MODIFY mn_utf8/access.php   Rev. 1.3    (+2 -3 lines)
MODIFY vi_utf8/forum.php   Rev. 1.4    (+1 -1 lines)
MODIFY mn_utf8/exercise.php   Rev. 1.3    (+2 -3 lines)
MODIFY sr_cr_utf8/moodle.php   Rev. 1.21    (+2 -4 lines)
MODIFY uk_utf8/journal.php   Rev. 1.2    (+3 -3 lines)
MODIFY eu_utf8/lesson.php   Rev. 1.15    (+3 -3 lines)
MODIFY pt_utf8/role.php   Rev. 1.19    (+2 -2 lines)
MODIFY sr_cr_utf8/choice.php   Rev. 1.13    (+2 -2 lines)
MODIFY et_utf8/moodle.php   Rev. 1.14    (+1 -1 lines)
MODIFY mn_utf8/block_loancalc.php   Rev. 1.3    (+2 -3 lines)
MODIFY vi_utf8/tex.php   Rev. 1.2    (+2 -3 lines)
MODIFY ga_utf8/emailprotect.php   Rev. 1.2    (+2 -3 lines)
MODIFY mn_utf8/censor.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/activitynames.php   Rev. 1.3    (+2 -3 lines)
MODIFY sm_utf8/tex.php   Rev. 1.2    (+2 -3 lines)
MODIFY so_utf8/moodle.php   Rev. 1.2    (+9 -9 lines)
MODIFY mn_utf8/editor.php   Rev. 1.3    (+2 -3 lines)
MODIFY de_utf8/xmldb.php   Rev. 1.8    (+2 -2 lines)
MODIFY mk_utf8/lesson.php   Rev. 1.2    (+2 -2 lines)
MODIFY mn_utf8/label.php   Rev. 1.3    (+2 -3 lines)
MODIFY uk_utf8/assignment.php   Rev. 1.2    (+3 -3 lines)
MODIFY bs_utf8/lesson.php   Rev. 1.2    (+2 -2 lines)
MODIFY mn_utf8/journal.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/block_online_users.php   Rev. 1.3    (+2 -3 lines)
MODIFY vi_utf8/algebra.php   Rev. 1.2    (+2 -3 lines)
MODIFY mn_utf8/survey.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/install.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/pix.php   Rev. 1.3    (+2 -3 lines)
MODIFY he_utf8/data.php   Rev. 1.5    (+2 -2 lines)
MODIFY fi_utf8/role.php   Rev. 1.9    (+2 -2 lines)
MODIFY lt_utf8/enrol_paypal.php   Rev. 1.2    (+1 -1 lines)
MODIFY eu_utf8/data.php   Rev. 1.24    (+2 -2 lines)
MODIFY sq_utf8/algebra.php   Rev. 1.2    (+1 -2 lines)
MODIFY mn_utf8/block_social_activities.php   Rev. 1.3    (+2 -3 lines)
MODIFY si_utf8/langconfig.php   Rev. 1.9    (+1 -2 lines)
MODIFY lt_utf8/forum.php   Rev. 1.3    (+4 -4 lines)
MODIFY mn_utf8/mimetypes.php   Rev. 1.3    (+1 -2 lines)
MODIFY gl_utf8/moodle.php   Rev. 1.4    (+14 -14 lines)
MODIFY hi_utf8/emailprotect.php   Rev. 1.2    (+2 -3 lines)
MODIFY mn_utf8/my.php   Rev. 1.3    (+2 -3 lines)
MODIFY sr_lt_utf8/lesson.php   Rev. 1.15    (+2 -2 lines)
MODIFY gu_utf8/moodle.php   Rev. 1.2    (+2 -2 lines)
MODIFY be_utf8/moodle.php   Rev. 1.2    (+99 -245 lines)
MODIFY mn_utf8/wiki.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/enrol_database.php   Rev. 1.3    (+2 -3 lines)
MODIFY zh_tw_utf8/enrol_authorize.php   Rev. 1.5    (+2 -2 lines)
MODIFY ro_utf8/survey.php   Rev. 1.2    (+2 -3 lines)
MODIFY mn_utf8/quiz_responses.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/block_course_summary.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/blog.php   Rev. 1.4    (+2 -3 lines)
MODIFY uk_utf8/moodle.php   Rev. 1.2    (+8 -8 lines)
MODIFY mn_utf8/quiz.php   Rev. 1.3    (+2 -3 lines)
MODIFY vi_utf8/activitynames.php   Rev. 1.2    (+2 -3 lines)
MODIFY sv_utf8/moodle.php   Rev. 1.6    (+1 -2 lines)
MODIFY fr_utf8/lesson.php   Rev. 1.33    (+2 -2 lines)
MODIFY mn_utf8/chat.php   Rev. 1.3    (+2 -3 lines)
MODIFY sm_utf8/journal.php   Rev. 1.2    (+3 -3 lines)
MODIFY no_utf8/moodle.php   Rev. 1.11    (+2 -2 lines)
MODIFY hi_utf8/tex.php   Rev. 1.2    (+2 -3 lines)
MODIFY si_utf8/quiz.php   Rev. 1.6    (+6 -6 lines)
MODIFY mi_tn_utf8/moodle.php   Rev. 1.2    (+4 -4 lines)
MODIFY mn_utf8/hotpot.php   Rev. 1.3    (+2 -3 lines)
MODIFY mk_utf8/multilang.php   Rev. 1.2    (+2 -3 lines)
MODIFY id_utf8/quiz.php   Rev. 1.2    (+2 -2 lines)
MODIFY eu_utf8/moodle.php   Rev. 1.22    (+1 -1 lines)
MODIFY vi_utf8/emailprotect.php   Rev. 1.2    (+2 -3 lines)
MODIFY sr_cr_utf8/tex.php   Rev. 1.8    (+2 -3 lines)
MODIFY he_utf8/block_rss_client.php   Rev. 1.4    (+2 -2 lines)
MODIFY mn_utf8/attendance.php   Rev. 1.3    (+2 -3 lines)
MODIFY si_utf8/moodle.php   Rev. 1.20    (+2 -2 lines)
MODIFY mn_utf8/qtype_multichoice.php   Rev. 1.2    (+2 -2 lines)
MODIFY mk_utf8/emailprotect.php   Rev. 1.2    (+2 -3 lines)
MODIFY ko_utf8/data.php   Rev. 1.16    (+2 -2 lines)
MODIFY sk_utf8/lesson.php   Rev. 1.4    (+1 -1 lines)
MODIFY hr_utf8/calendar.php   Rev. 1.2    (+2 -3 lines)
MODIFY da_utf8/workshop.php   Rev. 1.5    (+1 -2 lines)
MODIFY mn_utf8/countries.php   Rev. 1.3    (+2 -3 lines)
MODIFY he_utf8/search.php   Rev. 1.3    (+2 -2 lines)
MODIFY mn_utf8/admin.php   Rev. 1.2    (+2 -2 lines)
MODIFY no_gr_utf8/moodle.php   Rev. 1.2    (+1 -2 lines)
MODIFY mn_utf8/error.php   Rev. 1.3    (+2 -3 lines)
MODIFY vi_utf8/lesson.php   Rev. 1.2    (+2 -2 lines)
MODIFY ru_utf8/moodle.php   Rev. 1.17    (+1 -1 lines)
MODIFY el_utf8/moodle.php   Rev. 1.6    (+1 -2 lines)
MODIFY pt_utf8/forum.php   Rev. 1.17    (+3 -3 lines)
MODIFY fi_utf8/lesson.php   Rev. 1.9    (+3 -3 lines)
MODIFY lt_utf8/emailprotect.php   Rev. 1.3    (+1 -1 lines)
MODIFY mn_utf8/glossary.php   Rev. 1.3    (+2 -3 lines)
MODIFY be_utf8/workshop.php   Rev. 1.2    (+2 -3 lines)
MODIFY mn_utf8/enrol_manual.php   Rev. 1.3    (+2 -3 lines)
MODIFY pt_br_utf8/lesson.php   Rev. 1.7    (+3 -3 lines)
MODIFY th_utf8/moodle.php   Rev. 1.6    (+1 -1 lines)
MODIFY nn_utf8/moodle.php   Rev. 1.6    (+1 -2 lines)
MODIFY el_utf8/block_social_activities.php   Rev. 1.2    (+2 -3 lines)
MODIFY bs_utf8/wiki.php   Rev. 1.2    (+2 -2 lines)
MODIFY no_utf8/lesson.php   Rev. 1.6    (+1 -1 lines)
MODIFY mn_utf8/multilang.php   Rev. 1.3    (+2 -4 lines)
MODIFY he_utf8/enrol_authorize.php   Rev. 1.3    (+3 -3 lines)
MODIFY mn_utf8/quiz_regrade.php   Rev. 1.3    (+2 -3 lines)
MODIFY he_utf8/admin.php   Rev. 1.15    (+1 -1 lines)
MODIFY ca_utf8/lesson.php   Rev. 1.12    (+2 -2 lines)
MODIFY mn_utf8/algebra.php   Rev. 1.3    (+2 -3 lines)
MODIFY sl_utf8/moodle.php   Rev. 1.4    (+1 -1 lines)
MODIFY mn_utf8/emailprotect.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/block_html.php   Rev. 1.3    (+2 -3 lines)
MODIFY fil_utf8/moodle.php   Rev. 1.2    (+2 -2 lines)
MODIFY mn_utf8/workshop.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/quiz_overview.php   Rev. 1.3    (+2 -3 lines)
MODIFY eu_utf8/quiz.php   Rev. 1.16    (+1 -1 lines)
MODIFY de_utf8/data.php   Rev. 1.18    (+1 -1 lines)
MODIFY nl_utf8/moodle.php   Rev. 1.57    (+3 -3 lines)
MODIFY mn_utf8/enrol_flatfile.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/choice.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/currencies.php   Rev. 1.3    (+2 -3 lines)
MODIFY el_utf8/quiz.php   Rev. 1.5    (+1 -1 lines)
MODIFY sq_utf8/mediaplugin.php   Rev. 1.2    (+2 -2 lines)
MODIFY mn_utf8/block_course_list.php   Rev. 1.3    (+2 -3 lines)
MODIFY nl_utf8/data.php   Rev. 1.23    (+2 -2 lines)
MODIFY sr_cr_bo_utf8/choice.php   Rev. 1.2    (+2 -5 lines)
MODIFY is_utf8/moodle.php   Rev. 1.8    (+2 -2 lines)
MODIFY zh_cn_utf8/moodle.php   Rev. 1.34    (+2 -2 lines)
MODIFY he_utf8/question.php   Rev. 1.7    (+4 -4 lines)
MODIFY vi_utf8/mediaplugin.php   Rev. 1.2    (+2 -3 lines)
MODIFY mn_utf8/mediaplugin.php   Rev. 1.3    (+2 -3 lines)
MODIFY sk_utf8/quiz.php   Rev. 1.13    (+1 -1 lines)
MODIFY ga_utf8/tex.php   Rev. 1.2    (+2 -3 lines)
MODIFY km_utf8/mnet.php   Rev. 1.3    (+1 -1 lines)
MODIFY mn_utf8/tex.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/lams.php   Rev. 1.3    (+2 -3 lines)
MODIFY la_utf8/moodle.php   Rev. 1.2    (+2 -2 lines)
MODIFY et_utf8/lesson.php   Rev. 1.7    (+1 -1 lines)
MODIFY gl_utf8/enrol_authorize.php   Rev. 1.3    (+4 -4 lines)
MODIFY et_utf8/error.php   Rev. 1.10    (+1 -1 lines)
MODIFY is_utf8/multilang.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/enrol_paypal.php   Rev. 1.3    (+2 -3 lines)
MODIFY nl_utf8/lesson.php   Rev. 1.14    (+2 -2 lines)
MODIFY ro_utf8/resource.php   Rev. 1.2    (+1 -1 lines)
MODIFY mn_utf8/block_quiz_results.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/message.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/enrol_authorize.php   Rev. 1.3    (+5 -6 lines)
MODIFY sm_utf8/assignment.php   Rev. 1.2    (+3 -3 lines)
MODIFY sm_utf8/censor.php   Rev. 1.2    (+2 -3 lines)
MODIFY sr_cr_utf8/notes.php   Rev. 1.4    (+2 -2 lines)
MODIFY mn_utf8/Attic/questionnaire.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/block_rss_client.php   Rev. 1.3    (+2 -3 lines)
MODIFY ca_utf8/quiz.php   Rev. 1.19    (+3 -3 lines)
MODIFY vi_utf8/censor.php   Rev. 1.2    (+2 -3 lines)
MODIFY cs_utf8/moodle.php   Rev. 1.29    (+1 -1 lines)
MODIFY no_utf8/bulkusers.php   Rev. 1.2    (+2 -2 lines)
MODIFY fr_ca_utf8/moodle.php   Rev. 1.2    (+2 -2 lines)
MODIFY sr_cr_bo_utf8/tex.php   Rev. 1.2    (+2 -3 lines)
MODIFY sm_utf8/mediaplugin.php   Rev. 1.2    (+2 -3 lines)
MODIFY sv_utf8/enrol_authorize.php   Rev. 1.4    (+1 -1 lines)
MODIFY sr_cr_bo_utf8/assignment.php   Rev. 1.2    (+3 -3 lines)
MODIFY mn_utf8/langconfig.php   Rev. 1.3    (+1 -1 lines)
MODIFY lt_utf8/countries.php   Rev. 1.2    (+1 -1 lines)
MODIFY da_utf8/moodle.php   Rev. 1.22    (+1 -1 lines)
MODIFY ar_utf8/data.php   Rev. 1.4    (+2 -2 lines)
MODIFY mn_utf8/quiz_grading.php   Rev. 1.3    (+2 -3 lines)
MODIFY ar_utf8/moodle.php   Rev. 1.5    (+9 -9 lines)
MODIFY ka_utf8/lesson.php   Rev. 1.2    (+2 -2 lines)
MODIFY sm_utf8/algebra.php   Rev. 1.2    (+2 -3 lines)
MODIFY he_utf8/tag.php   Rev. 1.2    (+2 -2 lines)
MODIFY it_utf8/admin.php   Rev. 1.30    (+1 -1 lines)
MODIFY mn_utf8/assignment.php   Rev. 1.3    (+2 -3 lines)
MODIFY pt_utf8/enrol_authorize.php   Rev. 1.8    (+2 -2 lines)
MODIFY mn_utf8/block_glossary_random.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/enrol_imsenterprise.php   Rev. 1.3    (+2 -3 lines)
MODIFY ga_utf8/censor.php   Rev. 1.2    (+2 -3 lines)
MODIFY sm_utf8/moodle.php   Rev. 1.2    (+12 -12 lines)
MODIFY sr_cr_utf8/lesson.php   Rev. 1.15    (+2 -2 lines)
MODIFY hy_utf8/moodle.php   Rev. 1.2    (+7 -7 lines)
MODIFY si_utf8/grades.php   Rev. 1.13    (+2 -2 lines)
MODIFY de_utf8/moodle.php   Rev. 1.39    (+2 -4 lines)
MODIFY hr_utf8/moodle.php   Rev. 1.2    (+3 -4 lines)
MODIFY mn_utf8/form.php   Rev. 1.3    (+2 -3 lines)
MODIFY el_utf8/block_section_links.php   Rev. 1.2    (+2 -3 lines)
MODIFY fi_utf8/moodle.php   Rev. 1.27    (+2 -2 lines)
MODIFY ga_utf8/algebra.php   Rev. 1.2    (+2 -3 lines)
MODIFY bg_utf8/lesson.php   Rev. 1.2    (+1 -2 lines)
MODIFY mn_utf8/scorm.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/calendar.php   Rev. 1.4    (+2 -3 lines)
MODIFY ja_utf8/data.php   Rev. 1.84    (+2 -2 lines)
MODIFY fr_utf8/question.php   Rev. 1.13    (+2 -2 lines)
MODIFY is_utf8/tex.php   Rev. 1.3    (+2 -3 lines)
MODIFY zh_tw_utf8/lesson.php   Rev. 1.4    (+2 -2 lines)
MODIFY zh_tw_utf8/scorm.php   Rev. 1.4    (+2 -2 lines)
MODIFY mn_utf8/webquest.php   Rev. 1.3    (+2 -3 lines)
MODIFY sm_utf8/quiz.php   Rev. 1.2    (+3 -3 lines)
MODIFY mn_utf8/lesson.php   Rev. 1.3    (+2 -3 lines)
MODIFY si_utf8/lesson.php   Rev. 1.6    (+6 -6 lines)
MODIFY mn_utf8/moodle.php   Rev. 1.2    (+3 -3 lines)
MODIFY mn_utf8/resource.php   Rev. 1.3    (+2 -3 lines)
MODIFY sr_lt_utf8/moodle.php   Rev. 1.18    (+2 -4 lines)
MODIFY mn_utf8/dialogue.php   Rev. 1.3    (+2 -3 lines)
MODIFY pl_utf8/lesson.php   Rev. 1.5    (+1 -1 lines)
MODIFY bs_utf8/assignment.php   Rev. 1.2    (+2 -2 lines)
MODIFY mn_utf8/data.php   Rev. 1.3    (+3 -4 lines)
MODIFY mk_utf8/algebra.php   Rev. 1.2    (+2 -3 lines)
MODIFY hu_utf8/moodle.php   Rev. 1.11    (+1 -1 lines)
MODIFY mn_utf8/block_section_links.php   Rev. 1.3    (+2 -3 lines)
MODIFY mn_utf8/forum.php   Rev. 1.3    (+2 -3 lines)
MODIFY ar_utf8/error.php   Rev. 1.5    (+1 -1 lines)
MODIFY id_utf8/lesson.php   Rev. 1.3    (+1 -1 lines)
MODIFY uk_utf8/resource.php   Rev. 1.2    (+2 -3 lines)
MODIFY hy_utf8/lesson.php   Rev. 1.2    (+2 -2 lines)
MODIFY pt_utf8/lesson.php   Rev. 1.12    (+4 -4 lines)
MODIFY sv_utf8/lesson.php   Rev. 1.5    (+2 -2 lines)
MODIFY ro_utf8/forum.php   Rev. 1.2    (+2 -3 lines)
MODIFY mn_utf8/auth.php   Rev. 1.2    (+2 -2 lines)
MODIFY ca_utf8/moodle.php   Rev. 1.49    (+1 -1 lines)
MODIFY he_utf8/lesson.php   Rev. 1.7    (+1 -1 lines)
MODIFY eu_utf8/exercise.php   Rev. 1.4    (+1 -1 lines)
MODIFY he_utf8/grades.php   Rev. 1.5    (+2 -2 lines)
MODIFY mn_utf8/enrol_ldap.php   Rev. 1.3    (+2 -3 lines)
Petr Skoda made changes - 03/Apr/08 03:20 PM
Attachment lang_fix_utf8.patch [ 13522 ]
Petr Skoda made changes - 03/Apr/08 03:21 PM
Attachment lang_fix.php [ 13521 ]
Petr Skoda made changes - 03/Apr/08 03:21 PM
Attachment langx2.patch [ 13523 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 03/Apr/08 03:21 PM
sending latest script with integrated encoding verification by Eloy, thanks

Petr Skoda made changes - 03/Apr/08 03:21 PM
Attachment lang_fix.php [ 13524 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 03/Apr/08 04:33 PM
Assigning to Koen,

we need to notify maintainers of following lang packs: ta, ta_lk, mi_wwow, to
and inform them that there are problems in those language packs, the attached script should help them to identify the problems.

Also we should disable those languages on moodle.org until they are fixed, I guess we need a new policy that broken langs will be disabled on moodle.org until they get fixed to prevent problems like broken cron, blank screens, broken file serving

Please notify me when they know it - we do not want any political/personal problems on moodle.org


Petr Skoda made changes - 03/Apr/08 04:33 PM
Assignee Petr Skoda [ skodak ] Koen Roggemans [ koen ]
Petr Skoda committed 4 files to 'Lang CVS' - 04/Apr/08 06:19 AM
MDL-14152 refixed da pack again
MODIFY da_utf8/lesson.php   Rev. 1.18    (+1 -1 lines)
MODIFY da_utf8/quiz.php   Rev. 1.16    (+1 -1 lines)
MODIFY da_utf8/moodle.php   Rev. 1.24    (+1 -1 lines)
MODIFY da_utf8/workshop.php   Rev. 1.7    (+1 -2 lines)
Petr Skoda committed 7 files to 'Lang CVS' - 04/Apr/08 06:56 AM
MDL-14152 undone translation of $a-> placeholders
MODIFY mi_wwow_utf8/lesson.php   Rev. 1.3    (+4 -4 lines)
MODIFY mi_wwow_utf8/moodle.php   Rev. 1.3    (+15 -15 lines)
MODIFY mi_wwow_utf8/data.php   Rev. 1.3    (+3 -3 lines)
MODIFY mi_wwow_utf8/admin.php   Rev. 1.3    (+3 -3 lines)
MODIFY mi_wwow_utf8/wiki.php   Rev. 1.3    (+2 -2 lines)
MODIFY mi_wwow_utf8/enrol_authorize.php   Rev. 1.3    (+10 -10 lines)
MODIFY mi_wwow_utf8/install.php   Rev. 1.4    (+4 -4 lines)
[ Permalink | « Hide ]
Koen Roggemans added a comment - 04/Apr/08 07:06 AM
notified translators

[ Permalink | « Hide ]
Koen Roggemans added a comment - 23/Apr/08 05:02 AM
ta: fixed
ta_lk: fixed
to: no response at all
mi_wwow: pending

[ Permalink | « Hide ]
Koen Roggemans added a comment - 23/Apr/08 05:24 AM
to: email address of translator doesn't exist - user unknown. That explains why they don't respond. I'll do it myself

Martin Dougiamas made changes - 05/May/08 03:22 PM
Priority Blocker [ 1 ] Critical [ 2 ]
[ Permalink | « Hide ]
Koen Roggemans added a comment - 05/May/08 06:11 PM
Found a good guy to fix tongan ...
I keep on emailing translators with problems - each time I check, there is something. Looking forward to a succesfull end of the google summer of code

Petr Skoda committed 9 files to 'Lang CVS' - 06/May/08 09:52 PM
MDL-14152 syntax prolems in to lang pack
MODIFY to_utf8/assignment.php   Rev. 1.2    (+2 -2 lines)
MODIFY to_utf8/journal.php   Rev. 1.2    (+3 -3 lines)
MODIFY to_utf8/forum.php   Rev. 1.2    (+5 -5 lines)
MODIFY to_utf8/error.php   Rev. 1.2    (+2 -2 lines)
MODIFY to_utf8/wiki.php   Rev. 1.2    (+2 -2 lines)
MODIFY to_utf8/lesson.php   Rev. 1.2    (+8 -8 lines)
MODIFY to_utf8/quiz.php   Rev. 1.2    (+3 -3 lines)
MODIFY to_utf8/moodle.php   Rev. 1.2    (+41 -41 lines)
MODIFY to_utf8/scorm.php   Rev. 1.2    (+10 -10 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 06/May/08 09:53 PM
all fixed

Petr Skoda made changes - 06/May/08 09:53 PM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 07/May/08 07:17 AM
Petr, Koen. Could some of you become QA for this bug, verify everything is fine and finally close it? You are really in touch with all the things to check. TIA!

[ Permalink | « Hide ]
Koen Roggemans added a comment - 07/May/08 03:29 PM
Petr, thanks for fixing. I'll stop Troy, who's working on a fix for Tongan

Eloy, this we can close the bug, but this is an ongoing thing. Almost every time I update my /lang folder, there are problems. I choose the slow approach by notifying the translators about the errors, explaining what is wrong and how to avoid it.

At this very moment, everything is clean again, so I'll close the bug. I'll keep on looking at it. Need to do that anyway for all new files that are send by email to me.


[ Permalink | « Hide ]
Koen Roggemans added a comment - 07/May/08 03:31 PM
This needs ongoing following up, which I will do each time I check in new language files

Koen Roggemans made changes - 07/May/08 03:31 PM
QA Assignee koen
Status Resolved [ 5 ] Closed [ 6 ]
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 07/May/08 03:45 PM
Can we set up some sort of daily check using the new script which could email a report to Koen when bugs are found?

[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 08/May/08 01:53 AM
Yup, just send me the script and I'll install it wherever you want (download, cvs...) together with the deleted strings one I've running in my servers.

If you can add a MDLSITE bug for this... that would be peeerfect! Ciao


koenr committed 1 file to 'Lang CVS' - 16/Jun/08 02:57 AM
MDL-14152
MODIFY de_utf8/question.php   Rev. 1.19    (+2 -2 lines)
koenr committed 3 files to 'Lang CVS' - 16/Jun/08 03:13 AM
MDL-14152
MODIFY he_utf8/hotpot.php   Rev. 1.6    (+2 -2 lines)
MODIFY he_utf8/question.php   Rev. 1.9    (+2 -2 lines)
MODIFY he_utf8/mediaplugin.php   Rev. 1.5    (+2 -2 lines)
koenr committed 2 files to 'Lang CVS' - 16/Jun/08 03:19 AM
MDL-14152
MODIFY no_utf8/enrol_authorize.php   Rev. 1.4    (+14 -4 lines)
MODIFY no_utf8/question.php   Rev. 1.3    (+5 -2 lines)
koenr committed 1 file to 'Lang CVS' - 30/Jun/08 02:36 AM
MDL-14152
MODIFY ko_utf8/error.php   Rev. 1.46    (+2 -2 lines)
koenr committed 1 file to 'Lang CVS' - 07/Aug/08 05:11 PM
bug MDL-14152
MODIFY no_utf8/question.php   Rev. 1.5    (+2 -2 lines)
koenr committed 6 files to 'Lang CVS' - 07/Aug/08 05:42 PM
bug MDL-14152
MODIFY zh_tw_utf8/filters.php   Rev. 1.2    (+2 -2 lines)
MODIFY zh_tw_utf8/moodle.php   Rev. 1.8    (+4 -4 lines)
MODIFY zh_tw_utf8/scorm.php   Rev. 1.6    (+2 -2 lines)
MODIFY zh_tw_utf8/lesson.php   Rev. 1.6    (+4 -4 lines)
MODIFY zh_tw_utf8/feedback.php   Rev. 1.3    (+181 -179 lines)
MODIFY zh_tw_utf8/enrol_authorize.php   Rev. 1.7    (+2 -2 lines)
koenr committed 2 files to 'Lang CVS' - 07/Aug/08 05:53 PM
bug MDL-14152
MODIFY zh_tw_utf8/lesson.php   Rev. 1.7    (+1 -2 lines)
MODIFY zh_tw_utf8/feedback.php   Rev. 1.4    (+1 -8 lines)
koenr committed 1 file to 'Lang CVS' - 16/Aug/08 06:27 AM
MDL-14152
MODIFY sk_utf8/filters.php   Rev. 1.2    (+5 -3 lines)
koenr committed 1 file to 'Lang CVS' - 18/Aug/08 05:29 AM
MDL-14152
MODIFY hu_utf8/error.php   Rev. 1.12    (+2 -2 lines)
koenr committed 2 files to 'Lang CVS' - 03/Oct/08 05:03 AM
MDL-14152
MODIFY et_utf8/lesson.php   Rev. 1.9    (+301 -297 lines)
MODIFY de_utf8/quiz_statistics.php   Rev. 1.4    (+2 -2 lines)
koenr committed 1 file to 'Lang CVS' - 03/Oct/08 05:14 AM
MDL-14152
MODIFY fr_utf8/portfolio.php   Rev. 1.23    (+16 -14 lines)
koenr committed 2 files to 'Lang CVS' - 03/Oct/08 05:26 AM
MDL-14152
MODIFY hu_utf8/portfolio.php   Rev. 1.2    (+1 -3 lines)
MODIFY ko_utf8/portfolio.php   Rev. 1.16    (+1 -2 lines)
koenr committed 25 files to 'Lang CVS' - 19/Oct/08 04:47 AM
More problems like MDL-16914 and MDL-14152
MODIFY fi_utf8/role.php   Rev. 1.11    (+8 -5 lines)
MODIFY fi_utf8/gradeexport_xls.php   Rev. 1.3    (+4 -3 lines)
MODIFY fi_utf8/lesson.php   Rev. 1.11    (+8 -7 lines)
MODIFY fi_utf8/gradeimport_csv.php   Rev. 1.3    (+4 -3 lines)
MODIFY fi_utf8/auth.php   Rev. 1.11    (+4 -3 lines)
MODIFY fi_utf8/forum.php   Rev. 1.14    (+4 -3 lines)
MODIFY fi_utf8/scorm.php   Rev. 1.12    (+4 -3 lines)
MODIFY fi_utf8/survey.php   Rev. 1.9    (+4 -3 lines)
MODIFY fi_utf8/form.php   Rev. 1.5    (+5 -4 lines)
MODIFY fi_utf8/group.php   Rev. 1.3    (+4 -3 lines)
MODIFY fi_utf8/quiz.php   Rev. 1.11    (+20 -19 lines)
MODIFY fi_utf8/error.php   Rev. 1.11    (+5 -4 lines)
MODIFY fi_utf8/gradeexport_txt.php   Rev. 1.3    (+4 -3 lines)
MODIFY fi_utf8/admin.php   Rev. 1.23    (+4 -2 lines)
MODIFY fi_utf8/resource.php   Rev. 1.13    (+4 -3 lines)
MODIFY fi_utf8/gradereport_grader.php   Rev. 1.3    (+4 -3 lines)
MODIFY fi_utf8/grades.php   Rev. 1.10    (+5 -4 lines)
MODIFY fi_utf8/gradeexport_xml.php   Rev. 1.3    (+4 -3 lines)
MODIFY fi_utf8/notes.php   Rev. 1.3    (+4 -3 lines)
MODIFY fi_utf8/gradeexport_ods.php   Rev. 1.3    (+4 -3 lines)
MODIFY fi_utf8/gradeimport_xml.php   Rev. 1.3    (+4 -3 lines)
MODIFY fi_utf8/qtype_truefalse.php   Rev. 1.2    (+5 -2 lines)
MODIFY fi_utf8/qtype_multichoice.php   Rev. 1.8    (+5 -2 lines)
MODIFY fi_utf8/question.php   Rev. 1.4    (+3 -2 lines)
MODIFY fi_utf8/hotpot.php   Rev. 1.10    (+4 -3 lines)
koenr committed 2 files to 'Lang CVS' - 19/Oct/08 05:02 AM
MDL-14152
MODIFY et_utf8/lesson.php   Rev. 1.10    (+1 -1 lines)
MODIFY de_utf8/error.php   Rev. 1.38    (+3 -3 lines)
koenr committed 1 file to 'Lang CVS' - 19/Oct/08 05:20 AM
MDL-14152
MODIFY pl_utf8/moodle.php   Rev. 1.9    (+4 -4 lines)
koenr committed 1 file to 'Lang CVS' - 19/Oct/08 05:38 AM
MDL-14152
MODIFY et_utf8/lesson.php   Rev. 1.11    (+0 -1 lines)
koenr committed 3 files to 'Lang CVS' - 03/Jan/09 02:31 AM
new strings from Shamim Rezaie (rezaie9@gmail.com) and one MDL-14152
MODIFY fa_utf8/lesson.php   Rev. 1.2    (+0 -1 lines)
ADD fa_utf8/wiki.php   Rev. 1.1    (+0 -0 lines)
MODIFY fa_utf8/journal.php   Rev. 1.2    (+32 -31 lines)
koenr committed 1 file to 'Lang CVS' - 13/Jan/09 05:52 AM
MDL-14152 creativity in using strings not allowed in language pack ;-)
MODIFY de_utf8/moodle.php   Rev. 1.53    (+2 -2 lines)
koenr committed 1 file to 'Lang CVS' - 13/Jan/09 05:56 AM
MDL-14152
MODIFY ko_utf8/report_security.php   Rev. 1.6    (+2 -2 lines)
koenr committed 2 files to 'Lang CVS' - 27/Jan/09 07:59 AM
MDL-14152
MODIFY zh_tw_utf8/enrol_authorize.php   Rev. 1.9    (+2 -2 lines)
MODIFY eu_utf8/qtype_match.php   Rev. 1.5    (+2 -2 lines)
koenr committed 3 files to 'Lang CVS' - 27/Jan/09 08:07 AM
MDL-14152
MODIFY zh_tw_utf8/moodle.php   Rev. 1.10    (+6 -6 lines)
MODIFY zh_tw_utf8/filters.php   Rev. 1.4    (+2 -2 lines)
MODIFY zh_tw_utf8/scorm.php   Rev. 1.8    (+2 -2 lines)
Petr Skoda made changes - 14/Oct/09 03:30 AM
Link This issue is a clone of MDL-20554 [ MDL-20554 ]
koenr committed 6 files to 'Lang CVS' - 21/Oct/09 04:36 AM
MDL-14152
MODIFY uz_utf8/auth.php   Rev. 1.4    (+1 -4 lines)
MODIFY uz_utf8/wiki.php   Rev. 1.3    (+1 -2 lines)
MODIFY uz_utf8/lesson.php   Rev. 1.3    (+1 -3 lines)
MODIFY uz_utf8/data.php   Rev. 1.2    (+1 -3 lines)
MODIFY uz_utf8/tag.php   Rev. 1.2    (+1 -2 lines)
MODIFY uz_utf8/simpletest.php   Rev. 1.2    (+1 -3 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators