Moodle

Variable not used in the string 'displayleftif'

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.7.7
  • Component/s: Lesson
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_17_STABLE

Description

and only display if $a has grade greater than:
is shown as
and only display if has grade greater than:

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Bente Olsen added a comment -

forgot: see lesson.php

Show
Bente Olsen added a comment - forgot: see lesson.php
Hide
Permalink
Howard Miller added a comment -

I'm pretty sure that the %a should not be there as it is only used in the setup page.

Show
Howard Miller added a comment - I'm pretty sure that the %a should not be there as it is only used in the setup page.
Hide
Permalink
Howard Miller added a comment -

String changed in language pack to be more sensible.

Show
Howard Miller added a comment - String changed in language pack to be more sensible.
Hide
Permalink
Tim Hunt added a comment -

Should you be editing a language string like that? Remember that the same language packs are use for all Moodle versions >= 1.6. Normally, if you are changing a language string, you should be creating a new one, and leaving the old one alone. It also helps translators know what changed strings need be be re-translated, because they are not changed, they are new. (But I don't know the exact circumstances here.)

Show
Tim Hunt added a comment - Should you be editing a language string like that? Remember that the same language packs are use for all Moodle versions >= 1.6. Normally, if you are changing a language string, you should be creating a new one, and leaving the old one alone. It also helps translators know what changed strings need be be re-translated, because they are not changed, they are new. (But I don't know the exact circumstances here.)
Hide
Permalink
Howard Miller added a comment -

Ok... I'm not sure what the best thing to do is now. It looks like some translators have picked up on it. In any case the fix was very minor. Just dumping a replacement parameter that was unused.

Noted for future however.

Show
Howard Miller added a comment - Ok... I'm not sure what the best thing to do is now. It looks like some translators have picked up on it. In any case the fix was very minor. Just dumping a replacement parameter that was unused. Noted for future however.
Hide
Permalink
Tim Hunt added a comment -

I think it is OK to leave it for now in this case.

Show
Tim Hunt added a comment - I think it is OK to leave it for now in this case.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.