Issue Details (XML | Word | Printable)

Key: MDL-14155
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Howard Miller
Reporter: Bente Olsen
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Variable not used in the string 'displayleftif'

Created: 03/Apr/08 05:17 AM   Updated: 11/Dec/08 01:09 AM
Return to search
Component/s: Lesson
Affects Version/s: 1.9
Fix Version/s: 1.7.7

Participants: Bente Olsen, Howard Miller and Tim Hunt
Security Level: None
QA Assignee: Tim Hunt
Resolved date: 26/Nov/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_17_STABLE


 Description  « Hide
and only display if $a has grade greater than:
is shown as
and only display if has grade greater than:

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Bente Olsen added a comment - 03/Apr/08 05:19 AM
forgot: see lesson.php

Howard Miller added a comment - 26/Nov/08 08:48 PM
I'm pretty sure that the %a should not be there as it is only used in the setup page.

Howard Miller added a comment - 26/Nov/08 08:52 PM
String changed in language pack to be more sensible.

Tim Hunt added a comment - 09/Dec/08 03:10 PM
Should you be editing a language string like that? Remember that the same language packs are use for all Moodle versions >= 1.6. Normally, if you are changing a language string, you should be creating a new one, and leaving the old one alone. It also helps translators know what changed strings need be be re-translated, because they are not changed, they are new. (But I don't know the exact circumstances here.)

Howard Miller added a comment - 10/Dec/08 06:44 PM
Ok... I'm not sure what the best thing to do is now. It looks like some translators have picked up on it. In any case the fix was very minor. Just dumping a replacement parameter that was unused.

Noted for future however.


Tim Hunt added a comment - 11/Dec/08 01:09 AM
I think it is OK to leave it for now in this case.