[#MDL-14155] Variable not used in the string 'displayleftif'

Issue Details (XML | Word | Printable)

Key:	MDL-14155
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Trivial
Assignee:	Howard Miller
Reporter:	Bente Olsen
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Variable not used in the string 'displayleftif'

Created: 03/Apr/08 05:17 AM Updated: 11/Dec/08 01:09 AM

Return to search

Component/s:

Lesson

Affects Version/s:

1.9

Fix Version/s:

1.7.7

Participants:	Bente Olsen, Howard Miller and Tim Hunt
Security Level:	None
QA Assignee:	Tim Hunt
Resolved date:	26/Nov/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_17_STABLE

Description

« Hide

and only display if $a has grade greater than:
is shown as
and only display if has grade greater than:

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Bente Olsen added a comment - 03/Apr/08 05:19 AM

forgot: see lesson.php

Howard Miller made changes - 26/Nov/08 08:47 PM

Field	Original Value	New Value
Assignee	Mark Nielsen [ bushido ]	Howard Miller [ howardsmiller ]

[ Permalink | « Hide ]

Howard Miller added a comment - 26/Nov/08 08:48 PM

I'm pretty sure that the %a should not be there as it is only used in the setup page.

thepurpleblob committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 26/Nov/08 08:49 PM

~~MDL-14155~~
$a in string no longer required. Changed the text slightly to make it make some sense.

MODIFY

lang/en_utf8/lesson.php

Rev. 1.25.2.6

(+2 -2 lines)

thepurpleblob committed 1 file to 'Moodle CVS' - 26/Nov/08 08:51 PM

~~MDL-14155~~
$a in string no longer required. Changed the text slightly to make it make some sense.

Merged from STABLE_19

MODIFY

lang/en_utf8/lesson.php

Rev. 1.38

(+2 -2 lines)

[ Permalink | « Hide ]

Howard Miller added a comment - 26/Nov/08 08:52 PM

String changed in language pack to be more sensible.

Howard Miller made changes - 26/Nov/08 08:52 PM

Fix Version/s		2.0 [ 10122 ]
Resolution		Fixed [ 1 ]
Fix Version/s		1.9.4 [ 10300 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Mitsuhiro Yoshida committed 6 files to 'Lang CVS' - 27/Nov/08 03:49 AM

~~MDL-15326~~ Translated new strings for quiz and quiz stat.
MDL-17359 Updated translated strings.
~~MDL-14155~~ Updated a translated srring for lesson.
Fixed a typo in dbtransfer.php based on lang/en_utf8 fix.

MODIFY	ja_utf8/dbtransfer.php	Rev. 1.2	(+2 -2 lines)
MODIFY	ja_utf8/README	Rev. 1.877	(+1 -1 lines)
MODIFY	ja_utf8/quiz.php	Rev. 1.166	(+4 -2 lines)
MODIFY	ja_utf8/lesson.php	Rev. 1.76	(+2 -2 lines)
MODIFY	ja_utf8/quiz_statistics.php	Rev. 1.18	(+3 -1 lines)
MODIFY	ja_utf8/moodle.php	Rev. 1.330	(+2 -2 lines)

martignoni committed 1 file to 'Lang CVS' - 07/Dec/08 11:43 PM

~~MDL-14155~~ string modified

MODIFY

fr_utf8/lesson.php

Rev. 1.42

(+2 -2 lines)

[ Permalink | « Hide ]

Tim Hunt added a comment - 09/Dec/08 03:10 PM

Should you be editing a language string like that? Remember that the same language packs are use for all Moodle versions >= 1.6. Normally, if you are changing a language string, you should be creating a new one, and leaving the old one alone. It also helps translators know what changed strings need be be re-translated, because they are not changed, they are new. (But I don't know the exact circumstances here.)

Tim Hunt made changes - 09/Dec/08 03:10 PM

QA Assignee

timhunt

[ Permalink | « Hide ]

Howard Miller added a comment - 10/Dec/08 06:44 PM

Ok... I'm not sure what the best thing to do is now. It looks like some translators have picked up on it. In any case the fix was very minor. Just dumping a replacement parameter that was unused.

Noted for future however.

[ Permalink | « Hide ]

Tim Hunt added a comment - 11/Dec/08 01:09 AM

I think it is OK to leave it for now in this case.

Tim Hunt made changes - 11/Dec/08 01:09 AM

Status	Resolved [ 5 ]	Closed [ 6 ]
Fix Version/s	1.9.4 [ 10300 ]
Fix Version/s		1.7.7 [ 10315 ]
Fix Version/s	2.0 [ 10122 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.