Moodle

Unnecessary H1 tag in loan calculator block

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.1
  • Component/s: Blocks
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Line 154 of block_loancalc.php contains the following:

<h1></h1>

I'm guessing this is being used as a spacer??

If so, CSS should be used instead.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Dougiamas added a comment -

Yes should not have empty H1 tags

Show
Martin Dougiamas added a comment - Yes should not have empty H1 tags
Hide
Permalink
Petr Škoda (skodak) added a comment - - edited

Dongsheng please resolve the bugs when you commit a fix, that way you indicate that you think the issue is solved

thanks

Show
Petr Škoda (skodak) added a comment - - edited Dongsheng please resolve the bugs when you commit a fix, that way you indicate that you think the issue is solved thanks

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.