If the solution is always to change it to authenticated user... what's the key about allowing it to be selected? Also... could we, as one step in upgrade... check for it (if empty or so) and set it to default? I guess a lot of people don't "save" the upgrade form on upgrade (I've had some reports about other missing settings like emoticons...) in recently upgraded to 1.9 sites.

Ciao

Can you make sure it gets set to Authenticated User by default, Petr?

going to fix it somehow...

You wrote "the problem was in 1.7.x - I suppose that any site that went through that version is affected"

I can say that our site was upgraded from 1.6.x straight to 1.8.1. and later to 1.9beta during Bugathon and so on, and it was affected.

was reviewing this and it seems that you are changing those "guest" roles to NULL (instead of "Authenticated role". Is that the expected behaviour? Shouldn't we default to the authenticated one?

That's the only point preventing me to close this, as the list now is properly skipping guest roles to be selected and everything else seems to be working ok.

Ciao

/**

• Set a key in global configuration
  *
• Set a key/value pair in both this session's {@link $CFG} global variable
• and in the 'config' database table for future sessions.
  *
• Can also be used to update keys for plugin-scoped configs in config_plugin table.
• In that case it doesn't affect $CFG.
  *
• A NULL value will delete the entry.
  *
• @param string $name the key to set
• @param string $value the value to set (without magic quotes)
• @param string $plugin (optional) the plugin scope
• @uses $CFG
• @return bool
  */
  function set_config($name, $value, $plugin=NULL) {

Some comments above Martin commented "Can you make sure it gets set to Authenticated User by default, Petr?", and that's not current behaviour. Just that.

Ciao

I do not think we should just switch that setting without informing admins, because even the guest role might have some overrides or customisations.

I think that Petr's approach is also valid if it's IMPOSSIBLE to bypass the settings page (i.e. if somebody tries to continue with installation... the new settings page is showed again until saved). And will show, in any case the default "authenticated user" in any case.

But... if it's possible to bypass the settings page, then we MUST set it in upgrade (instead of unsetting).

so, they key here is... does the new settings page in upgrade REQUIRE to be saved to continue upgrade?

Ciao

hmm, maybe I could add a new hack to test the new settings once for admin after login and redirect to upgradesettings if needed, this would also solve the problem with bumping of main version when settings are added in modules.