Issue Details (XML | Word | Printable)

Key: MDL-14233
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Jerome Mouneyrac
Reporter: Iñaki Arenaza
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Make bulk user picture upload handle subdirectories in zip files (with patch)

Created: 06/Apr/08 10:59 PM   Updated: 30/Dec/08 12:33 AM
Return to search
Component/s: Administration
Affects Version/s: 1.9
Fix Version/s: 1.9.2

File Attachments: 1. Text File MDL-14233_update.patch (2 kB)
2. File uploaduserpicture-handle-subdirs-v2.diff (10 kB)

Issue Links:
Relates
 

URL: http://moodle.org/mod/forum/discuss.php?d=94182
Participants: Anthony Borrow, Eloy Lafuente (stronk7), Iñaki Arenaza, Jerome Mouneyrac and Petr Skoda
Security Level: None
QA Assignee: Anthony Borrow
Resolved date: 03/Jul/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
The current code for bulk importing user pictures expects the picture files not to be in subdirectories inside the zip file at all. If the zip file has subdirectories inside it, any files inside those subdirectories are ignored as we skip over directories.

The attached patch improves uploadpicture.php to recursively proccess any subdirectories in the zip file (and the files inside them), in addition to processing the files at the 'root' of the zip file.

Saludos. Iñaki.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Jerome Mouneyrac committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 03/Jul/08 03:16 PM
MDL-14233 Make bulk user picture upload handle subdirectories in zip files (with patch)
MODIFY admin/uploadpicture.php   Rev. 1.1.2.3    (+132 -55 lines)
Jerome Mouneyrac committed 1 file to 'Moodle CVS' - 03/Jul/08 03:35 PM
MDL-14233 Make bulk user picture upload handle subdirectories in zip files, merged from 19 (updated the code in order to use mdlib 2.0)
MODIFY admin/uploadpicture.php   Rev. 1.9    (+134 -54 lines)
Jerome Mouneyrac committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 03/Jul/08 03:36 PM
MDL-14233 remove some var_dump()
MODIFY admin/uploadpicture.php   Rev. 1.1.2.4    (+2 -3 lines)