Issue Details (XML | Word | Printable)

Key: MDL-14238
Type: Improvement Improvement
Status: Open Open
Priority: Minor Minor
Assignee: Rossiani Wijaya
Reporter: Oleg Sychev
Votes: 10
Watchers: 12
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Filter out submitted only, or ungraded only items on assignment grading table

Created: 07/Apr/08 03:00 PM   Updated: 26/Feb/10 04:15 PM
Component/s: Assignment, Usability
Affects Version/s: 1.9
Fix Version/s: 2.0

File Attachments: 1. Text File 20091119_MDL_14238.patch (9 kB)
2. Text File 20091215_mdl_14238.patch (10 kB)
3. Text File 20100104_MDL_14238.patch (11 kB)
4. Text File 20100224_MDL-14238_HEAD.patch (13 kB)
5. Text File assignment.highlith.patch (8 kB)
6. HTML File assignment_filter.html (0.2 kB)

Issue Links:
Relates
 

Participants: Dale William Quattrin, Helen Foster, Martin Dougiamas, Oleg Sychev, Rossiani Wijaya and Wen Hao Chuang
Security Level: None
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
There are two sort of items, that needs grading in assignment:
  • files, that uploaded first time;
  • corrected answers, uploaded after teachers grading and comments ( date of the student answer later that date of teacher's grading).

While first are very easy to find in large table, second requires full attention to every row. It would be much better for teacher, if such rows would be highlighted in some way. It's easy to implement, but saves many trouble for users.

Also, it will be useful to have check box 'show only answered students' in quick grade mode, because empty strings simply clatter the output (execpt off-site answer assignments, of course).



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dale William Quattrin added a comment - 17/May/08 11:51 PM
I think this highlighting would be helpful. In addition, I think that there should some assignment tally column in the Assignment List Page that would show the number of graded assignments. This would allow the teacher to quickly compare submissions with graded assignments so that later submissions are recognized and can be graded.

Wen Hao Chuang added a comment - 22/Aug/08 05:23 AM
Could this be implemented in 2.0 maybe? Thanks!

Oleg Sychev added a comment - 16/Nov/08 07:15 AM
I could implement it even in 1.9, given that someone from Moodleteam will be so kind to review and apply the developed patch (I'll already have some experience in the area). It's quite easy.

The only part where I'm need an advice from someone experienced whis Moodle is what style can be used to highlight some strings in the table? I'm developer, not designer. I'd avoid adding a style as there will be need to ajust all themes to this.


Oleg Sychev added a comment - 19/Nov/08 11:26 PM
Well, color highlighting seems problematical considering adding a new style to the themes (thought I will do it if this is what all whants), but now I consider using a different option: dropdown "show all/with submissions only/with ungraded submissions only', and user preference associated with it. Can anyone there review and upply patch?

Martin Dougiamas added a comment - 08/Dec/08 06:01 PM
Reviewing this ...

Martin Dougiamas added a comment - 08/Dec/08 06:25 PM
Um, where is the patch? :-D

Oleg Sychev added a comment - 08/Dec/08 09:54 PM
Here it is. I'm just giving it one more testing session to be sure.
Patch for MDL-15356 is also available.

Oleg Sychev added a comment - 20/Dec/08 04:17 PM
Can anyone here review the patch?

Wen Hao Chuang added a comment - 21/Dec/08 03:41 PM
OK I could take a look at this next Monday (Dec 22) Pacific time..
Thanks!

Oleg Sychev added a comment - 08/Jan/09 10:40 AM
This patch worked on our university site about a month, and no one expereince any problem (but many quite like it, as it really makes assginment grading more usable). Please review/apply it.

Rossiani Wijaya added a comment - 19/Nov/09 04:29 PM
Oleg,

I had reviewed your patch and work fine on my 1.9.6 version. However I've made some little adjustment on positioning the preference element.

Also, I found a bug on clicking on the column header, it highlighted the previous column. The patch for this bug is also included within the 20091119_MDL_14238.patch

Thanks
Rosie


Oleg Sychev added a comment - 19/Nov/09 08:44 PM
Thank you for improvments, Rosie. I'm not that much of designer, more a developer.

I hope that the patch could be applied now and will be useful for the people who voted for it.


Rossiani Wijaya added a comment - 15/Dec/09 11:02 AM
Found some bugs with hilighting the column.
I created new patch for the fixed (the only file that effected is grader/lib.php).

Rossiani Wijaya added a comment - 04/Jan/10 12:01 PM
fixed earlier patch, so it has moodle coding convention.
There's no changes on the functionality.

Martin Dougiamas added a comment - 02/Feb/10 05:11 PM
+1 for HEAD, after a few small fixes to make it part of the pref form.

Oleg Sychev added a comment - 02/Feb/10 10:11 PM
I'm glad that after an year there is some progress on this issue.

Martin, could you please look (or assign someone who will look) on the two other small assignment improvment patches from our university too: MDL-17613 and MDL-15356?.


Rossiani Wijaya added a comment - 24/Feb/10 11:44 AM
fixed minor changes and add help buttons to option preferences.

I'm adding Helen to the watcher list.

Helen, could you take a look the string content for the help buttons? thanks.

attaching new patch.


Helen Foster added a comment - 26/Feb/10 04:15 PM
Hi Rosie,

I'm wondering whether a help button is necessary for the 3 options ('All', 'Submitted' and 'Require grading')? They seem quite obvious to me!

I think the sentence "Selected preference is saved and will apply to all assignments in all courses." (which I notice the current help files pagesize.html and quickgrade.html also have) is confusing because it doesn't apply to ALL courses (only courses in which a user has appropriate permissions). I suggest it is omitted completely from the help files and just mentioned in the documentation. Similarly I would suggest that there is no need for a new help file savepreferences.html.