Moodle

Various updates to /search directory

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8.4, 1.9
  • Fix Version/s: 1.8.6, 1.9.2
  • Component/s: Administration
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

This is just a placeholder to cover recent changes to /search that didn't have an issue (that I know of).

http://moodle.org/mod/forum/discuss.php?d=94330

Issue Links

This issue will help resolve:
MDL-13992 Global Search requires antiword and pdftotext to be inside the Moodle directory structure Minor Closed
This issue is duplicated by:
MDL-12742 Delete lang files in blocks/search/lang Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Valery Fremaux added a comment -

Copy of a forum answer so we can go on on this issue here.

1. New issues known : problem of invoking physical to text convertors : on Windows the file argument on the command line might take advantage of being double quoted. We experimented an issue on this on Linux, Nicolas Sicard from EFREI high degree french school is contributing for that test field.

2. Lang file : OK, i noticed actually unwanted lang dir in search in 1.9 stable. Removed to comply this rule. You inspired me only having to bother to en_utf8 files. Do you mean other languages (such as Nicolas in France) have a follow up procedure so I can save time translating myself ?

3. If I understood the riht procedure : commit in HEAD and trigger the tracker in order to notify changes to test (in MDL-12345). How will I get feedback of changes success ?

Thanks for guidance, anyway.

Show
Valery Fremaux added a comment - Copy of a forum answer so we can go on on this issue here. 1. New issues known : problem of invoking physical to text convertors : on Windows the file argument on the command line might take advantage of being double quoted. We experimented an issue on this on Linux, Nicolas Sicard from EFREI high degree french school is contributing for that test field. 2. Lang file : OK, i noticed actually unwanted lang dir in search in 1.9 stable. Removed to comply this rule. You inspired me only having to bother to en_utf8 files. Do you mean other languages (such as Nicolas in France) have a follow up procedure so I can save time translating myself ? 3. If I understood the riht procedure : commit in HEAD and trigger the tracker in order to notify changes to test (in MDL-12345). How will I get feedback of changes success ? Thanks for guidance, anyway.
Hide
Permalink
Valery Fremaux added a comment -

"A number of new problems have been created."

Please trigger me back with these problems so I can improve my own procedures.

Show
Valery Fremaux added a comment - "A number of new problems have been created." Please trigger me back with these problems so I can improve my own procedures.
Hide
Permalink
Valery Fremaux added a comment -

There are still lang dirs in block_search in 18 stable.

should we drop them off ?

Cheers.

Show
Valery Fremaux added a comment - There are still lang dirs in block_search in 18 stable. should we drop them off ? Cheers.
Hide
Permalink
Martin Dougiamas added a comment - - edited

I fixed the lang folder just now for 1.9 and 1.8: MDL-12742.

All you need to do from now on is to update the English in moodle/lang/en_utf8/block_search.php. The translators will find out all changes eventually and do the rest.

About committing, yes, if every change has an issue here in the tracker that is correctly set up with

  • correct "fix for" version
  • correct status (eg after a fix has been checked in it should be "resolved")

Then testers will find them and test them as part of the normal process.

Show
Martin Dougiamas added a comment - - edited I fixed the lang folder just now for 1.9 and 1.8: MDL-12742. All you need to do from now on is to update the English in moodle/lang/en_utf8/block_search.php. The translators will find out all changes eventually and do the rest. About committing, yes, if every change has an issue here in the tracker that is correctly set up with
  • correct "fix for" version
  • correct status (eg after a fix has been checked in it should be "resolved")
Then testers will find them and test them as part of the normal process.
Hide
Permalink
Petr Škoda (skodak) added a comment -

this can be closed, right? please reopen if needed

Show
Petr Škoda (skodak) added a comment - this can be closed, right? please reopen if needed
Hide
Permalink
Valery Fremaux added a comment -

I think so either. Closing for the moment.

Show
Valery Fremaux added a comment - I think so either. Closing for the moment.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.