[#MDL-14279] Use get_file_url instead of manual slasharguments check

Issue Details (XML | Word | Printable)

Key:	MDL-14279
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Mathieu Petit-Clair
Reporter:	Mathieu Petit-Clair
Votes:	1
Watchers:	4

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Use get_file_url instead of manual slasharguments check

Created: 09/Apr/08 04:45 PM Updated: 11/Jul/08 10:51 AM

Return to search

Component/s:

General, RSS

Affects Version/s:

1.8, 1.9

Fix Version/s:

1.9.2

File Attachments:

patch-get_file_url-18.txt (30 kB)
2.

patch-get_file_url-19.txt (31 kB)
3.

patch-get_file_url-19_20080707.txt (43 kB)

Issue Links:

Dependency

This issue will help resolve:

~~MDL-11342~~ file path not urlencoded

Participants:	Bill Burgos, Eloy Lafuente (stronk7), Martin Dougiamas, Mathieu Petit-Clair, Petr Skoda and Ryan Smith
Security Level:	None
Resolved date:	11/Jul/08
Affected Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

To fix ~~MDL-13792~~, the function get_file_url was added. This bug aims to make use of it in every possible place. I will send in a big patch later (starting with 1.8) for review.

There is a problem with links to rss files, as most of them are to /rss/file.php, not /file.php. See /blog/rsslib.php, line 41, for one case of this. Possibilities :
1) don't do anything, xml files shouldn't have non-ascii file names anyway
2) modify get_file_url to make a link to /rss/file.php in these cases
3) make a different function for rss links

I vote for #2. Petr? Eloy? What do you think?

All

Comments

Change History

Version Control

Sort Order:

Mathieu Petit-Clair made changes - 09/Apr/08 04:49 PM

Field	Original Value	New Value
Description	To fix ~~MDL-13792~~, the function get_file_url was added. This bug aims to make use of it in every possible place. I will send in a big patch later (starting with 1.8) for review. There is a problem with links to rss files, as most of them are to /rss/file.php, not /file.php. Possibilities : 1) don't do anything, xml files shouldn't have non-ascii file names anyway 2) modify get_file_url to make a link to /rss/file.php in these cases 3) make a different function for rss links I vote for #2. Petr? Eloy? What do you think?	To fix ~~MDL-13792~~, the function get_file_url was added. This bug aims to make use of it in every possible place. I will send in a big patch later (starting with 1.8) for review. There is a problem with links to rss files, as most of them are to /rss/file.php, not /file.php. See /blog/rsslib.php, line 41, for one case of this. Possibilities : 1) don't do anything, xml files shouldn't have non-ascii file names anyway 2) modify get_file_url to make a link to /rss/file.php in these cases 3) make a different function for rss links I vote for #2. Petr? Eloy? What do you think?