Moodle

No "Send message" button.

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.8.5, 1.9.1
  • Fix Version/s: STABLE backlog
  • Component/s: Messages
  • Labels:
    None
  • Environment:
    Firefox 2.0.0.13
    Moodle
  • Affected Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

"Add/Send message" in Participants works fine, but there is no "Send message" button when I select a contact within Messages or click "Send message" in a profile.

Issue Links

This issue is duplicated by:
MDL-9535 Only half of Send Message button displays in Send Message. Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mark Penny added a comment -

I wonder if the Messages issue is related to this little problem. In any case, my guess is a reinstall will solve the problem. The problem seems to be a misplacement to the right. In the earlier pic, you can see that the keyboard helper is in the middle of the window rather than off to the left, as it should be. It has probably pushed the Send message button out of the window.

Show
Mark Penny added a comment - I wonder if the Messages issue is related to this little problem. In any case, my guess is a reinstall will solve the problem. The problem seems to be a misplacement to the right. In the earlier pic, you can see that the keyboard helper is in the middle of the window rather than off to the left, as it should be. It has probably pushed the Send message button out of the window.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Assigning to Mathieu... ciao

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Mathieu... ciao
Hide
Permalink
Mark Penny added a comment -

I installed yesterday's weekly build of Moodle. Same problem at login and message.

Show
Mark Penny added a comment - I installed yesterday's weekly build of Moodle. Same problem at login and message.
Hide
Permalink
Bill Burgos added a comment -

Hi,

We got this on 1.8.4.+

The button is there, it is just not within the dimensions of the window.

Clicking the mouse outside of the HTML editor and pressing the 'Tab' key will shift focus to the 'Send message' button.

Show
Bill Burgos added a comment - Hi, We got this on 1.8.4.+ The button is there, it is just not within the dimensions of the window. Clicking the mouse outside of the HTML editor and pressing the 'Tab' key will shift focus to the 'Send message' button.
Hide
Permalink
Mathieu Petit-Clair added a comment -

I can't reproduce, I feel it's theme-related. In the snapshot, the message window is the same as the one I've got here (as it should be) but it's got one or two extra rows (did you add these manually?). If the html editor has more rows, the popup has to have more pixels...

Adding a scrolling bar to the bottom frame would be a fix... but really, it should have to good dimension to start with.

Show
Mathieu Petit-Clair added a comment - I can't reproduce, I feel it's theme-related. In the snapshot, the message window is the same as the one I've got here (as it should be) but it's got one or two extra rows (did you add these manually?). If the html editor has more rows, the popup has to have more pixels... Adding a scrolling bar to the bottom frame would be a fix... but really, it should have to good dimension to start with.
Hide
Permalink
Mark Penny added a comment -

Bill's solution helps. If I depress the Tab key and scroll vertically with the mouse wheel, the "Send message" button and the "Version without frames and Java script" link come into view. Thanks, Bill.

I've done nothing to the code. In fact, I can't figure out where to go to change the window size. Anybody know?

I, too, thought it might be theme related, but I've just tested with two other themes (metal and custom_corners) and found the same problem.

Show
Mark Penny added a comment - Bill's solution helps. If I depress the Tab key and scroll vertically with the mouse wheel, the "Send message" button and the "Version without frames and Java script" link come into view. Thanks, Bill. I've done nothing to the code. In fact, I can't figure out where to go to change the window size. Anybody know? I, too, thought it might be theme related, but I've just tested with two other themes (metal and custom_corners) and found the same problem.
Hide
Permalink
Jeffrey Silverman added a comment -

I strongly suspect that this is a dupe of MDL-9535.

I'm going to copy my comments there to here, because I'm not sure how or if it is possible to move comments from one issue to another... one moment please...

Show
Jeffrey Silverman added a comment - I strongly suspect that this is a dupe of MDL-9535. I'm going to copy my comments there to here, because I'm not sure how or if it is possible to move comments from one issue to another... one moment please...
Hide
Permalink
Jeffrey Silverman added a comment -

Okay, so, I'm only copying my comments here because this issue is newer and more likely to be looked at than MDL-9535

Here goes...

I have had clients describing this issue in Firefox and in MSIE 7. For some, the "Send" button is pushed so far down the screen as to be not visible at all.

To fix it, I increased the size of the messaging window and the relative size of the frames within the messaging window. (I must note that I actually wasn't able to test whether this worked because I was not exhibiting the issue).

The changes I made touched the following files:

message/lib.php
user/view.php
message/discussion.php

(There might be more places where a popup link to a send message window exists)

The changes occur as follows:

  • to the PHP function "link_to_popup_window()" in message/lib.php (not sure where that is ultimately defined)
  • and to the Javascript function openpopup() in user/view.php

The popup window sizes are hard-coded to 500x500 I just bumped them up to 600x700

And finally, I changed the sizes of the frames in the frameset in message/discussion.php to use % sizes instead of hard-coded values.

And one last potential change I did not make: change the "scrolling=no" to "scrolling=yes" in the bottom frameset so at the very least, people can scroll the frame to get to the Send button on the bottom.

Anyway, I'd like to make another recommendation that the size of the popup windows for messaging not be hard-coded into four or five different places but instead be define()ed or set to a variable somewhere in a library or at the top of the files in which the popup js link occurs.

Thank you!

Show
Jeffrey Silverman added a comment - Okay, so, I'm only copying my comments here because this issue is newer and more likely to be looked at than MDL-9535 Here goes... I have had clients describing this issue in Firefox and in MSIE 7. For some, the "Send" button is pushed so far down the screen as to be not visible at all. To fix it, I increased the size of the messaging window and the relative size of the frames within the messaging window. (I must note that I actually wasn't able to test whether this worked because I was not exhibiting the issue). The changes I made touched the following files: message/lib.php user/view.php message/discussion.php (There might be more places where a popup link to a send message window exists) The changes occur as follows:
  • to the PHP function "link_to_popup_window()" in message/lib.php (not sure where that is ultimately defined)
  • and to the Javascript function openpopup() in user/view.php
The popup window sizes are hard-coded to 500x500 I just bumped them up to 600x700 And finally, I changed the sizes of the frames in the frameset in message/discussion.php to use % sizes instead of hard-coded values. And one last potential change I did not make: change the "scrolling=no" to "scrolling=yes" in the bottom frameset so at the very least, people can scroll the frame to get to the Send button on the bottom. Anyway, I'd like to make another recommendation that the size of the popup windows for messaging not be hard-coded into four or five different places but instead be define()ed or set to a variable somewhere in a library or at the top of the files in which the popup js link occurs. Thank you!

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.