Moodle

Help popup always has title 'Help', should have title depending on content

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 2.0
  • Component/s: Accessibility
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

This was reported to me by our accessibility team. I haven't actually asked them why it is an accessibility problem, but it's certainly not ideal if all the help documents are just titled 'Help' (as they are).

The attached patch changes help to work as follows:

1) If you include in your help file, <title>something</title>, then the HTML title becomes 'Help - something'.

2) If your help file has any heading e.g. <h1>Whatever</h1>, then the HTML title becomes 'Help - Whatever' (for the first heading)

3) If your help file has no headings either then the title is still just 'Help'.

This patch could be applied to 1.9 but I'm not particularly recommending that, HEAD would be ok...

Issue Links

Activity

Hide
Sam Marshall added a comment -

As it wasn't clear why this is an accessibility problem, I have asked our accessibility testers for an explanation. Will comment again when I get one.

Show
Sam Marshall added a comment - As it wasn't clear why this is an accessibility problem, I have asked our accessibility testers for an explanation. Will comment again when I get one.
Hide
Sam Marshall added a comment -

I've now discussed this with the tester involved. She agrees that it's not really an accessibility problem, more of a minor usability issue.

Might still be worth doing though as it's not particularly scary? (For HEAD only)

Show
Sam Marshall added a comment - I've now discussed this with the tester involved. She agrees that it's not really an accessibility problem, more of a minor usability issue. Might still be worth doing though as it's not particularly scary? (For HEAD only)
Hide
Sam Marshall added a comment -

Committed to HEAD as a minor usability enhancement. I did test it with core code, tried several help buttons, all seemed to work fine.

(I was a bit confused that the 'you haven't run cron recently' help button links to the entire 'how to install moodle' guide... but that's a different issue

Show
Sam Marshall added a comment - Committed to HEAD as a minor usability enhancement. I did test it with core code, tried several help buttons, all seemed to work fine. (I was a bit confused that the 'you haven't run cron recently' help button links to the entire 'how to install moodle' guide... but that's a different issue

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: