Moodle

XML Parsing Error in Firefox

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.8.5
  • Fix Version/s: 1.8.6
  • Component/s: Journal
  • Labels:
    None
  • Database:
    PostgreSQL
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

Firefox throws a big red "XML Parsing Error" when viewing mod/journal/report.php in debug mode.

Found a partial fix in MAIN at 1.80. Translated into the attached patch for me against v1.79.2.2

  1. mod_journal_edit.diff
    11/Apr/08 12:50 AM
    0.3 kB
    Chris Bandy
  2. mod_journal_lib.diff
    10/Apr/08 5:10 AM
    0.8 kB
    Chris Bandy

Issue Links

Activity

Hide
Michael Blake added a comment -

Dongsheng, can you determine if this can be implemented?

Show
Michael Blake added a comment - Dongsheng, can you determine if this can be implemented?
Hide
Dongsheng Cai added a comment -

Yes, Chris is right, the patch has been merged, thanks

Show
Dongsheng Cai added a comment - Yes, Chris is right, the patch has been merged, thanks
Hide
Dongsheng Cai added a comment -

Fixed, feel free to reopen if you find any problem.

Show
Dongsheng Cai added a comment - Fixed, feel free to reopen if you find any problem.
Hide
Petr Škoda (skodak) added a comment -

there are many more xhtml strict problems in Journal mod, I guess nobody worked on that because it is not fully supported anymore

from report.php:
line 118 column 41 - Error: there is no attribute "valign"
line 120 column 22 - Error: there is no attribute "width"
line 120 column 260 - Error: there is no attribute "nowrap"
line 120 column 308 - Error: there is no attribute "size"
line 120 column 311 - Error: element "font" undefined
line 126 column 26 - Error: element "font" undefined
line 126 column 118 - Error: there is no attribute "wrap"
line 126 column 179 - Error: there is no attribute "clear"
line 126 column 186 - Error: document type does not allow element "br" here; missing one of "p", "h1", "h2", "h3", "h4", "h5", "h6", "div", "pre", "address", "fieldset", "ins", "del" start-tag
line 130 column 324 - Error: element "font" undefined
line 136 column 26 - Error: element "font" undefined
line 136 column 185 - Error: document type does not allow element "br" here; missing one of "p", "h1", "h2", "h3", "h4", "h5", "h6", "div", "pre", "address", "fieldset", "ins", "del" start-tag
line 141 column 64 - Error: document type does not allow element "br" here; missing one of "p", "h1", "h2", "h3", "h4", "h5", "h6", "div", "pre", "address", "fieldset", "ins", "del" start-tag
line 146 column 64 - Error: document type does not allow element "br" here; missing one of "p", "h1", "h2", "h3", "h4", "h5", "h6", "div", "pre", "address", "fieldset", "ins", "del" start-tag
line 147 column 7 - Error: element "center" undefined

Show
Petr Škoda (skodak) added a comment - there are many more xhtml strict problems in Journal mod, I guess nobody worked on that because it is not fully supported anymore from report.php: line 118 column 41 - Error: there is no attribute "valign" line 120 column 22 - Error: there is no attribute "width" line 120 column 260 - Error: there is no attribute "nowrap" line 120 column 308 - Error: there is no attribute "size" line 120 column 311 - Error: element "font" undefined line 126 column 26 - Error: element "font" undefined line 126 column 118 - Error: there is no attribute "wrap" line 126 column 179 - Error: there is no attribute "clear" line 126 column 186 - Error: document type does not allow element "br" here; missing one of "p", "h1", "h2", "h3", "h4", "h5", "h6", "div", "pre", "address", "fieldset", "ins", "del" start-tag line 130 column 324 - Error: element "font" undefined line 136 column 26 - Error: element "font" undefined line 136 column 185 - Error: document type does not allow element "br" here; missing one of "p", "h1", "h2", "h3", "h4", "h5", "h6", "div", "pre", "address", "fieldset", "ins", "del" start-tag line 141 column 64 - Error: document type does not allow element "br" here; missing one of "p", "h1", "h2", "h3", "h4", "h5", "h6", "div", "pre", "address", "fieldset", "ins", "del" start-tag line 146 column 64 - Error: document type does not allow element "br" here; missing one of "p", "h1", "h2", "h3", "h4", "h5", "h6", "div", "pre", "address", "fieldset", "ins", "del" start-tag line 147 column 7 - Error: element "center" undefined
Hide
Petr Škoda (skodak) added a comment -

I am not sure we should start fixing all these

Show
Petr Škoda (skodak) added a comment - I am not sure we should start fixing all these
Hide
Dongsheng Cai added a comment -

Since, journal mod has been moved to contrib, can I close this issue now?

Show
Dongsheng Cai added a comment - Since, journal mod has been moved to contrib, can I close this issue now?
Hide
Dongsheng Cai added a comment -

Journal mod has been moved to contrib.

Show
Dongsheng Cai added a comment - Journal mod has been moved to contrib.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: