Moodle

target inside a lang file breaks XHTML strict

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Trivial Trivial
  • Resolution: Unresolved
  • Affects Version/s: 1.9
  • Fix Version/s: None
  • Component/s: Language
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

the string
$string['auth_pamdescription']
of the file
moodledata/lang/it_utf8/auth.php
has
target=\"_blank\"
inside.
This breaks XHTML strict.

Andreaaaa, at the end this bug will land on your desktop.
The solution, as you see, is trivial.
Ciao.

Issue Links

Activity

Hide
Daniele Cordella added a comment -

exactly the same error for the string
$string['auth_radiusdescription']
of the same file

Show
Daniele Cordella added a comment - exactly the same error for the string $string['auth_radiusdescription'] of the same file
Hide
Daniele Cordella added a comment -

exactly the same error for the string
$string['auth_shibbolethdescription']
of the same file

Show
Daniele Cordella added a comment - exactly the same error for the string $string['auth_shibbolethdescription'] of the same file
Hide
Koen Roggemans added a comment -

there are more of this in the English language pack, mostly in the helpfiles::

admin.php:$string['releasenoteslink'] = 'For information about this version of Moodle, please see the online <a target=\"_blank\" href=\"$a\">Release Notes</a>';
docs/licence.html:<p align="center"><font size="1"><a href="." target="_top">Moodle Documentation</a></font></p>
help/surveys.html:<a target="paper" href="http://dougiamas.com/writing/herdsa2002">http://dougiamas.com/writing/herdsa2002</a>)</p>
help/surveys.html:<a target="paper" href="http://surveylearning.moodle.com/colles/">http://surveylearning.moodle.com/colles/</a>)</p>
help/hotpot/mods.html: <a href="http://web.uvic.ca/hrd/halfbaked/" target="_blank">Hot Potatoes</a> quizzes via Moodle.
help/lesson/questiontypes.html: see these sites <a href="http://www.zend.com/zend/tut/tutorial-delin2.php" target="_blank">regular-expressions
help/lesson/questiontypes.html: target="_blank">rezeau.org</a>. </p>
help/quiz/calculated.html:<br />More details on how to use these PHP-style functions can be found in the <a target="phpmathdoc" href="http://www.php.net/manual/en/ref.math.php">documentation at the PHP web site</a>
help/quiz/export.html:<p class="moreinfo"><a href="http://www.imsglobal.org/question/" target="_qti">More information on the IMS QTI site</a>
help/quiz/formatctm.html:<a href="http://odbcsock.sourceforge.net/" target="_new"><b>ODBC Socket Server</b></a>. In order to import CTM databases on Linux, you must first download and install
help/quiz/formatctm.html:<a href="http://odbcsock.sourceforge.net/" target="_new">this site</a> on the system.</li>
help/quiz/multianswer.html:Note that addresses like <a href="http://www.moodle.org" target="_blank">www.moodle.org</a> and smileys <img alt="" border="0" src="pix/s/smiley.gif" width="15" height="15" /> all work as normal:<br />
help/wiki/howtowiki.html:<a href="http://erfurtwiki.sourceforge.net/?id=ErfurtWiki" target="_blank">ErfurtWiki</a>,
help/wiki/howtowiki.html:<a href="http://c2.com/cgi/wiki?WikiWikiWeb" target="_blank">WikiWikiWeb</a>
help/wiki/howtowiki.html:There are more possibilities for Wiki mark-up. Please consult the <a href="http://erfurtwiki.sourceforge.net" target="_blank">Erfurt Wiki Homepage</a> for more information.
help/wiki/mods.html:<p>This module is based on <a href="http://erfurtwiki.sourceforge.net" target="_blank">Erfurt Wiki</a>.</p>
help/wiki/wikiusage.html:There are more possibilities for Wiki mark-up. Please consult the <a href="http://erfurtwiki.sourceforge.net" target="_new">Erfurt Wiki Homepage</a> for more information.
help/langpackages.html: <a href="http://download.moodle.org/lang16/" target="_blank">http://download.moodle.org</a>.
mnet.php: 'This can occur when you have <a href=\"$a\" target=\"_blank\">duplicate usernames in your user table</a>.<br />'.
resource.php:$string['localfileinfo'] = '<p>Choose a local file from your computer. The file will not be uploaded to the web site, but Moodle will look for the same file on the computer of anyone viewing this resource.</p><p>This is mostly useful when you have large media files stored on a standard CD-ROM that you distribute to all participants. Each participant is able to choose their own local path for such files, by <a href=\"$a\" target=\"_blank\">editing their user profile</a>.</p>';
xmldb.php:$string['listreservedwords'] = 'List of Reserved Words<br/>(used to keep <a href=\"http://docs.moodle.org/en/XMLDB_reserved_words\" target=\"_blank\">XMLDB_reserved_words</a> updated)';

Show
Koen Roggemans added a comment - there are more of this in the English language pack, mostly in the helpfiles:: admin.php:$string['releasenoteslink'] = 'For information about this version of Moodle, please see the online <a target=\"_blank\" href=\"$a\">Release Notes</a>'; docs/licence.html:<p align="center"><font size="1"><a href="." target="_top">Moodle Documentation</a></font></p> help/surveys.html:<a target="paper" href="http://dougiamas.com/writing/herdsa2002">http://dougiamas.com/writing/herdsa2002</a>)</p> help/surveys.html:<a target="paper" href="http://surveylearning.moodle.com/colles/">http://surveylearning.moodle.com/colles/</a>)</p> help/hotpot/mods.html: <a href="http://web.uvic.ca/hrd/halfbaked/" target="_blank">Hot Potatoes</a> quizzes via Moodle. help/lesson/questiontypes.html: see these sites <a href="http://www.zend.com/zend/tut/tutorial-delin2.php" target="_blank">regular-expressions help/lesson/questiontypes.html: target="_blank">rezeau.org</a>. </p> help/quiz/calculated.html:<br />More details on how to use these PHP-style functions can be found in the <a target="phpmathdoc" href="http://www.php.net/manual/en/ref.math.php">documentation at the PHP web site</a> help/quiz/export.html:<p class="moreinfo"><a href="http://www.imsglobal.org/question/" target="_qti">More information on the IMS QTI site</a> help/quiz/formatctm.html:<a href="http://odbcsock.sourceforge.net/" target="_new"><b>ODBC Socket Server</b></a>. In order to import CTM databases on Linux, you must first download and install help/quiz/formatctm.html:<a href="http://odbcsock.sourceforge.net/" target="_new">this site</a> on the system.</li> help/quiz/multianswer.html:Note that addresses like <a href="http://www.moodle.org" target="_blank">www.moodle.org</a> and smileys <img alt="" border="0" src="pix/s/smiley.gif" width="15" height="15" /> all work as normal:<br /> help/wiki/howtowiki.html:<a href="http://erfurtwiki.sourceforge.net/?id=ErfurtWiki" target="_blank">ErfurtWiki</a>, help/wiki/howtowiki.html:<a href="http://c2.com/cgi/wiki?WikiWikiWeb" target="_blank">WikiWikiWeb</a> help/wiki/howtowiki.html:There are more possibilities for Wiki mark-up. Please consult the <a href="http://erfurtwiki.sourceforge.net" target="_blank">Erfurt Wiki Homepage</a> for more information. help/wiki/mods.html:<p>This module is based on <a href="http://erfurtwiki.sourceforge.net" target="_blank">Erfurt Wiki</a>.</p> help/wiki/wikiusage.html:There are more possibilities for Wiki mark-up. Please consult the <a href="http://erfurtwiki.sourceforge.net" target="_new">Erfurt Wiki Homepage</a> for more information. help/langpackages.html: <a href="http://download.moodle.org/lang16/" target="_blank">http://download.moodle.org</a>. mnet.php: 'This can occur when you have <a href=\"$a\" target=\"_blank\">duplicate usernames in your user table</a>.<br />'. resource.php:$string['localfileinfo'] = '<p>Choose a local file from your computer. The file will not be uploaded to the web site, but Moodle will look for the same file on the computer of anyone viewing this resource.</p><p>This is mostly useful when you have large media files stored on a standard CD-ROM that you distribute to all participants. Each participant is able to choose their own local path for such files, by <a href=\"$a\" target=\"_blank\">editing their user profile</a>.</p>'; xmldb.php:$string['listreservedwords'] = 'List of Reserved Words<br/>(used to keep <a href=\"http://docs.moodle.org/en/XMLDB_reserved_words\" target=\"_blank\">XMLDB_reserved_words</a> updated)';
Hide
Daniele Cordella added a comment -

I knew.
I was not pointing them out because I don't know where and if they are shown somewhere.
You were looking at the lang files I was looking at the code.

Show
Daniele Cordella added a comment - I knew. I was not pointing them out because I don't know where and if they are shown somewhere. You were looking at the lang files I was looking at the code.
Hide
Helen Foster added a comment -

Daniele, thanks for your report, and Koen, thanks for your comment. Linking to MDL-17701 which will hopefully fix this issue.

Show
Helen Foster added a comment - Daniele, thanks for your report, and Koen, thanks for your comment. Linking to MDL-17701 which will hopefully fix this issue.
Hide
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Daniele Cordella added a comment -

this issue is still valid.
cd /your/local/moodlehead/
grep -rn 'target="_blank"' *
still make a long output

Show
Daniele Cordella added a comment - this issue is still valid. cd /your/local/moodlehead/ grep -rn 'target="_blank"' * still make a long output
Hide
Petr Škoda (skodak) added a comment -

Hello,
target="_blank" was revived in html5 because it is technically not possible to live without it - we do javascript tricks only to fool the validation tools. Hopefully we will switch to html5 soon and we would revert all these back...

thanks for the report anyway

Petr

Show
Petr Škoda (skodak) added a comment - Hello, target="_blank" was revived in html5 because it is technically not possible to live without it - we do javascript tricks only to fool the validation tools. Hopefully we will switch to html5 soon and we would revert all these back... thanks for the report anyway Petr

People

Dates

  • Created:
    Updated: