Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Won't Fix
-
Affects Version/s: 1.8.5
-
Fix Version/s: None
-
Component/s: Global search
-
Labels:None
-
Environment:Linux, php 5.2.5
-
Affected Branches:MOODLE_18_STABLE
Description
After upgrading Moodle from 1.8.4+ to latest 1.8.5+ global search stopped working. I have identified a number of issues but some are still there.
- search/indexersplash incorrectly assumes that version of Moodle 1.8 is at max 2007021541 - this will result in fact that indexersplash will not run
if ($CFG->version <= 2007021541){ // 1.8 branch stable timestamp
but now it is 2007021550
- search/documents/physical_doc and physical_pdf will not index documents due to line
$text_converter_cmd = "{$moodleroot}{$command} \"$file\"";
after changing it to (trere are already apostrophes around the file name)
$text_converter_cmd = "{$moodleroot}{$command} $file";
Even with these changes, indexersplash will not finish indexing successfully
Issue Links
| This issue will be resolved by: | ||||
| MDL-14329 | Global Search : Document converters must be set executable (chmoding) on Linux before use |
|
|
|
Thanks for confirmation of quote problem. I identified distinct behaviour on Unix and Windows (and I'm developing shamely on Windows XP !!)
For the branch timestamp, this is actually a problem, as I relied on a comment in version files that seemed to tell that the reference date for a branch WOULD NOT change after a fork. But seemfully I'm wrong on that point.
Maybe MartinD can give me a way : I first tried to get the code compatible for 1.8 versions, but upgrading to the build_navigation() new method till 1.9. This was initially done for saving efforts in syncing the code in my dev structure (7 Moodle instances to check, sync and test !!), maybe should I admit the code MUST fork also... but should there be a magic way to recognize all PRE-1.9 versions...
maybe using a function_exists('build_navigation') would be worthy ?
For quoting problem : I change it in all branches