Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.8.5, 1.9
-
Component/s: Database activity module
-
Labels:None
-
Database:Any
-
Affected Branches:MOODLE_18_STABLE, MOODLE_19_STABLE
-
Fixed Branches:MOODLE_18_STABLE, MOODLE_19_STABLE
Description
While trying to fix MDL-14336 I came across nasty code within mod/data/lib.php that uses a mismatch of single and double quotes like this:
echo '<option value="$cid">'.$currentfield->name.'</option>';
which led not to solve $cid into its value, but printing out "$cid" to the HTML source instead. I have cleaned up the whole quotes related code within if (!empty($currentfields) && !empty($newfields)) { } and also added linebreaks after option tags to prevent making kilometers long lines of HTML code. Now the resulting table also displays properly, previously it got cut down somehow.
Attachments
Issue Links
| This issue has been marked as being related by: | ||||
| MDL-14129 | Remove all the other error() call(head only) |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Hide
Robert Allerstorfer
added a comment -
Thank you for committing, Petr! With this bug having fixed, I was now also able to fix bug MDL-14336 
Show
Robert Allerstorfer
added a comment - Thank you for committing, Petr! With this bug having fixed, I was now also able to fix bug MDL-14336
Here is the patch against MOODLE_19_STABLE. Should be committed asap, since the current code CAN'T work.