[#MDL-14342] Quotes mismatch leads to print "$cid" instead of the value of $cid

Issue Details (XML | Word | Printable)

Key:	MDL-14342
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Major
Assignee:	Petr Skoda
Reporter:	Robert Allerstorfer
Votes:	0
Watchers:	4

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Quotes mismatch leads to print "$cid" instead of the value of $cid

Created: 14/Apr/08 04:50 AM Updated: 26/Jun/08 12:38 AM

Return to search

Component/s:

Database activity module

Affects Version/s:

1.8.5, 1.9

Fix Version/s:

1.8.6, 1.9.1

File Attachments:

MDL-14342.patch (3 kB)

Issue Links:

Relates

This issue has been marked as being related by:

~~MDL-14129~~ Remove all the other error() call(head only)

Database:	Any
Participants:	Dongsheng Cai, Eloy Lafuente (stronk7), Petr Skoda and Robert Allerstorfer
Security Level:	None
QA Assignee:	Eloy Lafuente (stronk7)
Resolved date:	14/Apr/08
Affected Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE

Description

« Hide

While trying to fix ~~MDL-14336~~ I came across nasty code within mod/data/lib.php that uses a mismatch of single and double quotes like this:

echo '<option value="$cid">'.$currentfield->name.'</option>';

which led not to solve $cid into its value, but printing out "$cid" to the HTML source instead. I have cleaned up the whole quotes related code within if (!empty($currentfields) && !empty($newfields)) { } and also added linebreaks after option tags to prevent making kilometers long lines of HTML code. Now the resulting table also displays properly, previously it got cut down somehow.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Robert Allerstorfer added a comment - 14/Apr/08 04:52 AM

Here is the patch against MOODLE_19_STABLE. Should be committed asap, since the current code CAN'T work.

Robert Allerstorfer made changes - 14/Apr/08 04:52 AM

Field	Original Value	New Value
Attachment		MDL-14342.patch [ 13633 ]

Petr Skoda made changes - 14/Apr/08 06:11 AM

Priority

Blocker [ 1 ]

Major [ 3 ]

Petr Skoda made changes - 14/Apr/08 06:11 AM

Assignee

Martin Dougiamas [ dougiamas ]

Petr Skoda [ skodak ]

Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 14/Apr/08 06:17 AM

~~MDL-14342~~ fixed wrong quotes

MODIFY	mod/data/lib.php		Rev. 1.137.2.12		(+2 -2 lines)
MODIFY	mod/data/Attic/preset_class.php		Rev. 1.2.2.2		(+2 -2 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 14/Apr/08 06:22 AM

~~MDL-14342~~ fixed wrong quotes; merged from MOODLE_19_STABLE

MODIFY	mod/data/Attic/preset_class.php		Rev. 1.4		(+2 -2 lines)
MODIFY	mod/data/lib.php		Rev. 1.152		(+13 -13 lines)

Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 14/Apr/08 06:26 AM

~~MDL-14342~~ fixed wrong quotes; merged from MOODLE_19_STABLE

MODIFY

mod/data/lib.php

Rev. 1.113.2.10

(+2 -2 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 14/Apr/08 06:55 AM

found one more in new preset class, thanks for the report and patch

Petr Skoda made changes - 14/Apr/08 06:55 AM

Fix Version/s		1.8.6 [ 10270 ]
Fix Version/s		1.9.1 [ 10240 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

[ Permalink | « Hide ]

Robert Allerstorfer added a comment - 15/Apr/08 07:20 AM

Thank you for committing, Petr! With this bug having fixed, I was now also able to fix bug ~~MDL-14336~~

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 15/Apr/08 08:15 AM

Verified, closing. Thanks!

Eloy Lafuente (stronk7) made changes - 15/Apr/08 08:15 AM

Status

Resolved [ 5 ]

Closed [ 6 ]

Eloy Lafuente (stronk7) made changes - 15/Apr/08 08:16 AM

QA Assignee

stronk7

[ Permalink | « Hide ]

Robert Allerstorfer added a comment - 25/Jun/08 07:17 PM

Petr,

I noticed that your change of mod/data/lib.php in HEAD (http://cvs.moodle.org/moodle/mod/data/lib.php?r1=1.151&r2=1.152) was not limited to the reported problem. In addition, you reverted Dongsheng's commit http://cvs.moodle.org/moodle/mod/data/lib.php?r1=1.146&r2=1.147 as part of ~~MDL-14129~~. Could you please explain?

Thanks.

Robert Allerstorfer made changes - 25/Jun/08 07:20 PM

Link

This issue has been marked as being related by ~~MDL-14129~~ [ ~~MDL-14129~~ ]

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 26/Jun/08 12:38 AM

Fixed, no worries

All content on this web site is made available under the GNU General Public License, unless otherwise stated.