|
|
While trying to fix MDL-14336 I came across nasty code within mod/data/lib.php that uses a mismatch of single and double quotes like this:
echo '<option value="$cid">'.$currentfield->name.'</option>';
which led not to solve $cid into its value, but printing out "$cid" to the HTML source instead. I have cleaned up the whole quotes related code within if (!empty($currentfields) && !empty($newfields)) { } and also added linebreaks after option tags to prevent making kilometers long lines of HTML code. Now the resulting table also displays properly, previously it got cut down somehow.
|
|
Description
|
While trying to fix MDL-14336 I came across nasty code within mod/data/lib.php that uses a mismatch of single and double quotes like this:
echo '<option value="$cid">'.$currentfield->name.'</option>';
which led not to solve $cid into its value, but printing out "$cid" to the HTML source instead. I have cleaned up the whole quotes related code within if (!empty($currentfields) && !empty($newfields)) { } and also added linebreaks after option tags to prevent making kilometers long lines of HTML code. Now the resulting table also displays properly, previously it got cut down somehow.
|
Show » |
made changes - 14/Apr/08 04:52 AM
| Field |
Original Value |
New Value |
|
Attachment
|
|
MDL-14342.patch
[ 13633
]
|
made changes - 14/Apr/08 06:11 AM
|
Priority
|
Blocker
[ 1
]
|
Major
[ 3
]
|
made changes - 14/Apr/08 06:11 AM
|
Assignee
|
Martin Dougiamas
[ dougiamas
]
|
Petr Skoda
[ skodak
]
|
made changes - 14/Apr/08 06:55 AM
|
Fix Version/s
|
|
1.8.6
[ 10270
]
|
|
Fix Version/s
|
|
1.9.1
[ 10240
]
|
|
Resolution
|
|
Fixed
[ 1
]
|
|
Status
|
Open
[ 1
]
|
Resolved
[ 5
]
|
made changes - 15/Apr/08 08:15 AM
|
Status
|
Resolved
[ 5
]
|
Closed
[ 6
]
|
made changes - 15/Apr/08 08:16 AM
made changes - 25/Jun/08 07:20 PM
|
Link
|
|
This issue has been marked as being related by MDL-14129
[ MDL-14129
]
|
|
Bug
Closed
Major
Quotes mismatch leads to print "$cid" instead of the value of $cid
