Issue Details (XML | Word | Printable)

Key: MDL-14342
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Petr Skoda
Reporter: Robert Allerstorfer
Votes: 0
Watchers: 4
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Quotes mismatch leads to print "$cid" instead of the value of $cid

Created: 14/Apr/08 04:50 AM   Updated: 26/Jun/08 12:38 AM
Return to search
Component/s: Database activity module
Affects Version/s: 1.8.5, 1.9
Fix Version/s: 1.8.6, 1.9.1

File Attachments: 1. Text File MDL-14342.patch (3 kB)

Issue Links:
Relates
 

Database: Any
Participants: Dongsheng Cai, Eloy Lafuente (stronk7), Petr Skoda and Robert Allerstorfer
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 14/Apr/08
Affected Branches: MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
While trying to fix MDL-14336 I came across nasty code within mod/data/lib.php that uses a mismatch of single and double quotes like this:

echo '<option value="$cid">'.$currentfield->name.'</option>';

which led not to solve $cid into its value, but printing out "$cid" to the HTML source instead. I have cleaned up the whole quotes related code within if (!empty($currentfields) && !empty($newfields)) { } and also added linebreaks after option tags to prevent making kilometers long lines of HTML code. Now the resulting table also displays properly, previously it got cut down somehow.





 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 14/Apr/08 06:17 AM
MDL-14342 fixed wrong quotes
MODIFY mod/data/Attic/preset_class.php   Rev. 1.2.2.2    (+2 -2 lines)
MODIFY mod/data/lib.php   Rev. 1.137.2.12    (+2 -2 lines)
Petr Skoda committed 2 files to 'Moodle CVS' - 14/Apr/08 06:22 AM
MDL-14342 fixed wrong quotes; merged from MOODLE_19_STABLE
MODIFY mod/data/lib.php   Rev. 1.152    (+13 -13 lines)
MODIFY mod/data/Attic/preset_class.php   Rev. 1.4    (+2 -2 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 14/Apr/08 06:26 AM
MDL-14342 fixed wrong quotes; merged from MOODLE_19_STABLE
MODIFY mod/data/lib.php   Rev. 1.113.2.10    (+2 -2 lines)