|
[
Permalink
| « Hide
]
Petr Škoda (skodak) added a comment - 17/Apr/08 04:30 AM
I think this could really work much better, Martin should I implement it?
forum_user_can_see_post_origin() is already written in the lib.php file I sent in http://tracker.moodle.org/browse/MDL-14270
cron - the new function in forum/lib.php is the check to make sure that emails are sent only to the appropriate groups. This hasn't been done yet, but the check is there. reply and unread count still work correctly Recent activity needs the same check using the new function in forum/lib.php so that only the changes that the users group makes show up. Also the discuss.php hasn't been changed to disallow users, but again, this will use the same new function. forum_user_can_see_post_origin() does way too much db access (1 + 3per depth level) for each post, of course you could cache that but then it would eat a lot of memory
and it also relies on the current group membership which is different from what we have now I can not review the code properly sorry
1/ it is not patch/diff format 2/ the whitespace is changed - my eclipse chokes during the diff and for some unknown reason the "ignore whitespace" option does not work managed to diff it - I do not like this modification,
I managed to remove old hacks and cleanup the forum code just recently and do not feel like adding exceptions only for single discussion again all over the place 
The bonus of the proposed solution above is that it could be used in normal separate forums too - I think it might be useful more often to bulk post into all separate groups. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
New Feature
Open
Minor
bulk posting into all groups when forum in separate mode
 |
|
