Moodle

bulk posting into all groups when forum in separate mode

Details

  • Type: New Feature New Feature
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.9
  • Fix Version/s: None
  • Component/s: Forum
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

The idea is to simplify the creation of posts in separate group mode forums.
it would require a new switch in post form, visible only when forum in "separate mode" && "has access to all groups" && "all participants selected"

The other related option could be - redirect to discussion view if only one present and not allowed to start new discussions - this would effectively make it a single simple discussion in separate mode, but the forum overview would be much more intuitive for teachers.

Attachments

  1. File
    lib.diff
    17/Apr/08 4:50 AM
    6 kB
    Matthew Davidson
  2. File
    lib.php
    17/Apr/08 4:33 AM
    244 kB
    Matthew Davidson
  3. File
    post.diff
    17/Apr/08 4:50 AM
    3 kB
    Matthew Davidson
  4. File
    post.php
    17/Apr/08 4:32 AM
    33 kB
    Matthew Davidson
  5. File
    view.diff
    17/Apr/08 4:50 AM
    2 kB
    Matthew Davidson
  6. File
    view.php
    17/Apr/08 4:32 AM
    12 kB
    Matthew Davidson

Issue Links

This issue will help resolve:
MDL-15327 Group members can't reply to discussions in a forum available for group members only Major Closed
This issue is duplicated by:
MDL-1160 Editing teachers should have an option of posting to all groups at once Trivial Closed
This issue has been marked as being related by:
MDL-14270 Separate groups and forums Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

I think this could really work much better, Martin should I implement it?

Show
Petr Škoda (skodak) added a comment - I think this could really work much better, Martin should I implement it?
Hide
Permalink
Matthew Davidson added a comment -

forum_user_can_see_post_origin() is already written in the lib.php file I sent in http://tracker.moodle.org/browse/MDL-14270

cron - the new function in forum/lib.php is the check to make sure that emails are sent only to the appropriate groups. This hasn't been done yet, but the check is there.

reply and unread count still work correctly

Recent activity needs the same check using the new function in forum/lib.php so that only the changes that the users group makes show up. Also the discuss.php hasn't been changed to disallow users, but again, this will use the same new function.

Show
Matthew Davidson added a comment - forum_user_can_see_post_origin() is already written in the lib.php file I sent in http://tracker.moodle.org/browse/MDL-14270 cron - the new function in forum/lib.php is the check to make sure that emails are sent only to the appropriate groups. This hasn't been done yet, but the check is there. reply and unread count still work correctly Recent activity needs the same check using the new function in forum/lib.php so that only the changes that the users group makes show up. Also the discuss.php hasn't been changed to disallow users, but again, this will use the same new function.
Hide
Permalink
Petr Škoda (skodak) added a comment -

forum_user_can_see_post_origin() does way too much db access (1 + 3per depth level) for each post, of course you could cache that but then it would eat a lot of memory
and it also relies on the current group membership which is different from what we have now

Show
Petr Škoda (skodak) added a comment - forum_user_can_see_post_origin() does way too much db access (1 + 3per depth level) for each post, of course you could cache that but then it would eat a lot of memory and it also relies on the current group membership which is different from what we have now
Hide
Permalink
Petr Škoda (skodak) added a comment - - edited

I can not review the code properly sorry
1/ it is not patch/diff format
2/ the whitespace is changed - my eclipse chokes during the diff and for some unknown reason the "ignore whitespace" option does not work

Show
Petr Škoda (skodak) added a comment - - edited I can not review the code properly sorry 1/ it is not patch/diff format 2/ the whitespace is changed - my eclipse chokes during the diff and for some unknown reason the "ignore whitespace" option does not work
Hide
Permalink
Petr Škoda (skodak) added a comment -

managed to diff it - I do not like this modification,
I managed to remove old hacks and cleanup the forum code just recently and do not feel like adding exceptions only for single discussion again all over the place

The bonus of the proposed solution above is that it could be used in normal separate forums too - I think it might be useful more often to bulk post into all separate groups.

Show
Petr Škoda (skodak) added a comment - managed to diff it - I do not like this modification, I managed to remove old hacks and cleanup the forum code just recently and do not feel like adding exceptions only for single discussion again all over the place The bonus of the proposed solution above is that it could be used in normal separate forums too - I think it might be useful more often to bulk post into all separate groups.

People

Vote (8)
Watch (11)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.