Moodle

Setting $THEME->makenavmenulist = true in a theme's config.php throws off a php notice

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.5
  • Component/s: Themes
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Setting $THEME->makenavmenulist = true in a theme's config.php throws off a php notice:
Notice: Undefined property: object::$cm in \moodle\lib\weblib.php on line 5443
I've just noticed this with latest moodle 1.9 version because the theme I use (orangechoc) has this line in its config.php file:
$THEME->makenavmenulist = true;
I wonder what is the use of makenavmenulist anyway, as I notice that NONE of the themes in Moodle distribution has this enabled (it's set to FALSE for all of the themes!).
Either makenavmenulist is useful and used, and something should be done about that PHP error notice OR it's useless and should be deleted from moodle.
Joseph

Activity

Hide
Joseph Rézeau added a comment -

BUMP...

Show
Joseph Rézeau added a comment - BUMP...
Hide
Tim Hunt added a comment -

Hey! Martin was just telling me about this nice feature he had implemented, and how he thought no one even knew about it, much less tried to use it!

I've fixed the notice. Note, however, that http://docs.moodle.org/en/Development:Navigation_2.0 may render it obsolete.

Show
Tim Hunt added a comment - Hey! Martin was just telling me about this nice feature he had implemented, and how he thought no one even knew about it, much less tried to use it! I've fixed the notice. Note, however, that http://docs.moodle.org/en/Development:Navigation_2.0 may render it obsolete.
Hide
Sam Hemelryk added a comment -

Confirmed the notice is not shown. Thanks

Show
Sam Hemelryk added a comment - Confirmed the notice is not shown. Thanks

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: