Details
-
Type:
Sub-task
-
Status:
Open
-
Priority:
Minor
-
Resolution: Unresolved
-
Affects Version/s: 1.9
-
Fix Version/s: None
-
Component/s: Blocks
-
Labels:None
-
Affected Branches:MOODLE_19_STABLE
Description
The block code currently shows the roles button for all non-pinned blocks, including those on the myMoodle page. But on myMoodle, you can't give any-one else permission to see the page or block instance, so I think roles are redundant. The icon is likely to confuse students who wouldn't normally see it.
I think the fix is in blocks/moodleblock.class.php
$onmymoodle = strpos( $_SERVER['PHP_SELF'], '/my/index.php' ) !== false ? true : false;
if( !$onmymoodle & empty($this->instance->pinned)) {
instead of just if( empty($this->instance->pinned)) {
Unless you can find a more elegant solution?
