Issue Details (XML | Word | Printable)

Key: MDL-14424
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Helen Foster
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Icon for database activity entries requiring approval needs to be made more visible

Created: 19/Apr/08 12:28 AM   Updated: 26/Apr/08 07:47 AM
Component/s: Database activity module
Affects Version/s: 1.9
Fix Version/s: 1.9.1

Participants: A. T. Wyatt, Eloy Lafuente (stronk7), Helen Foster and Petr Skoda
Security Level: None
QA Assignee: Helen Foster
Resolved date: 22/Apr/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
The icon for database activity entries requiring approval was previously a big red tick. It's now a tiny black tick. Please could it be changed back.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 19/Apr/08 02:08 AM
Well, the icon is everything but small:

http://cvs.moodle.org/moodle/pix/i/approve.gif?view=markup

was added (because was missing) as part of MDL-8188.

I guess it's more a thing of CSS or so (the size) ?

Ciao


A. T. Wyatt added a comment - 19/Apr/08 02:49 AM
No, actually I think the color is the important thing. As long as we cannot sort by recent changes, that color is very important. It is the only way we can find database entries that have been edited. If the check is black it is extremely hard to distinguish.

Petr Skoda added a comment - 20/Apr/08 04:58 AM
icon is now bigger and you can sort by Approved
I hope the red is not important anymore

please test and reopen if needed, thanks for the report!


Helen Foster added a comment - 20/Apr/08 10:57 PM
Thanks Petr I'll test this on Tuesday.

Petr Skoda added a comment - 22/Apr/08 09:17 PM
reopening, going to make the icon bigger

Petr Skoda added a comment - 22/Apr/08 09:36 PM
fixed in cvs - approve icon now bigger by default - size can be changed through CSS

Helen Foster added a comment - 22/Apr/08 09:46 PM
Thanks Petr, the icon looks really good now

A. T. Wyatt added a comment - 26/Apr/08 07:47 AM
Agree! I couldn't miss it! The size made up for not having red. And that was a terrific help. Thanks.