Issue Details (XML | Word | Printable)

Key: MDL-14434
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Tim Hunt
Reporter: Ray Lawrence
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Cannot edit default category details in course when only the default category exists

Created: 19/Apr/08 11:58 PM   Updated: 11/Jun/09 11:44 AM
Return to search
Component/s: Questions
Affects Version/s: 1.9
Fix Version/s: 1.9.4

Environment: any

Database: MySQL
Participants: Ray Lawrence, Sam Hemelryk and Tim Hunt
Security Level: None
QA Assignee: Sam Hemelryk
Resolved date: 27/Nov/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
To recreate:

Go to questions
Categories tab
Click edit icon for the default category in the course
Save (with or without amending any details)
Error message "Cannot move the category 'Default for backup_1'. It is the last in this context."
Category info not changed.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Ray Lawrence added a comment - 20/Apr/08 12:00 AM
Works as expected if another category is added prior to editing

Ray Lawrence made changes - 20/Apr/08 12:00 AM
Field Original Value New Value
Summary Cannot edit default category details in course Cannot edit default category details in course when only the default category exists
[ Permalink | « Hide ]
Tim Hunt added a comment - 21/Apr/08 06:02 PM
Have you got time to take a look at this Jamie?

Tim Hunt made changes - 21/Apr/08 06:02 PM
Assignee Tim Hunt [ timhunt ] Jamie Pratt [ jamiesensei ]
Tim Hunt made changes - 27/Nov/08 03:58 PM
Assignee Jamie Pratt [ jamiesensei ] Tim Hunt [ timhunt ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 27/Nov/08 04:04 PM
Ah, this is the bug I fixed, and then could not remember what I had done:

http://cvs.moodle.org/moodle/question/category_class.php?view=log#rev1.44
http://git.catalyst.net.nz/gitweb?p=moodle-r2.git;a=commitdiff;h=41c96651b5436a657f27b191e0df7d2f995d2068

Right, so this is fixed in HEAD, and I will backport it to 1.9 now.


tjhunt committed 5 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 27/Nov/08 08:50 PM
question bank: MDL-14434 Cannot edit the only question category in a context.
MODIFY question/category_form.php   Rev. 1.4.2.2    (+1 -1 lines)
MODIFY question/category_class.php   Rev. 1.32.2.9    (+35 -31 lines)
MODIFY lib/questionlib.php   Rev. 1.119.2.18    (+3 -3 lines)
MODIFY question/editlib.php   Rev. 1.76.2.10    (+26 -9 lines)
MODIFY question/contextmove.php   Rev. 1.5.2.3    (+3 -3 lines)
tjhunt committed 5 files to 'Moodle CVS' - 27/Nov/08 08:50 PM
question bank: MDL-14434 Cannot edit the only question category in a context.
MODIFY question/category_form.php   Rev. 1.7    (+1 -9 lines)
MODIFY question/category_class.php   Rev. 1.50    (+3 -8 lines)
MODIFY question/contextmove.php   Rev. 1.12    (+3 -2 lines)
MODIFY lib/questionlib.php   Rev. 1.176    (+2 -2 lines)
MODIFY question/editlib.php   Rev. 1.95    (+24 -9 lines)
[ Permalink | « Hide ]
Tim Hunt added a comment - 27/Nov/08 08:50 PM
Done!

Tim Hunt made changes - 27/Nov/08 08:50 PM
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 1.9.4 [ 10300 ]
Resolution Fixed [ 1 ]
[ Permalink | « Hide ]
Sam Hemelryk added a comment - 11/Jun/09 11:44 AM
Tested and all working well thanks Tim

Sam Hemelryk made changes - 11/Jun/09 11:44 AM
QA Assignee samhemelryk
Status Resolved [ 5 ] Closed [ 6 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators