Issue Details (XML | Word | Printable)

Key: MDL-14439
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Jerome Mouneyrac
Reporter: Andrea Bicciolo
Votes: 0
Watchers: 6
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Drop down menus not usable and not accessible in IE using keyboard only

Created: 20/Apr/08 02:26 AM   Updated: 09/Jul/08 06:59 AM
Return to search
Component/s: Accessibility, Usability
Affects Version/s: 1.8.5, 1.9, 2.0
Fix Version/s: 1.8.6, 1.9.1

File Attachments: 1. File dropdown.js (3 kB)
2. Text File lib.19.second.version.patch (2 kB)


Participants: Andrea Bicciolo, Anthony Borrow, Eloy Lafuente (stronk7), Helen Foster, Jerome Mouneyrac and Martin Dougiamas
Security Level: None
QA Assignee: Helen Foster
Resolved date: 02/May/08
Affected Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
in IE, when using keyboard in Drop down menus (for example, adding a resource or activity, or selecting a language in the user profile, or using the drop down menu on top left of each resource/activity page), it is necessary to be extremely fast to select an option.
If you are not very very fast, the first option is always selected by default. The problem does not appears using FireFox.

Possible solution: add a flag in the user profile allowing people to show the menu buttons (currently available in the code, but enclosed in the NOSCRIPT tag). This way people using either keyboard or mouse will be able to use the drop down menus.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 21/Apr/08 09:45 AM
Wow, this is really annoying.

Anything in our side we can do to fix that IE behaviour (note I haven't tested it) ?Ideas?

Adding some people here...ciao


Martin Dougiamas added a comment - 21/Apr/08 04:56 PM
OK, this is terrible. Can you look into this Jerome?

Is there alternative JS we can use to do the same thing that might keep IE happy? Or require ENTER to be hit. Otherwise, perhaps we can add a better delay or something.

The good thing is that most of this type of menus are all done in one small function: popup_form().


Martin Dougiamas added a comment - 29/Apr/08 05:14 PM
Jerome, can we aim to have a patch here for this by tomorrow?

Jerome Mouneyrac added a comment - 30/Apr/08 02:33 PM - edited
I attached a patch + a javascript file that you need to put it into /lib/

Note: in order to navigate into a dropdown list without this patch, use ATL+Arrow


Andrea Bicciolo added a comment - 30/Apr/08 03:04 PM
Thanks. The patch will also work on 1.8 stable?

Jerome Mouneyrac added a comment - 30/Apr/08 03:42 PM
Hi Andrea, I did exactly the same changed on 1.8 and it works as well.

Andrea Bicciolo added a comment - 30/Apr/08 03:48 PM
Fantastic Jerome, thanks. Should we expect it on CVS by next Tuesday ?

Jerome Mouneyrac added a comment - 30/Apr/08 04:45 PM
I optimized the patch and javascript file. (the javascript code is now called only once, and I added some comments in the javascript file)
The 'dropdown.js' javascript file has still to be put in /lib/
I tested these new modifications on 1.8, it works.

Martin Dougiamas added a comment - 30/Apr/08 05:36 PM
Getting there, thanks, Jerome!

One more thing. Is it possible to perhaps avoid all that JS running on Firefox at all, by putting the browser check in weblib.php using PHP. So if it's not IE or Opera, then we just do it exactly like the old way which works fine.


Jerome Mouneyrac added a comment - 01/May/08 11:15 AM
Patch and javascript file updated. PHP is doing the browser checking now. Tested on 1.9 and 1.8.

Martin Dougiamas added a comment - 01/May/08 05:29 PM
That's the one, thanks Jerome!

Jerome Mouneyrac added a comment - 02/May/08 11:06 AM
ok, commited on trunk, 1.9 Stable and 1.8 Stable

Andrea Bicciolo added a comment - 02/May/08 05:38 PM
Thanks, great fix! Just to be sure, is this fix working when javascript is disabled ?

Helen Foster added a comment - 06/May/08 05:13 PM
Tested 1.8 and 1.9 with IE6. Andrea, thanks for reporting and Jerome, thanks for fixing

Anthony Borrow added a comment - 09/Jul/08 06:59 AM
David/Laia - I'm not sure what the usability issue here is other than to encourage cross-browser compatibility. As a rule, Moodle has done well in following coding standards and then goes in and makes patches when IE (or any other browser) deviates from the standards. I can't think of anything that Laia would need to do with these types of issues as they are really browser bugs rather than Moodle UI issues. If Laia wanted she could come up with a list of the various types of user interfaces that users use and where they use them. For example, dropdown boxes, menus, tabs, pushbuttons, etc. Having some research about where such things are used might be of some use and may reveal some inconsistencies. My theory is the more data we have the better. Then it is just transforming that data to meaningful/useful information. Peace - Anthony