|
Eloy Lafuente (stronk7) made changes - 21/Apr/08 09:45 AM
OK, this is terrible. Can you look into this Jerome?
Is there alternative JS we can use to do the same thing that might keep IE happy? Or require ENTER to be hit. Otherwise, perhaps we can add a better delay or something. The good thing is that most of this type of menus are all done in one small function: popup_form().
Martin Dougiamas made changes - 21/Apr/08 04:56 PM
Jerome, can we aim to have a patch here for this by tomorrow?
Jerome Mouneyrac made changes - 30/Apr/08 11:14 AM
Jerome Mouneyrac made changes - 30/Apr/08 11:19 AM
Jerome Mouneyrac made changes - 30/Apr/08 11:20 AM
Jerome Mouneyrac made changes - 30/Apr/08 11:24 AM
Jerome Mouneyrac made changes - 30/Apr/08 11:25 AM
Jerome Mouneyrac made changes - 30/Apr/08 02:33 PM
I attached a patch + a javascript file that you need to put it into /lib/
Note: in order to navigate into a dropdown list without this patch, use ATL+Arrow
Jerome Mouneyrac made changes - 30/Apr/08 02:33 PM
Jerome Mouneyrac made changes - 30/Apr/08 02:34 PM
Thanks. The patch will also work on 1.8 stable?
Hi Andrea, I did exactly the same changed on 1.8 and it works as well.
Fantastic Jerome, thanks. Should we expect it on CVS by next Tuesday ?
Jerome Mouneyrac made changes - 30/Apr/08 04:37 PM
Jerome Mouneyrac made changes - 30/Apr/08 04:37 PM
I optimized the patch and javascript file. (the javascript code is now called only once, and I added some comments in the javascript file)
The 'dropdown.js' javascript file has still to be put in /lib/ I tested these new modifications on 1.8, it works.
Jerome Mouneyrac made changes - 30/Apr/08 04:45 PM
Getting there, thanks, Jerome!
One more thing. Is it possible to perhaps avoid all that JS running on Firefox at all, by putting the browser check in weblib.php using PHP. So if it's not IE or Opera, then we just do it exactly like the old way which works fine.
Jerome Mouneyrac made changes - 01/May/08 11:12 AM
Jerome Mouneyrac made changes - 01/May/08 11:12 AM
Jerome Mouneyrac made changes - 01/May/08 11:12 AM
Patch and javascript file updated. PHP is doing the browser checking now. Tested on 1.9 and 1.8.
Jerome Mouneyrac made changes - 01/May/08 11:15 AM
That's the one, thanks Jerome!
Jerome Mouneyrac committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 02/May/08 10:10 AM
Jerome Mouneyrac committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 02/May/08 10:20 AM
Jerome Mouneyrac committed 1 file to 'Moodle CVS' - 02/May/08 10:38 AM
Jerome Mouneyrac committed 2 files to 'Moodle CVS' - 02/May/08 10:45 AM
Jerome Mouneyrac committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 02/May/08 10:47 AM
Jerome Mouneyrac committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 02/May/08 10:52 AM
ok, commited on trunk, 1.9 Stable and 1.8 Stable
Jerome Mouneyrac made changes - 02/May/08 11:06 AM
Thanks, great fix! Just to be sure, is this fix working when javascript is disabled ?
Tested 1.8 and 1.9 with IE6. Andrea, thanks for reporting and Jerome, thanks for fixing
Helen Foster made changes - 06/May/08 05:13 PM
Jerome Mouneyrac committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 18/Jun/08 01:40 PM
Jerome Mouneyrac committed 2 files to 'Moodle CVS' - 18/Jun/08 01:58 PM
David Horat made changes - 30/Jun/08 04:47 PM
David/Laia - I'm not sure what the usability issue here is other than to encourage cross-browser compatibility. As a rule, Moodle has done well in following coding standards and then goes in and makes patches when IE (or any other browser) deviates from the standards. I can't think of anything that Laia would need to do with these types of issues as they are really browser bugs rather than Moodle UI issues. If Laia wanted she could come up with a list of the various types of user interfaces that users use and where they use them. For example, dropdown boxes, menus, tabs, pushbuttons, etc. Having some research about where such things are used might be of some use and may reveal some inconsistencies. My theory is the more data we have the better. Then it is just transforming that data to meaningful/useful information. Peace - Anthony
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Closed
Critical
Drop down menus not usable and not accessible in IE using keyboard only
 |
|
All content on this web site is made available under the GNU General Public License, unless otherwise stated.
Anything in our side we can do to fix that IE behaviour (note I haven't tested it) ?Ideas?
Adding some people here...ciao