Issue Details (XML | Word | Printable)

Key: MDL-14460
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Dongsheng Cai
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Fix all ocurrences of get_context_instance(CONTEXT_SYSTEM, SITEID)

Created: 21/Apr/08 10:46 PM   Updated: 06/May/08 07:40 AM
Return to search
Component/s: Lib, Roles
Affects Version/s: 1.9
Fix Version/s: 1.9.1

Database: Any
Participants: Dongsheng Cai and Eloy Lafuente (stronk7)
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 02/May/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
In Moodle code there are a lot of calls of this type:

get_context_instance(CONTEXT_SYSTEM, SITEID)

And, when requesting for CONTEXT_SYSTEM we don't need to specify SITEID any more.

So, all the sentences above should be changed to:

get_context_instance(CONTEXT_SYSTEM)

There are aprox. 130 changes to perform, distributed along aprox. 90 files. I would suggest to do the change progressively, fixing 3-4 files each day, both in 19_STABLE and HEAD.

Ciao :-)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dongsheng Cai added a comment - 22/Apr/08 11:58 AM
OK, I will fix it "gradually" this time

Dongsheng Cai added a comment - 02/May/08 12:40 PM
Fixed in moodle 1.9 and merged into head, feel free to reopen if you find problems.

Eloy Lafuente (stronk7) added a comment - 06/May/08 07:40 AM
Verified. Closing. Peerfect!