Issue Details (XML | Word | Printable)

Key: MDL-14460
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Dongsheng Cai
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Fix all ocurrences of get_context_instance(CONTEXT_SYSTEM, SITEID)

Created: 21/Apr/08 10:46 PM   Updated: 06/May/08 07:40 AM
Return to search
Component/s: Lib, Roles
Affects Version/s: 1.9
Fix Version/s: 1.9.1

Database: Any
Participants: Dongsheng Cai and Eloy Lafuente (stronk7)
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 02/May/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
In Moodle code there are a lot of calls of this type:

get_context_instance(CONTEXT_SYSTEM, SITEID)

And, when requesting for CONTEXT_SYSTEM we don't need to specify SITEID any more.

So, all the sentences above should be changed to:

get_context_instance(CONTEXT_SYSTEM)

There are aprox. 130 changes to perform, distributed along aprox. 90 files. I would suggest to do the change progressively, fixing 3-4 files each day, both in 19_STABLE and HEAD.

Ciao :-)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Dongsheng Cai added a comment - 22/Apr/08 11:58 AM
OK, I will fix it "gradually" this time

Dongsheng Cai made changes - 22/Apr/08 02:03 PM
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Dongsheng Cai committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 22/Apr/08 02:08 PM
MDL-14460, fix get_context_instance, see tracker
MODIFY calendar/view.php   Rev. 1.95.2.7    (+2 -2 lines)
MODIFY calendar/lib.php   Rev. 1.206.2.12    (+3 -3 lines)
Dongsheng Cai committed 4 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 22/Apr/08 02:16 PM
MDL-14460, fix get_context_instance, see tracker
MODIFY userpix/index.php   Rev. 1.9.2.2    (+2 -2 lines)
MODIFY mnet/testclient.php   Rev. 1.2.2.3    (+2 -2 lines)
MODIFY user/profile/lib.php   Rev. 1.23.2.3    (+5 -5 lines)
MODIFY userpix/upgrade.php   Rev. 1.5.2.1    (+2 -2 lines)
Dongsheng Cai committed 6 files to 'Moodle CVS' - 22/Apr/08 02:24 PM
MDL-14460, fix get_context_instance, merged from MOODLE_19_STABLE, see tracker.
MODIFY userpix/upgrade.php   Rev. 1.7    (+2 -2 lines)
MODIFY userpix/index.php   Rev. 1.12    (+2 -2 lines)
MODIFY mnet/testclient.php   Rev. 1.5    (+2 -2 lines)
MODIFY calendar/lib.php   Rev. 1.219    (+3 -3 lines)
MODIFY user/profile/lib.php   Rev. 1.27    (+5 -5 lines)
MODIFY calendar/view.php   Rev. 1.101    (+2 -2 lines)
Dongsheng Cai committed 6 files to 'Moodle CVS' - 23/Apr/08 04:07 PM
MDL-14460, fix get_context_instance, see tracker
MODIFY course/import/activities/index.php   Rev. 1.11    (+1 -1 lines)
MODIFY course/report/stats/lib.php   Rev. 1.8    (+1 -1 lines)
MODIFY course/report/log/lib.php   Rev. 1.23    (+3 -3 lines)
MODIFY filter/tex/filter.php   Rev. 1.21    (+1 -1 lines)
MODIFY filter/algebra/filter.php   Rev. 1.25    (+1 -1 lines)
MODIFY course/import/activities/mod.php   Rev. 1.10    (+2 -2 lines)
Dongsheng Cai committed 6 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 23/Apr/08 04:11 PM
MDL-14460, fix get_context_instance, see tracker
MODIFY course/import/activities/mod.php   Rev. 1.9.2.1    (+2 -2 lines)
MODIFY course/report/stats/lib.php   Rev. 1.6.6.2    (+1 -1 lines)
MODIFY filter/tex/filter.php   Rev. 1.18.4.2    (+1 -1 lines)
MODIFY course/import/activities/index.php   Rev. 1.9.2.1    (+1 -1 lines)
MODIFY filter/algebra/filter.php   Rev. 1.23.2.2    (+1 -1 lines)
MODIFY course/report/log/lib.php   Rev. 1.22.2.1    (+3 -3 lines)
Dongsheng Cai committed 5 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 24/Apr/08 04:35 PM
MDL-14460, fix get_context_instance
MODIFY course/category.php   Rev. 1.119.2.7    (+3 -3 lines)
MODIFY course/editcategory.php   Rev. 1.3.2.4    (+1 -1 lines)
MODIFY course/lib.php   Rev. 1.538.2.36    (+4 -4 lines)
MODIFY course/search.php   Rev. 1.49.2.2    (+5 -5 lines)
MODIFY course/pending.php   Rev. 1.11.2.3    (+2 -2 lines)
Dongsheng Cai committed 5 files to 'Moodle CVS' - 24/Apr/08 04:39 PM
MDL-14460, fix get_context_instance, merged from MOODLE_19_STABLE
MODIFY course/pending.php   Rev. 1.15    (+1 -1 lines)
MODIFY course/lib.php   Rev. 1.581    (+4 -4 lines)
MODIFY course/category.php   Rev. 1.127    (+3 -3 lines)
MODIFY course/editcategory.php   Rev. 1.8    (+1 -1 lines)
MODIFY course/search.php   Rev. 1.52    (+5 -5 lines)
Dongsheng Cai committed 2 files to 'Moodle CVS' - 26/Apr/08 07:06 PM
MDL-14460, fix get_context_instance, see tracker
MODIFY enrol/manual/enrol.php   Rev. 1.32    (+3 -3 lines)
MODIFY enrol/imsenterprise/importnow.php   Rev. 1.7    (+1 -1 lines)
Dongsheng Cai committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 26/Apr/08 07:07 PM
MDL-14460, fix get_context_instance, see tracker
MODIFY enrol/manual/enrol.php   Rev. 1.25.2.6    (+3 -3 lines)
MODIFY enrol/imsenterprise/importnow.php   Rev. 1.6.2.1    (+1 -1 lines)
Dongsheng Cai committed 5 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 30/Apr/08 12:45 PM
"MDL-14460,fix get_context_instance"
MODIFY blog/index.php   Rev. 1.35.2.5    (+2 -2 lines)
MODIFY calendar/lib.php   Rev. 1.206.2.13    (+2 -2 lines)
MODIFY blog/edit.php   Rev. 1.49.2.11    (+2 -2 lines)
MODIFY blog/preferences.php   Rev. 1.18.2.1    (+2 -2 lines)
MODIFY blog/lib.php   Rev. 1.80.2.12    (+6 -6 lines)
Dongsheng Cai committed 5 files to 'Moodle CVS' - 30/Apr/08 12:46 PM
"MDL-14460,fix get_context_instance, merged from MOODLE_19_STABLE"
MODIFY blog/preferences.php   Rev. 1.21    (+2 -2 lines)
MODIFY blog/index.php   Rev. 1.41    (+2 -2 lines)
MODIFY blog/edit.php   Rev. 1.62    (+2 -2 lines)
MODIFY blog/lib.php   Rev. 1.92    (+6 -6 lines)
MODIFY calendar/lib.php   Rev. 1.220    (+1 -1 lines)
Dongsheng Cai committed 8 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 01/May/08 02:02 PM
"MDL-14460, fix all get_context_instance"
MODIFY lib/db/upgrade.php   Rev. 1.154.2.30    (+2 -2 lines)
MODIFY lib/db/Attic/mysql.php   Rev. 1.256.2.2    (+2 -2 lines)
MODIFY lib/datalib.php   Rev. 1.439.2.25    (+6 -6 lines)
MODIFY lib/deprecatedlib.php   Rev. 1.41.2.7    (+9 -9 lines)
MODIFY my/Attic/pagelib.php   Rev. 1.11.2.2    (+3 -3 lines)
MODIFY lib/weblib.php   Rev. 1.970.2.81    (+6 -6 lines)
MODIFY lib/db/Attic/postgres7.php   Rev. 1.237.2.2    (+2 -2 lines)
MODIFY lib/statslib.php   Rev. 1.54.6.9    (+2 -2 lines)
Dongsheng Cai committed 8 files to 'Moodle CVS' - 01/May/08 02:07 PM
"MDL-14460, fix get_context_instance, merged from MOODLE_19_STABLE"
MODIFY lib/db/Attic/mysql.php   Rev. 1.258    (+2 -2 lines)
MODIFY lib/weblib.php   Rev. 1.1060    (+6 -6 lines)
MODIFY lib/db/upgrade.php   Rev. 1.191    (+2 -2 lines)
MODIFY my/Attic/pagelib.php   Rev. 1.13    (+3 -3 lines)
MODIFY lib/deprecatedlib.php   Rev. 1.50    (+9 -9 lines)
MODIFY lib/db/Attic/postgres7.php   Rev. 1.239    (+2 -2 lines)
MODIFY lib/datalib.php   Rev. 1.464    (+6 -6 lines)
MODIFY lib/statslib.php   Rev. 1.63    (+2 -2 lines)
Dongsheng Cai committed 49 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 02/May/08 12:07 PM
"MDL-14460, fix all the other get_context_instance,(use sed replace them), see tracker"
MODIFY admin/delete.php   Rev. 1.13.4.2    (+2 -2 lines)
MODIFY mod/hotpot/report.php   Rev. 1.38.2.10    (+2 -2 lines)
MODIFY admin/lang.php   Rev. 1.106.2.7    (+2 -2 lines)
MODIFY theme/preview.php   Rev. 1.6.2.1    (+2 -2 lines)
MODIFY theme/chameleon/ui/css.php   Rev. 1.7.4.1    (+1 -1 lines)
MODIFY admin/report/simpletest/Attic/index.php   Rev. 1.11.4.1    (+1 -1 lines)
MODIFY admin/index.php   Rev. 1.286.2.19    (+2 -2 lines)
MODIFY mod/glossary/lib.php   Rev. 1.193.2.12    (+4 -4 lines)
MODIFY admin/uploadpicture.php   Rev. 1.1.2.2    (+2 -2 lines)
MODIFY blocks/rss_client/Attic/block_rss_client_action.php   Rev. 1.54.2.5    (+3 -3 lines)
MODIFY admin/roles/Attic/allowoverride.php   Rev. 1.13.2.1    (+1 -1 lines)
MODIFY backup/restore_execute.html   Rev. 1.62.4.2    (+2 -2 lines)
MODIFY enrol/database/config.html   Rev. 1.13.2.3    (+1 -1 lines)
MODIFY message/discussion.php   Rev. 1.15.2.3    (+2 -2 lines)
MODIFY mod/hotpot/show.php   Rev. 1.15.2.1    (+2 -2 lines)
MODIFY auth/mnet/auth.php   Rev. 1.27.2.6    (+2 -2 lines)
MODIFY message/send.php   Rev. 1.22.2.3    (+2 -2 lines)
MODIFY mod/resource/type/ims/Attic/repository_deploy.php   Rev. 1.7.2.2    (+2 -2 lines)
MODIFY message/history.php   Rev. 1.14.4.2    (+2 -2 lines)
MODIFY backup/backuplib.php   Rev. 1.179.2.27    (+2 -2 lines)
MODIFY backup/restore_precheck.html   Rev. 1.18.10.2    (+2 -2 lines)
MODIFY admin/innodb.php   Rev. 1.8.4.1    (+1 -1 lines)
MODIFY blocks/blog_tags/block_blog_tags.php   Rev. 1.28.2.6    (+2 -2 lines)
MODIFY mod/resource/type/ims/Attic/finder.php   Rev. 1.6.2.2    (+2 -2 lines)
MODIFY mod/glossary/mod_form.php   Rev. 1.20.2.2    (+1 -1 lines)
MODIFY backup/try.php   Rev. 1.8.4.1    (+2 -2 lines)
MODIFY admin/register.php   Rev. 1.25.2.2    (+2 -2 lines)
MODIFY admin/xmldb/index.php   Rev. 1.9.2.1    (+2 -2 lines)
MODIFY backup/restorelib.php   Rev. 1.283.2.39    (+3 -3 lines)
MODIFY admin/Attic/pagelib.php   Rev. 1.23.2.2    (+2 -2 lines)
MODIFY blocks/blog_menu/block_blog_menu.php   Rev. 1.16.2.2    (+2 -2 lines)
MODIFY backup/restore_check.html   Rev. 1.48.2.6    (+2 -2 lines)
MODIFY message/search.html   Rev. 1.13.4.1    (+1 -1 lines)
MODIFY backup/log.php   Rev. 1.15.2.1    (+2 -2 lines)
MODIFY admin/report/backups/index.php   Rev. 1.2.2.2    (+2 -2 lines)
MODIFY auth/shibboleth/index.php   Rev. 1.15.2.3    (+2 -2 lines)
MODIFY backup/backup_execute.html   Rev. 1.48.4.1    (+2 -2 lines)
MODIFY backup/backup_check.html   Rev. 1.35.2.4    (+2 -2 lines)
MODIFY admin/report/courseoverview/index.php   Rev. 1.16.4.3    (+1 -1 lines)
MODIFY mod/hotpot/index.php   Rev. 1.26.2.5    (+4 -4 lines)
MODIFY theme/chameleon/ui/chameleon.php   Rev. 1.7.2.1    (+1 -1 lines)
MODIFY backup/restore.php   Rev. 1.44.2.3    (+3 -3 lines)
MODIFY admin/dbperformance.php   Rev. 1.9.2.1    (+2 -2 lines)
MODIFY admin/timezone.php   Rev. 1.8.2.1    (+2 -2 lines)
MODIFY mod/hotpot/mod_form.php   Rev. 1.2.2.3    (+2 -2 lines)
MODIFY admin/Attic/stickyblocks.php   Rev. 1.18.2.2    (+2 -2 lines)
MODIFY admin/roles/Attic/allowassign.php   Rev. 1.14.2.1    (+1 -1 lines)
MODIFY admin/health.php   Rev. 1.17.4.1    (+2 -2 lines)
MODIFY enrol/imsenterprise/config.html   Rev. 1.8.2.1    (+1 -1 lines)
Dongsheng Cai committed 49 files to 'Moodle CVS' - 02/May/08 12:37 PM
"MDL-14460, fix all the other get_context_instance, merged from MOODLE_19_STABLE"
MODIFY admin/timezone.php   Rev. 1.9    (+2 -2 lines)
MODIFY blocks/rss_client/Attic/block_rss_client_action.php   Rev. 1.62    (+3 -3 lines)
MODIFY mod/hotpot/show.php   Rev. 1.17    (+2 -2 lines)
MODIFY admin/delete.php   Rev. 1.17    (+2 -2 lines)
MODIFY admin/report/courseoverview/index.php   Rev. 1.20    (+1 -1 lines)
MODIFY enrol/imsenterprise/config.html   Rev. 1.9    (+1 -1 lines)
MODIFY backup/backup_execute.html   Rev. 1.50    (+2 -2 lines)
MODIFY mod/hotpot/report.php   Rev. 1.46    (+2 -2 lines)
MODIFY admin/innodb.php   Rev. 1.9    (+1 -1 lines)
MODIFY mod/glossary/lib.php   Rev. 1.206    (+3 -3 lines)
MODIFY admin/Attic/pagelib.php   Rev. 1.25    (+2 -2 lines)
MODIFY mod/hotpot/mod_form.php   Rev. 1.4    (+2 -2 lines)
MODIFY message/search.html   Rev. 1.14    (+1 -1 lines)
MODIFY theme/chameleon/ui/chameleon.php   Rev. 1.8    (+1 -1 lines)
MODIFY admin/xmldb/index.php   Rev. 1.11    (+2 -2 lines)
MODIFY message/history.php   Rev. 1.17    (+2 -2 lines)
MODIFY admin/uploadpicture.php   Rev. 1.5    (+2 -2 lines)
MODIFY message/send.php   Rev. 1.26    (+1 -1 lines)
MODIFY backup/log.php   Rev. 1.16    (+1 -1 lines)
MODIFY admin/lang.php   Rev. 1.116    (+2 -2 lines)
MODIFY admin/dbperformance.php   Rev. 1.10    (+2 -2 lines)
MODIFY message/discussion.php   Rev. 1.19    (+2 -2 lines)
MODIFY backup/restorelib.php   Rev. 1.327    (+3 -3 lines)
MODIFY mod/resource/type/ims/Attic/finder.php   Rev. 1.8    (+2 -2 lines)
MODIFY blocks/blog_tags/block_blog_tags.php   Rev. 1.34    (+2 -2 lines)
MODIFY admin/report/simpletest/Attic/index.php   Rev. 1.12    (+1 -1 lines)
MODIFY backup/restore_precheck.html   Rev. 1.21    (+2 -2 lines)
MODIFY admin/register.php   Rev. 1.29    (+2 -2 lines)
MODIFY backup/restore.php   Rev. 1.49    (+3 -3 lines)
MODIFY mod/glossary/mod_form.php   Rev. 1.22    (+1 -1 lines)
MODIFY enrol/database/config.html   Rev. 1.16    (+1 -1 lines)
MODIFY backup/restore_check.html   Rev. 1.55    (+2 -2 lines)
MODIFY auth/shibboleth/index.php   Rev. 1.18    (+1 -1 lines)
MODIFY backup/restore_execute.html   Rev. 1.65    (+2 -2 lines)
MODIFY admin/index.php   Rev. 1.310    (+1 -1 lines)
MODIFY backup/try.php   Rev. 1.11    (+2 -2 lines)
MODIFY admin/report/backups/index.php   Rev. 1.5    (+2 -2 lines)
MODIFY admin/health.php   Rev. 1.18    (+2 -2 lines)
MODIFY auth/mnet/auth.php   Rev. 1.34    (+2 -2 lines)
MODIFY backup/backuplib.php   Rev. 1.207    (+2 -2 lines)
MODIFY blocks/blog_menu/block_blog_menu.php   Rev. 1.18    (+2 -2 lines)
MODIFY theme/chameleon/ui/css.php   Rev. 1.9    (+1 -1 lines)
MODIFY backup/backup_check.html   Rev. 1.39    (+2 -2 lines)
MODIFY mod/resource/type/ims/Attic/repository_deploy.php   Rev. 1.9    (+2 -2 lines)
MODIFY admin/roles/Attic/allowoverride.php   Rev. 1.14    (+1 -1 lines)
MODIFY admin/Attic/stickyblocks.php   Rev. 1.20    (+2 -2 lines)
MODIFY mod/hotpot/index.php   Rev. 1.30    (+4 -4 lines)
MODIFY admin/roles/Attic/allowassign.php   Rev. 1.15    (+1 -1 lines)
MODIFY theme/preview.php   Rev. 1.8    (+2 -2 lines)
[ Permalink | « Hide ]
Dongsheng Cai added a comment - 02/May/08 12:40 PM
Fixed in moodle 1.9 and merged into head, feel free to reopen if you find problems.

Dongsheng Cai made changes - 02/May/08 12:40 PM
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
QA Assignee stronk7
[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 06/May/08 07:40 AM
Verified. Closing. Peerfect!

Eloy Lafuente (stronk7) made changes - 06/May/08 07:40 AM
Status Resolved [ 5 ] Closed [ 6 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators