Details
Improvement
Minor
Description
At the moment when a user opens a piece of content there is a 2 second delay in the loadsco.php page to allow API's etc to start, however there is no notification of this to the user so they may repeatedly click to launch course.
I suggest an enhancement to the .mod/scorm/loadsco.php to include a message and countdown timer.
Change the HTML at the end of the page to this:
<html>
<head>
<title>LoadSCO</title>
<script type="text/javascript">
function doredirect() {
var e = document.getElementById("COUNTDOWN");
var cSeconds = parseInt(e.innerHTML);
var timer = setInterval(function()
{
if( cSeconds )
else
{ clearInterval(timer); document.body.innerHTML = "Redirecting...."; location = "<?php echo $result ?>"; } }, 1000);
}
//<![CDATA[
//setTimeout('document.location = "<?php echo $result ?>";',<?php echo $delayseconds ?>000);
//]]>
</script>
<noscript>
<meta http-equiv="refresh" content="<?php echo $delayseconds ?>;url=<?php echo $result ?>" />
</noscript>
</head>
<body onload="doredirect();">
<p>You will be automatically redirected to the content in <span id="COUNTDOWN"><?php echo $delayseconds ?></span> second(s).<p>
</body>
</html>
Will provide messaging and for JavaScript enabled browsers it will actually countdown the time.
Attachments
Issue Links
| This issue will be resolved by: | ||||
| MDL-16060 | SCORM Activity Redirect Failure |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Hi Piers,
you don't need 2 lang strings, as you can pass a var into the get_string function - see:
$string['attemptsx'] = '$a attempts';
$string['missing_tag'] = 'Missing tag $a->tag';
in scorm.php for examples.
Dan
Dan closing. - looks good to me - thanks Piers.
Ashley - have you actually tested this patch? - I don't see how making this an optional feature is very useful. - or how the interface could be confusing or unecessary. IMO adding this as another configurable option just adds another config options to the scorm settings - which makes a very busy config interface and could cause more confusion for users (even if added as an advanced option)
you're welcome to create a new tracker item for it, but it wont be something we are likely to spend much time on.
thanks,
Dan
Dan resolving this issue again - MH and I don't think this patch caused the issue. Piers is looking into it.
Dan
Dan Ho guys,
I just have received this @ Github (about his problem reapearing)
https://github.com/moodle/moodle/pull/24
For your consideration...ciao
patch file
MDL-14492-head.patch, completes the changes that have been committed to head, providing the translatable language element for the user loading delay notification.Cheers,
Piers Harding.
MDL-14492-head.patch, completes the changes that have been committed to head, providing the translatable language element for the user loading delay notification. Cheers, Piers Harding.