Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Won't Fix
-
Affects Version/s: 1.7.4, 1.8.5, 1.9
-
Fix Version/s: 1.9.10
-
Component/s: Database activity module, Forum
-
Labels:None
-
Affected Branches:MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
-
Fixed Branches:MOODLE_19_STABLE
Description
Both modules (and maybe some others) convert some 1.6 settings into role overrides during upgrade or restore from 1.6 to a higher version. During this process, the list of legacy teacher roles is used. But, only moodle/legacy:teacher is used at the moment, while the roles with moodle/legacy:editingteacher should be used as well.
I have not tested, but reading the code, the capabilities are set to non-editing teachers only.
Patch attached. It adds editing teachers into the $teacherroles. The casting is there because get_roles_with_capability() may return "false" and PHP can't concatenate boolean with array.