Issue Details (XML | Word | Printable)

Key: MDL-14539
Type: Improvement Improvement
Status: Open Open
Priority: Major Major
Assignee: Martin Dougiamas
Reporter: Darryl Pogue
Votes: 4
Watchers: 4
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Replace table layout with div

Created: 24/Apr/08 09:57 AM   Updated: 03/Feb/09 06:48 PM
Return to search
Component/s: Accessibility, Blocks, Forms Library, General, Themes
Affects Version/s: 1.9.1, 2.0
Fix Version/s: 2.0

Issue Links:
Dependency
 

URL: http://www.thomashaney.ca/
Participants: Darryl Pogue, Eloy Lafuente (stronk7), Martin Dougiamas and Tim Hunt
Security Level: None
Affected Branches: MOODLE_19_STABLE, MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Currently Moodle uses tables to generate the page layout. While they do appear to work, tables are not intended for page layout, and divs offer more flexibility and customization with the evolving web standards.

The proposed solution is to replace the layout table with floating divs.
A container div is required, with margins on both sides set to the block width (these margins can be optional based on whether there are blocks on the page or not). The left column would be stored as a floating div, followed by the right column, followed by the actual content for the centre.

This system has already been tested with 1.9 on our production site: http://www.thomashaney.ca/

The main issues are that it would require a rewrite of many themes. With that in mind, it would be best to mark it for 2.0 rather than 1.9.x so as to not break existing themes.

I can provide a patch for the standard theme .css files and the index.php as an example.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 26/Apr/08 06:19 AM
Hi Darryl,

thanks a lot for sharing your experiences here. I think there is one ongoing task about replacing table layouts, in fact, since some weeks ago, the main course pages are 100% free from "layout-tables".

As you know there are a lot of parts involved (themes, core functions...) and I think it's very important to have all the info properly compiled before deciding anything.

I'm reassigning this to Martin, to let him know about your progresses while he decides about the best way to address this problem for 2.0.

Thanks and ciao


Tim Hunt added a comment - 03/Feb/09 04:49 PM
Just to note, the other bug Eloy refers to is MDL-9306. Should we close this bug as a Duplicate, and focus all work on the other bug?

Eloy Lafuente (stronk7) added a comment - 03/Feb/09 06:48 PM
+1 here