Issue Details (XML | Word | Printable)

Key: MDL-14549
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Eloy Lafuente (stronk7)
Reporter: Joseph Rézeau
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Admin cannot restore existing course adding data to it.

Created: 25/Apr/08 05:07 AM   Updated: 29/Apr/08 08:27 PM
Return to search
Component/s: Backup
Affects Version/s: 1.9, 2.0
Fix Version/s: 1.9.1

Issue Links:
Duplicate
 

Participants: Eloy Lafuente (stronk7), Helen Foster and Joseph Rézeau
Security Level: None
QA Assignee: Helen Foster
Resolved date: 25/Apr/08
Affected Branches: MOODLE_19_STABLE, MOODLE_20_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
I've just noticed this strange behavior, new to 1.9 and 2.0, whereas functionality worked OK in previous Moodle versions.
------------------
PROBLEM
------------------
Checked with 2.0, but same problem exists in 1.9 too.
Logged in as Admin, make a partial backup of any course (other than site front page), e.g. Course 101. Save backup file locally.
Go to Course 102 and go to Restore. Upload previously saved backup file to Files -> backupdata. Click on Restore.
Message: Later in this process you will have a choice of adding this backup to an existing course or creating a completely new course.
Click Continue.
# Creating temporary structures
# Deleting old data
# Copying zip file
etc.
Click Continue.
Restore to -> Select *Existing course, adding data to it*
On the next page, as per moodle 1.8, you should be offered the option to ***Choose a course*** from the list of existing courses on your moodle site... but you are not presented with this option. You only see the Restore this course now button. Click on it, the restore process seems to work:
# Using existing course
    * From: Questionnaire module Demo (QUEST_DEMO)
    * To: moodle20 (moodle20)
    * Adding data to existing
# Creating groups.
etc.

but the restored data can be found nowhere on the site!!!
------------------
DIAGNOSTIC
------------------
The problem arises from file backup/restore_check.html lines 247 & sqq. where we strangely have a commented out line, and conditions which are never met for the display of the "choosecourse" message...

------------------
SOLUTION
------------------
I do not understand enough of the workings of the restore functions to suggest a solution but I do hope one will be found, and I am really surprised that this bug has gone un-noticed (in 1.9) so far..

Joseph

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 25/Apr/08 05:47 AM
Fixed typo causing restore to existing courses not to work. MDL-14549
MODIFY backup/restore_check.html   Rev. 1.48.2.5    (+1 -1 lines)
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 25/Apr/08 05:49 AM
Fixed typo causing restore to existing courses not to work. MDL-14549 ; merged from 19_STABLE
MODIFY backup/restore_check.html   Rev. 1.54    (+2 -2 lines)