does this:
$userlist = get_user_directories();

then for each $userlist does:

$data = count_records("backup_ids","backup_code",$preferences->backup_unique_code, "table_name","user", "old_id",$userid)

so if 3000 users with directories = 3000 queries .... if running cron based backups... that's a whole lot of db queries, when it might be able to get away with 1 query!

Dan

some comments about your two points:

1) About user_files_check_backup(). I really think we could skip it safely, after all it's not used, as you say, by backup_copy_user_files () so we'll save a least 2*user queries. Or we can, alternatively, if want to continue giving feedback... do something like:

• Iterate over all the "user" records in backup_ids (recordset).
• For each user in that table... check, with make_user_directory($userid, true) if the corresponding dir exists and count++
• Return the count.

2) About the backup_copy_user_files () I think we should "revert" the process so, instead of doing the get_user_directories() call and then check for each user with the count_records() we should:

• Iterate over all the "user" records in backup_ids (recordset).
• For each user in that table... check, with make_user_directory($userid, true) if the corresponding dir exists and copy it to backup area.

Good research! Ciao

we could do that with user_files_check_backup - but it doesn't count the number of "files" that will be saved - just the number of users with files that will be saved..... - so IMO we need to create a new lang that says "Users with files" and display that instead of "files" beside the number.

have attached a patch that does this for user_files_check_backup (but we will need to add the lang somewhere...)

Dan

Dan

I've take a look to your patches. They look good but here there are some comments:

1) You've used set_records_select_menu(), I would start using recordset functions from now - get_recordset_select() or get_recordset_sql() - to prevent BIG numbers of records to eat memory. See rs_fetch_next_record() php docs about how to use them and iterate properly.

2) You've deleted these lines in the user_files_check_backup() function:

//Do some output
backup_flush(30);

I'd keep them there because they use to prevent browser timeouts by continuously flushing data to client.

3) I'd add the 2 lines above in backup_copy_user_files() too. It's missing them.

The rest looks perfect. Thanks!

Ciao

OU are going to test the patch for me - I'll wait to hear back from them before I commit anything.

Dan

thanks,

Dan

Dan

Dan