Details
Bug
Closed
Minor
Description
the function user_files_check_backup() is used by the backup_check and backup_scheduled.php files to display how many user files will be backed up.
It is looking at the old dataroot. "/users" directory which from what I understand from MDL-8605 is no longer used to store files (and in a fresh 1.9 install it's unlikely that the folder will actually be created!
This displays bad information to the user when running a manual backup - eg it will always display 0 user files to be backed up for fresh moodle 1.9+ installs.
The actual Backup_execute doesn't use the function so it doesn't affect the actual backup except that it can run some really badly performing code taking up memory/processes. - if that directory contains data from an old moodle version that hasn't been deleted, then it can result in thousands of useless db queries (see MDL-7899)
will write a patch to get this information from the new "user" directory and submit for review.
Dan
Attachments
Issue Links
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
hmmm... the function backup_copy_user_files doesn't look great either - it does 1 db query for every user that has a user_directory (potentially every user on the site) for each backup. - not good!
does this:
$userlist = get_user_directories();
then for each $userlist does:
$data = count_records("backup_ids","backup_code",$preferences->backup_unique_code, "table_name","user", "old_id",$userid)
so if 3000 users with directories = 3000 queries .... if running cron based backups... that's a whole lot of db queries, when it might be able to get away with 1 query!
Dan
Dan Hi Dan,
some comments about your two points:
1) About user_files_check_backup(). I really think we could skip it safely, after all it's not used, as you say, by backup_copy_user_files () so we'll save a least 2*user queries. Or we can, alternatively, if want to continue giving feedback... do something like:
- Iterate over all the "user" records in backup_ids (recordset).
- For each user in that table... check, with make_user_directory($userid, true) if the corresponding dir exists and count++
- Return the count.
2) About the backup_copy_user_files () I think we should "revert" the process so, instead of doing the get_user_directories() call and then check for each user with the count_records() we should:
- Iterate over all the "user" records in backup_ids (recordset).
- For each user in that table... check, with make_user_directory($userid, true) if the corresponding dir exists and copy it to backup area.
Good research! Ciao
- Iterate over all the "user" records in backup_ids (recordset).
- For each user in that table... check, with make_user_directory($userid, true) if the corresponding dir exists and count++
- Return the count.
- Iterate over all the "user" records in backup_ids (recordset).
- For each user in that table... check, with make_user_directory($userid, true) if the corresponding dir exists and copy it to backup area.
Hi Eloy,
we could do that with user_files_check_backup - but it doesn't count the number of "files" that will be saved - just the number of users with files that will be saved..... - so IMO we need to create a new lang that says "Users with files" and display that instead of "files" beside the number.
have attached a patch that does this for user_files_check_backup (but we will need to add the lang somewhere...)
Dan
Dan here's my first go at the backup_copy_user_files function - I haven't tested these changes as much as I'd like yet - will do that tomorrow before I commit anything to HEAD
Dan
Dan Hi Dan,
I've take a look to your patches. They look good 
but here there are some comments:
1) You've used set_records_select_menu(), I would start using recordset functions from now - get_recordset_select() or get_recordset_sql() - to prevent BIG numbers of records to eat memory. See rs_fetch_next_record() php docs about how to use them and iterate properly.
2) You've deleted these lines in the user_files_check_backup() function:
//Do some output
backup_flush(30);
I'd keep them there because they use to prevent browser timeouts by continuously flushing data to client.
3) I'd add the 2 lines above in backup_copy_user_files() too. It's missing them.
The rest looks perfect. Thanks!
Ciao
but here there are some comments:
1) You've used set_records_select_menu(), I would start using recordset functions from now - get_recordset_select() or get_recordset_sql() - to prevent BIG numbers of records to eat memory. See rs_fetch_next_record() php docs about how to use them and iterate properly.
2) You've deleted these lines in the user_files_check_backup() function:
//Do some output
backup_flush(30);
I'd keep them there because they use to prevent browser timeouts by continuously flushing data to client.
3) I'd add the 2 lines above in backup_copy_user_files() too. It's missing them.
The rest looks perfect. Thanks!
Ciao thanks Eloy - good to know about the recordset stuff! - didn't think the backup_flush would be needed in files_check_backup() anymore as it should be quite fast....but considering the backup does take a bit of time it makes sense to add it back in (and add it to copy_user_files() as well.
OU are going to test the patch for me - I'll wait to hear back from them before I commit anything.
Dan
Dan attaching fullpatch file - seems to test ok in my install!
thanks,
Dan
Dan patch now in HEAD - would prefer some "peer-review" before I commit to 1.9Stable
Dan
Dan 
...at least I don't "think" the actual backup process uses that function, as I seem to get user files in my 1.9 backups.... need to investigate that further.... potentially a problem with the scheduled backup as they use different functions to execute the backup....