Moodle

Mouse-over of Tags gives the wrong count.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.1
  • Component/s: Tags
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Sometimes the count is correct, sometimes it isn't.

Perhaps, the number showing is how many people have added the tag, but doesn't lower the number if a student removes the tag from his profile. (Just a guess.)

If this is difficult to fix, then perhaps removing the "mouse-over" feature would be the easy solution.

Image attached.

Issue Links

This issue will be resolved by:
MDL-13424 Make a one-time upgrade path to remove old (non-official) tags that are not in use anymore Minor Closed
MDL-14544 Deleted users still appear in the tags page Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mathieu Petit-Clair added a comment -

I had a look at the code and there are two problems :

  • "related tags" tag are counted (they probably shouldn't)
  • tag instances linking to deleted users are counted (definitely a bug)
Show
Mathieu Petit-Clair added a comment - I had a look at the code and there are two problems :
  • "related tags" tag are counted (they probably shouldn't)
  • tag instances linking to deleted users are counted (definitely a bug)
Hide
Permalink
Mathieu Petit-Clair added a comment -

Charles, what's your opinion on the fact that the count includes related tags? People seem split on this, over here. I don't think they should count, but I don't have a strong opinion about this...

Show
Mathieu Petit-Clair added a comment - Charles, what's your opinion on the fact that the count includes related tags? People seem split on this, over here. I don't think they should count, but I don't have a strong opinion about this...
Hide
Permalink
Mathieu Petit-Clair added a comment -

Ok, I fixed the related tags thing: they can't be counted, it's confusing, because there is no clear difference in display between manually related tags and automatically correlated tags.

Show
Mathieu Petit-Clair added a comment - Ok, I fixed the related tags thing: they can't be counted, it's confusing, because there is no clear difference in display between manually related tags and automatically correlated tags.
Hide
Permalink
Charles Kelly added a comment -

I agree with your change. I think you made the correct decision. Keep up the good work.

Show
Charles Kelly added a comment - I agree with your change. I think you made the correct decision. Keep up the good work.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Hi Mathieu...

what if we close this and open a new one about the deleted users? I guess we'll need to add some upgrade code to clean those orphan tag instances?

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi Mathieu... what if we close this and open a new one about the deleted users? I guess we'll need to add some upgrade code to clean those orphan tag instances? Ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Aha, I guess MDL-13424 (discovered it about my previous comment) is the one about clean things in one upgrade step, isn't it? So, I'm marking this as resolved. Thanks!

Show
Eloy Lafuente (stronk7) added a comment - Aha, I guess MDL-13424 (discovered it about my previous comment) is the one about clean things in one upgrade step, isn't it? So, I'm marking this as resolved. Thanks!
Hide
Permalink
Petr Škoda (skodak) added a comment -

code reviewed, closing

Show
Petr Škoda (skodak) added a comment - code reviewed, closing

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.