Details
Bug
Closed
Description
1) OOP formats, making them pluggable (this is apart but could be good idea for 2.0)
2) OOP filters
3) Allow each filter to alter the md5key generated, via filter method. filter->hash() will return a unique string, the results for this could be something like, in this example: "censor:seecensoredwords" for users having the capability, or: "censor:" for the rest. Note that adding this info to the hash sounds nice because it automatically invalidates records when filters are changed, and that isn't happening right now.
4) Make the rest of format_text() and format_string() to work as now, but using that "custom" $md5key that contains all the particularities of the text being formatted.
This improvement will help fix this bug:
> Students at our school figured out they could swear if they put the word within a hyperlink - e.g.
> <a href='#'>SwearWord</a>
Attachments
Issue Links
| This issue has a non-specific relationship to: | ||||
| MDL-15555 | stop using span tag for nolink and lang, use the original custom moodle tags |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Some comments:
1) Look the get_context_instance(CONTEXT_SYSTEM, SITEID) as commented. 
2) I like the approach of hiding the original to all but admins, but...
3) Require MD approval and fixfor versions (I think we could run it for some time in HEAD in our servers and then backport to 1.9 and 1.8).
2) I like the approach of hiding the original to all but admins, but...
3) Require MD approval and fixfor versions (I think we could run it for some time in HEAD in our servers and then backport to 1.9 and 1.8). Well,
perhaps this is a matter, for 2.0 to do something like this (to bring this and similar issues fixed for ever):
1) OOP formats, making them pluggable (this is apart but could be good idea for 2.0)
2) OOP filters
3) Allow each filter to alter the md5key generated, via filter method. filter->gethash(), the results for this could be something like, in this example: "censor:seecensoredwords" for users having the capability, or: "censor:" for the rest. Note that adding this info to the hash sounds nice because it automatically invalidates records when filters are changed, and that isn't happening right now.
4) Make the rest of format_text() and format_string() to work as now, but using that "custom" $md5key that contains all the particularities of the text being formatted.
Note that right now, for example, we are adding manually the current_language() to the cache, because of the lang filter. This will fit in the schema commented above automatically.
Guy, I'm not really sure if the "intermediate" cache (before filtering) that you comment is really a good idea or no. Perhaps you can try to perform some basic implementation and measure differences? I guess we'll lost more time reading and witting it than the time needed to format the texts, but... who knows.
Dong, how do you see the proposal? IMO could be a nice thing to change (one more) for Moodle 2.0. Comment it with MD...ciao 
Sounds good, I will start to work on this issue after 1.9.1 release
Alternatively, just admit that blanket censorship of people's words through technical means is unworkable in the long run and to just put more effort into doing it socially. Set up some rules of conduct and introduce penalties for breaking them. Reducing student grades is an obvious one but I'm sure you can get creative.
But I do like Eloy's idea in general of letting all filters modify the hash
grrr. sorry by the delay. I'll review this tomorrow (when I receive this mail). Ciao
Put a patch here for further discuss.
1. isteacher is a deprecated functions, so in my patch, I use has_capability('moodle/site:doanything', $context) instead
2. I use return filter_phrases($text, $words, true); instead of a <dummytag>, cause your students might swear using <dummytag>swear<dummytag>
Please review