Moodle

issues with local/settings.php when not

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.5
  • Component/s: Administration
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

we have defined some new settings in local/settings.php and when those settings are not part of an admin_externalpage but posting back to admin/settings.php, the settings save fine, but the page setup fails with these errors:

Notice: Trying to get property of non-object in /moodle-r2/admin/pagelib.php on line 41

Warning: array_reverse() [function.array-reverse]: The argument should be an array in /moodle-r2/admin/pagelib.php on line 41

Warning: Invalid argument supplied for foreach() in /www/moodle-r2/admin/pagelib.php on line 119

Warning: implode() [function.implode]: Bad arguments. in /www/moodle-r2/admin/pagelib.php on line 124

Notice: Undefined offset: -1 in /www/moodle-r2/blocks/admin_tree/block_admin_tree.php on line 80

Notice: Trying to get property of non-object in /www/moodle-r2/admin/settings.php on line 140

Fatal error: Call to a member function output_html() on a non-object in /www/moodle-r2/admin/settings.php on line 142

Dan

Issue Links

Activity

Hide
Penny Leach added a comment -

Man that was a NIGHTMARE to debug. I've fixed it this morning in 1.9 (not present in HEAD) - will come in next time you merge. Please confirm & close.

Show
Penny Leach added a comment - Man that was a NIGHTMARE to debug. I've fixed it this morning in 1.9 (not present in HEAD) - will come in next time you merge. Please confirm & close.
Hide
Dan Marsden added a comment -

looks great! - thanks Heaps!!!!!!

Show
Dan Marsden added a comment - looks great! - thanks Heaps!!!!!!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: