Moodle

like mdl-13886 styles are broken

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.10
  • Component/s: Libraries
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

we use css in assignments, quizes ... like:
<div style="color: rgb(0, 51, 102); background-color: rgb(255, 248, 178); height: 100px; font-size: 150%;"> <img width="133" .......

nearly all styles were broken after update to 1.9.
Could you please expand the list of allowed css tags in weblib.php ALLOWED_PROTOCOLS. Tags that are often used are:

'background-color', 'text-decoration', 'border-left', 'border-top',
'border-bottom', 'border-right', 'vertical-align', 'margin-right', 'margin-left', 'line-height', ......

after I found and added these for our site every thing is o.k. Could be that also other sites are using css-styles.

by katja

Issue Links

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

The list is interminable... Assigning this to Petr, for his consideration.

Show
Eloy Lafuente (stronk7) added a comment - The list is interminable... Assigning this to Petr, for his consideration.
Hide
Petr Škoda (skodak) added a comment -

More CSS styles are whitelisted now in KSES. Thanks for the report.

Petr Skoda

Show
Petr Škoda (skodak) added a comment - More CSS styles are whitelisted now in KSES. Thanks for the report. Petr Skoda

People

Vote (3)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: