|
[
Permalink
| « Hide
]
Howard Miller added a comment - 30/Apr/08 10:39 PM
Should now be able to establish link with peer through a HTTP proxy. Mostly uses existing (hence tested hopefully) functions and code snippets.
Howard Miller made changes - 30/Apr/08 10:39 PM
Hi Howard,
I am just wondering if this works? My vague memory was that thought that the mnet handshaking would check that the incoming request comes from the same ip address as dns resolves the host to. So using a proxy would cause that check to fail? (But also, if you are using a proxy and can't get out directly, how does the mnet peer verify who you are and chat back to you?) A very good point that I had not considered. However, it works perfectly from behind my Squid firewall. I can now connect to either Moodle or Mahara and I couldn't before. I'll have a bit more of think about it, and see if I can justify why it works though
 Just checking - both Moodle sites report the IP address of the peer machine as it's actual IP address. The presence of the proxy doesn't seem to make any difference. I haven't checked the exact operation, but I guess that if the xmlrpc packet simply contains the originating host name then the IP still resolves correctly and it all works. As long as the path to "get back" is established (proxy or no) then you have a connection. I suppose this means that it doesn't check what the IP was that the request came from!
Please consider reverting this in MOODLE_19_STABLE - see
Petr Skoda made changes - 05/May/08 03:02 PM
This fix could cause problems, without resolving
Howard Miller made changes - 05/May/08 03:17 PM
thepurpleblob committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 05/May/08 04:19 PM
Changes reverted in 1.9. Will leave in HEAD and continue to resolve
Fixed in HEAD only. MNET now uses Proxy settings if specified, but you can bypass it for specified domains if you so wish.
Howard Miller made changes - 12/May/08 04:43 PM
Doesn't consider mnet/xmlrpc/client.php and server.php. This worked for me without. I wonder why.
This really needs that curl code to be put in the library, as the proxy code will be duplicated again and again.
Howard Miller made changes - 03/Jun/08 05:38 PM
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Improvement
Reopened
Major
mnet can't setup a peer when a proxy is in use.
 |
|
All content on this web site is made available under the GNU General Public License, unless otherwise stated.
