Moodle

glossary block help contains tags

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.2
  • Component/s: Blocks
  • Labels:
    None

Description

In the help for the glossary block config, the text is displayed in a popup window as follows..

<b>Last modified entry</b> will always display the entry that was last modified, and <b>Random entry</b> will choose a new one at random every time. The option <b>Next entry</b> will cycle through the entries in order. This last option is especially useful when a number of days is also chosen, allowing you to make a <i>Quote of the week</i> or a <i>Tip of the day</i> that everyone sees.

Obviously the intention is that some terms will be bolded or italicised but because the text is being passed through the url rather than as a file, its not working.

Issue Links

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Assigning to Jérôme...

I think we should:

1) Transform that call to helpbutton() to use one standard help file (lang/en_utf8/help/block_glossary_random/type.html)
2) Review if there are more uses of helpbutton() using $text contents instead og external help files. Fix all them to use standard help files.
3) add debugging message to helpbutton() in case it receive something in $text, informing it's not the recommended way.

Note that the $text option won't work properly because the text needs to be always cleaned and, when cleaned... html tags always break, so it's unusable. That's the cause I suggest to move all current uses of $text in that function to real help files usage.

Confirm with MD, plz. TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Jérôme... I think we should: 1) Transform that call to helpbutton() to use one standard help file (lang/en_utf8/help/block_glossary_random/type.html) 2) Review if there are more uses of helpbutton() using $text contents instead og external help files. Fix all them to use standard help files. 3) add debugging message to helpbutton() in case it receive something in $text, informing it's not the recommended way. Note that the $text option won't work properly because the text needs to be always cleaned and, when cleaned... html tags always break, so it's unusable. That's the cause I suggest to move all current uses of $text in that function to real help files usage. Confirm with MD, plz. TIA and ciao
Hide
Jerome Mouneyrac added a comment -

Ok I attached a patch for this case. I'll ask MD for voting, then I'll fix all other places.

Show
Jerome Mouneyrac added a comment - Ok I attached a patch for this case. I'll ask MD for voting, then I'll fix all other places.
Hide
Martin Dougiamas added a comment -

Yep looks ok to me! +1

Show
Martin Dougiamas added a comment - Yep looks ok to me! +1
Hide
Jerome Mouneyrac added a comment -

tested and commited on 1.9 and HEAD (excepted glossary, there were no other places to fix)

Show
Jerome Mouneyrac added a comment - tested and commited on 1.9 and HEAD (excepted glossary, there were no other places to fix)
Hide
Helen Foster added a comment -

Jenny, thanks for reporting, and Jérôme, thanks for fixing

Show
Helen Foster added a comment - Jenny, thanks for reporting, and Jérôme, thanks for fixing
Hide
Petr Škoda (skodak) added a comment -

reopening, the change in weblib.php annoys me - it throws debug messages all over the user profile, please fix it there or reconsider the debug message, thanks

Show
Petr Škoda (skodak) added a comment - reopening, the change in weblib.php annoys me - it throws debug messages all over the user profile, please fix it there or reconsider the debug message, thanks
Hide
Jerome Mouneyrac added a comment -

I fixed Edit user profil page. Tested and commit on 1.9 and HEAD

Show
Jerome Mouneyrac added a comment - I fixed Edit user profil page. Tested and commit on 1.9 and HEAD
Hide
Petr Škoda (skodak) added a comment -

big thanks!

Show
Petr Škoda (skodak) added a comment - big thanks!

Dates

  • Created:
    Updated:
    Resolved: