Issue Details (XML | Word | Printable)

Key: MDL-14635
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Jerome Mouneyrac
Reporter: Jenny Gray
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

glossary block help contains tags

Created: 01/May/08 06:35 PM   Updated: 09/Jul/08 06:44 PM
Return to search
Component/s: Blocks
Affects Version/s: 1.9
Fix Version/s: 1.9.2

File Attachments: 1. Text File MDL-14635_edituserprofil_fix.patch (3 kB)
2. Text File MDL-14635_patches.patch (3 kB)

Issue Links:
Relates
 

URL: http://openlearn.open.ac.uk/help.php?module=moodle&text=%3Cb%3ELast+modified+entry%3C%2Fb%3E+will+always+display+the+entry+that+was+last+modified%2C+and+%3Cb%3ERandom+entry%3C%2Fb%3E+will+choose+a+new+one+at+random+every+time.++The+option+%3Cb%3ENext
Participants: Eloy Lafuente (stronk7), Helen Foster, Jenny Gray, Jerome Mouneyrac, Martin Dougiamas and Petr Skoda
Security Level: None
QA Assignee: Helen Foster
Resolved date: 03/Jul/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
In the help for the glossary block config, the text is displayed in a popup window as follows..

<b>Last modified entry</b> will always display the entry that was last modified, and <b>Random entry</b> will choose a new one at random every time. The option <b>Next entry</b> will cycle through the entries in order. This last option is especially useful when a number of days is also chosen, allowing you to make a <i>Quote of the week</i> or a <i>Tip of the day</i> that everyone sees.

Obviously the intention is that some terms will be bolded or italicised but because the text is being passed through the url rather than as a file, its not working.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 06/May/08 09:35 AM
Assigning to Jérôme...

I think we should:

1) Transform that call to helpbutton() to use one standard help file (lang/en_utf8/help/block_glossary_random/type.html)
2) Review if there are more uses of helpbutton() using $text contents instead og external help files. Fix all them to use standard help files.
3) add debugging message to helpbutton() in case it receive something in $text, informing it's not the recommended way.

Note that the $text option won't work properly because the text needs to be always cleaned and, when cleaned... html tags always break, so it's unusable. That's the cause I suggest to move all current uses of $text in that function to real help files usage.

Confirm with MD, plz. TIA and ciao


Jerome Mouneyrac added a comment - 29/May/08 10:38 AM
Ok I attached a patch for this case. I'll ask MD for voting, then I'll fix all other places.

Martin Dougiamas added a comment - 18/Jun/08 04:52 PM
Yep looks ok to me! +1

Jerome Mouneyrac added a comment - 25/Jun/08 11:29 AM
tested and commited on 1.9 and HEAD (excepted glossary, there were no other places to fix)

Helen Foster added a comment - 01/Jul/08 11:50 PM
Jenny, thanks for reporting, and Jérôme, thanks for fixing

Petr Skoda added a comment - 03/Jul/08 07:17 AM
reopening, the change in weblib.php annoys me - it throws debug messages all over the user profile, please fix it there or reconsider the debug message, thanks

Jerome Mouneyrac added a comment - 03/Jul/08 12:24 PM
I fixed Edit user profil page. Tested and commit on 1.9 and HEAD

Petr Skoda added a comment - 09/Jul/08 06:44 PM
big thanks!