Issue Details (XML | Word | Printable)

Key: MDL-14635
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Jerome Mouneyrac
Reporter: Jenny Gray
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

glossary block help contains tags

Created: 01/May/08 06:35 PM   Updated: 09/Jul/08 06:44 PM
Return to search
Component/s: Blocks
Affects Version/s: 1.9
Fix Version/s: 1.9.2

File Attachments: 1. Text File MDL-14635_edituserprofil_fix.patch (3 kB)
2. Text File MDL-14635_patches.patch (3 kB)
Issue Links:
Relates
 

URL: http://openlearn.open.ac.uk/help.php?module=moodle&text=%3Cb%3ELast+modified+entry%3C%2Fb%3E+will+always+display+the+entry+that+was+last+modified%2C+and+%3Cb%3ERandom+entry%3C%2Fb%3E+will+choose+a+new+one+at+random+every+time.++The+option+%3Cb%3ENext
Participants: Eloy Lafuente (stronk7), Helen Foster, Jenny Gray, Jerome Mouneyrac, Martin Dougiamas and Petr Skoda
Security Level: None
QA Assignee: Helen Foster
Resolved date: 03/Jul/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
In the help for the glossary block config, the text is displayed in a popup window as follows..

<b>Last modified entry</b> will always display the entry that was last modified, and <b>Random entry</b> will choose a new one at random every time. The option <b>Next entry</b> will cycle through the entries in order. This last option is especially useful when a number of days is also chosen, allowing you to make a <i>Quote of the week</i> or a <i>Tip of the day</i> that everyone sees.

Obviously the intention is that some terms will be bolded or italicised but because the text is being passed through the url rather than as a file, its not working.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) made changes - 06/May/08 09:35 AM
Field Original Value New Value
Assignee Nobody [ nobody ] Jerome Mouneyrac [ jerome ]
[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 06/May/08 09:35 AM
Assigning to Jérôme...

I think we should:

1) Transform that call to helpbutton() to use one standard help file (lang/en_utf8/help/block_glossary_random/type.html)
2) Review if there are more uses of helpbutton() using $text contents instead og external help files. Fix all them to use standard help files.
3) add debugging message to helpbutton() in case it receive something in $text, informing it's not the recommended way.

Note that the $text option won't work properly because the text needs to be always cleaned and, when cleaned... html tags always break, so it's unusable. That's the cause I suggest to move all current uses of $text in that function to real help files usage.

Confirm with MD, plz. TIA and ciao


Eloy Lafuente (stronk7) made changes - 06/May/08 09:36 AM
Fix Version/s 1.9.1 [ 10240 ]
Martin Dougiamas made changes - 15/May/08 03:02 PM
Fix Version/s 1.9.2 [ 10280 ]
Fix Version/s 1.9.1 [ 10240 ]
[ Permalink | « Hide ]
Jerome Mouneyrac added a comment - 29/May/08 10:38 AM
Ok I attached a patch for this case. I'll ask MD for voting, then I'll fix all other places.

Jerome Mouneyrac made changes - 29/May/08 10:38 AM
Attachment MDL-14635_patches.patch [ 14110 ]
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 18/Jun/08 04:52 PM
Yep looks ok to me! +1

Jerome Mouneyrac committed 4 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 25/Jun/08 11:01 AM
MDL-14635 remove tags from glossary block help
MODIFY lang/en_utf8/block_glossary_random.php   Rev. 1.2.8.1    (+1 -2 lines)
MODIFY lang/en_utf8/help/glossary/newentry.html   Rev. 1.1.2.1    (+5 -0 lines)
MODIFY lib/weblib.php   Rev. 1.970.2.94    (+9 -2 lines)
MODIFY blocks/glossary_random/Attic/config_instance.html   Rev. 1.9.2.1    (+1 -2 lines)
Jerome Mouneyrac committed 4 files to 'Moodle CVS' - 25/Jun/08 11:26 AM
MDL-14635 remove tags from glossary block help, merged from 19
MODIFY lang/en_utf8/block_glossary_random.php   Rev. 1.3    (+1 -2 lines)
MODIFY lang/en_utf8/help/glossary/newentry.html   Rev. 1.2    (+5 -0 lines)
MODIFY blocks/glossary_random/Attic/config_instance.html   Rev. 1.10    (+1 -2 lines)
MODIFY lib/weblib.php   Rev. 1.1094    (+9 -2 lines)
[ Permalink | « Hide ]
Jerome Mouneyrac added a comment - 25/Jun/08 11:29 AM
tested and commited on 1.9 and HEAD (excepted glossary, there were no other places to fix)

Jerome Mouneyrac made changes - 25/Jun/08 11:29 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 25/Jun/08 01:23 PM
Updated a translated string for random glossary block based on lang/en_utf8 change MDL-14635.
Adding a new translated help file for random glossary block MDL-14635.
MODIFY ja_utf8/block_glossary_random.php   Rev. 1.6    (+2 -2 lines)
ADD ja_utf8/help/glossary/newentry.html   Rev. 1.1    (+0 -0 lines)
martignoni committed 1 file to 'Lang CVS' - 25/Jun/08 09:26 PM
MDL-14635 new help file added
ADD fr_utf8/help/glossary/newentry.html   Rev. 1.1    (+0 -0 lines)
[ Permalink | « Hide ]
Helen Foster added a comment - 01/Jul/08 11:50 PM
Jenny, thanks for reporting, and Jérôme, thanks for fixing

Helen Foster made changes - 01/Jul/08 11:50 PM
QA Assignee tsala
Status Resolved [ 5 ] Closed [ 6 ]
Dongsheng Cai made changes - 02/Jul/08 01:35 PM
Link This issue has been marked as being related by MDL-15500 [ MDL-15500 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 03/Jul/08 07:17 AM
reopening, the change in weblib.php annoys me - it throws debug messages all over the user profile, please fix it there or reconsider the debug message, thanks

Petr Skoda made changes - 03/Jul/08 07:17 AM
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
Jerome Mouneyrac made changes - 03/Jul/08 11:57 AM
Attachment MDL-14635_edituserprofil_fix.patch [ 14424 ]
Jerome Mouneyrac committed 3 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 03/Jul/08 12:08 PM
MDL-14635 fix for user profil help icons
MODIFY lang/en_utf8/help/newpassword.html   Rev. 1.1.2.1    (+2 -0 lines)
MODIFY lang/en_utf8/help/interestslist.html   Rev. 1.1.2.1    (+1 -0 lines)
MODIFY lang/en_utf8/help/forcepasswordchange.html   Rev. 1.1.2.1    (+1 -0 lines)
Jerome Mouneyrac committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 03/Jul/08 12:08 PM
MDL-14635 fix user profil help icons
MODIFY user/editadvanced_form.php   Rev. 1.14.2.4    (+3 -6 lines)
MODIFY user/editlib.php   Rev. 1.11.2.8    (+3 -3 lines)
Jerome Mouneyrac committed 3 files to 'Moodle CVS' - 03/Jul/08 12:10 PM
MDL-14635 fix for user profil help icons, merged from 19
MODIFY lang/en_utf8/help/interestslist.html   Rev. 1.2    (+1 -0 lines)
MODIFY lang/en_utf8/help/forcepasswordchange.html   Rev. 1.2    (+1 -0 lines)
MODIFY lang/en_utf8/help/newpassword.html   Rev. 1.2    (+2 -0 lines)
Jerome Mouneyrac committed 2 files to 'Moodle CVS' - 03/Jul/08 12:15 PM
MDL-14635 fix user profil help icons, merged from 19
MODIFY user/editadvanced_form.php   Rev. 1.19    (+3 -6 lines)
MODIFY user/editlib.php   Rev. 1.22    (+3 -3 lines)
[ Permalink | « Hide ]
Jerome Mouneyrac added a comment - 03/Jul/08 12:24 PM
I fixed Edit user profil page. Tested and commit on 1.9 and HEAD

Jerome Mouneyrac made changes - 03/Jul/08 12:24 PM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 03/Jul/08 05:15 PM
Adding transalted help files for user profil help icons MDL-14635.
Brushed up translated strings.
MODIFY ja_utf8/moodle.php   Rev. 1.300    (+2 -2 lines)
ADD ja_utf8/help/interestslist.html   Rev. 1.1    (+0 -0 lines)
ADD ja_utf8/help/forcepasswordchange.html   Rev. 1.1    (+0 -0 lines)
ADD ja_utf8/help/newpassword.html   Rev. 1.1    (+0 -0 lines)
martignoni committed 3 files to 'Lang CVS' - 08/Jul/08 04:57 AM
MDL-14635 new help files added
ADD fr_utf8/help/forcepasswordchange.html   Rev. 1.1    (+0 -0 lines)
ADD fr_utf8/help/newpassword.html   Rev. 1.1    (+0 -0 lines)
ADD fr_utf8/help/interestslist.html   Rev. 1.1    (+0 -0 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 09/Jul/08 06:44 PM
big thanks!

Petr Skoda made changes - 09/Jul/08 06:44 PM
Status Resolved [ 5 ] Closed [ 6 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators