|
Valery Fremaux made changes - 02/May/08 05:39 AM
Valery Fremaux made changes - 02/May/08 05:40 AM
Valery Fremaux made changes - 02/May/08 05:40 AM
Valery Fremaux made changes - 02/May/08 05:42 AM
[
Permalink
| « Hide
]
Valery Fremaux added a comment - 02/May/08 05:43 AM
Oups, how to remove that "blocker" link that has no sense ?
Other improvements I forgot :
all physical handlers have been revisited so they could be reused to index any attachement in any module, and not only resources. Physical handling extensino was tried with Adobe Search SDK. Although non GPL, there would be a provision for non standard SWF indexing, with sufficiant advertisment for user. Tim William might distribute this "not so free" pack with autoview. Great! Yes, please put these in HEAD so people can test (GPL-code only, other stuff might have to be separate). If it's safe, we might port back to 1.9.1.
diml committed 122 files to 'Moodle CVS' - 02/May/08 07:58 PM
diml committed 3 files to 'Moodle CVS' - 02/May/08 08:03 PM
All files commited in HEAD.
Note a particular proceeding for setup that ought to be commented in doc : When changing the list of allowed extensions (adding some extra extensions) will be created additional config keys to setup system command line, and an optional environment variable. As I did not use Ajax nor Javascript for updating interatively the form, there is a need to first save the altered extensions list, and then go back to the setup form to have the additional parameters available. This should be the case (tested on my dev 1.8.4) for SWF handling, where the lib should be added to <%%moodleroot%%>/lib as "swfconverters" subdirectory, and subsequently binded in the search setup screen using a command line such as "lib/swfconverters/windows/swf2html.exe" (Windows example - No env variable needed). Note 2 : as Adobe Search libs should not be distributed along, all references to this lib pack is given where relevant as http://www.adobe.com/licensing/developer/ Cheers.
diml committed 1 file to 'Moodle CVS' - 02/May/08 08:22 PM
diml committed 2 files to 'Moodle CVS' - 02/May/08 11:23 PM
Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 03/May/08 02:19 PM
martignoni committed 1 file to 'Lang CVS' - 04/May/08 11:22 PM
Incomplete implementation.
Need finishing query side aspects of getting third-party modules outside of core search engine. I am actually getting some stuff simpler, shooting out some useless constants. HEAD will be patched with a new review soon. I will integrate a contribution code that adds document type icon and a course reference within the result line. Result set needs to be reworked when searching with a non connected status. Many fixes where achieved, including testing many missing or mismatched local indexing strategies.
A tricky problem remains affecting search query performances : The ideal would be that we only check access on a result page. But enabling or disabling access changes the result set length itself, and thus affects page size and boundaries in the list of initial results. I'am searching now a suitable algorithm to optimize the result page construction, avoiding as far as we can testing access on unneeded material. An implementation of caching search results for browsing from page to page was kicked off by Michael Campanis, but not fully implemented so it is not operative. The actual version does not cache results so has to test back all the primary result list for each query. This is obviously time and power consuming. Caching results seems being a necessity. Another approach I'am seeking for is to calculate and transmit to browser real offsets of page boundaries, so that a page is the result of searching the next page_size valid results ahead in premary results, wherever they are. This will still not resolve the issue of calculating the effective result set size, defining how many pages we have. Cheers and some headakes foreseen. Hi, it's hard for me to understand what yo are doing and what is planned.
Can you please post diff patches here for all proposed fixes in 1.9? Hi Martin,
little time available, but here is an up to date full diff for /search Next to come is the full diff for /blocks/search The real nice thing would be to check what where Eloy's changes in HEAD (sure be few) and have both code synced unless those little changes (1.9 is MO the best code available among the branches).
Valery Fremaux made changes - 05/Sep/08 06:23 AM
The other diff as required.
All announced features are in, unless still extensively untested by now. Other coming features, such as MNET search where not put in, as being on a very early stage of development (quite complicated, in fact, because revamping many xml_rpc code...) Cheers.
Valery Fremaux made changes - 05/Sep/08 06:26 AM
Although 'Books' is classified as an 'activity' , functionally, it is a resource (as is the Lesson module, I might add).
As we can envision a site with heavy use of 'books' being able to search the text would be most useful. Can you put that as a high priority on the wish list!! Thanks. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||