Moodle

Chat: Merge bugs fix and improments

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.1
  • Fix Version/s: 2.0
  • Component/s: Chat
  • Labels:
    None
  • Environment:
    Ubuntu, apache2, php5
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

So many changes, these need to merge step by step

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Hi Dongsheng. Great to see the "current" table to store recent messages. Sure it helps a lot! B-)

Reviewing code, I've seen, in index.php this line:

+ if (!$DB->insert_record('chat_messages', $newmessage) && !$DB->insert_record('chat_messages_current', $newmessage)) {

just guessing it should be || instead of &&.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi Dongsheng. Great to see the "current" table to store recent messages. Sure it helps a lot! B-) Reviewing code, I've seen, in index.php this line: + if (!$DB->insert_record('chat_messages', $newmessage) && !$DB->insert_record('chat_messages_current', $newmessage)) { just guessing it should be || instead of &&. Ciao
Hide
Permalink
Dongsheng Cai added a comment -

Sorry

Show
Dongsheng Cai added a comment - Sorry
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

np! great work! B-)

Show
Eloy Lafuente (stronk7) added a comment - np! great work! B-)
Hide
Permalink
Dongsheng Cai added a comment -

Further changes go to MDL-14651

Show
Dongsheng Cai added a comment - Further changes go to MDL-14651

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.