Issue Details (XML | Word | Printable)

Key: MDL-14650
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Dongsheng Cai
Reporter: Dongsheng Cai
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-8224

Chat: Merge bugs fix and improments

Created: 02/May/08 10:25 AM   Updated: 11/Dec/08 11:42 AM
Return to search
Component/s: Chat
Affects Version/s: 1.9.1
Fix Version/s: 2.0

Environment: Ubuntu, apache2, php5

Participants: Dongsheng Cai and Eloy Lafuente (stronk7)
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 11/Dec/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
So many changes, these need to merge step by step

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 25/Jul/08 01:25 AM
Hi Dongsheng. Great to see the "current" table to store recent messages. Sure it helps a lot! B-)

Reviewing code, I've seen, in index.php this line:

+ if (!$DB->insert_record('chat_messages', $newmessage) && !$DB->insert_record('chat_messages_current', $newmessage)) {

just guessing it should be || instead of &&.

Ciao


Dongsheng Cai added a comment - 25/Jul/08 11:09 AM
Sorry

Eloy Lafuente (stronk7) added a comment - 25/Jul/08 02:55 PM
np! great work! B-)

Dongsheng Cai added a comment - 11/Dec/08 11:42 AM
Further changes go to MDL-14651